• Maya Lekova's avatar
    Revert "[interpreter] Separate bytecodes for one-shot property loads and stores" · 3c3330f6
    Maya Lekova authored
    This reverts commit eccf1867.
    
    Reason for revert: Speculative revert because it seems to introduce a pretty stable flake on gc stress tests, see https://bugs.chromium.org/p/v8/issues/detail?id=8229
    
    Original change's description:
    > [interpreter] Separate bytecodes for one-shot property loads and stores
    > 
    > Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback
    > for one-shot property loads and stores. This CL replaces the runtime
    > calls with new bytecodes for named property load stores in one-shot code.
    > the runtime calls needed extra set of consecutive registers and
    > additional move instructions. This increased the size of
    > bytecode-array and possibly extended the life time of objects.
    > By replacing them with NoFeedback bytecodes we avoid these issues.
    > 
    > Bug: v8:8072
    > Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f
    > Reviewed-on: https://chromium-review.googlesource.com/1196725
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Chandan Reddy <chandanreddy@google.com>
    > Cr-Commit-Position: refs/heads/master@{#56211}
    
    TBR=rmcilroy@chromium.org,yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,cbruni@chromium.org,chandanreddy@google.com
    
    Change-Id: I445db58e6d4c275b434fabad5fad775bf259033f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8072
    Reviewed-on: https://chromium-review.googlesource.com/1245421Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56232}
    3c3330f6
debug-evaluate.cc 37.6 KB