• Leszek Swirski's avatar
    Revert "[wasm] Disallow late enabling of trap handlers" · 165467c4
    Leszek Swirski authored
    This reverts commit bcb0a7c5.
    
    Reason for revert: TSAN failure (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33868)
    
    Original change's description:
    > [wasm] Disallow late enabling of trap handlers
    >
    > It's dangerous if trap handlers are enabled after we already used the
    > information whether they are enabled or not.
    > This CL checks for such misbehaviour by remembering whether
    > {IsTrapHandlerEnabled} was already called, and disallowing
    > {EnableTrapHandler} afterwards. Also, calling {EnableTrapHandler}
    > multiple times is disallowed now.
    >
    > The trap handler tests are changed to only enable trap handlers once,
    > and to do that before allocating wasm memory or generating code.
    >
    > R=​ahaas@chromium.org
    >
    > Bug: v8:11017
    > Change-Id: Ib2256bb8435efd914c12769cedd4a0051052aeef
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2494935
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70750}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: I1d93dcb399e2a0b5b0543aa60d34087317c01cb3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:11017
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497176Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70751}
    165467c4
trap-handler.h 3.62 KB