• Simon Zünd's avatar
    [builtins] Add 'RestartFrameTrampoline' · b0118171
    Simon Zünd authored
    Doc: https://bit.ly/revive-restart-frame
    Context: https://crrev.com/c/3582395 (jumbo CL with the whole feature)
    
    This CL adds a new builtin called "RestartFrameTrampoline". This
    trampoline is relatively simple: It leaves the current frame and
    re-invokes the function. This essentially restarts the function and
    is one of the key components required to bring back the "Restart
    frame" DevTools debugging feature.
    
    The builtin is closely related to the "FrameDropperTrampoline"
    removed in the CL https://crrev.com/c/2854750. The key difference
    is that the "FrameDropperTrampoline" dropped to an "arbitrary"
    frame pointer before restarting the function (arbitrary in the
    sense that it was provided as an argument). This caused issues
    as the feature was implemented in a way that the frame pointer
    wasn't necessarily valid anymore.
    
    In comparison, the "RestartFrameTrampoline" relies on the V8
    unwinder to drop it in the correct frame first and is then
    invoked via either the CEntry stub or the deoptimizer
    (see design doc for details).
    
    Bug: chromium:1303521
    Change-Id: I7bd46620808f8694c2c776b8bcd267e525d5b581
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585944
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80254}
    b0118171
builtins-mips.cc 161 KB