• Shu-yu Guo's avatar
    Reland "[ptr-cage] Rename IsolateRoot to PtrComprCageBase" · 15c78b45
    Shu-yu Guo authored
    This is a reland of e28dadc2
    
    Relanding to see if Win32 rel failures from
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win32/32275/overview
    were infra flakes. Could not repro on try bots.
    
    Original change's description:
    > [ptr-cage] Rename IsolateRoot to PtrComprCageBase
    >
    > Currently, IsolateRoot is both the address of the Isolate root and the
    > base address of the pointer compression reservation. This CL teases the
    > two uses apart by renaming IsolateRoot to PtrComprCageBase.
    >
    > - In addition to V8_COMPRESS_POINTERS, add a
    >   V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE (vs SHARED_CAGE).
    >
    > - Rename GetIsolate* helpers to GetPtrComprCageBase. When
    >   V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE is true, the helpers remain as
    >   aliases to GetPtrComprCageBase.
    >
    > - Rename kPtrComprIsolateRootAlignment to kPtrComprCageBaseAlignment.
    >
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783672
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    
    No-Try: true
    Bug: v8:11460
    Tbr: ishell@chromium.org
    Tbr: rmcilroy@chromium.org
    Change-Id: I0a8c3a48999d6737c8c64d2c2703607f14f3fdd0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2806169Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73792}
    15c78b45
js-objects-inl.h 28.6 KB