• Tobias Tebbi's avatar
    Reland^2 "[torque] move class tests to unittests" · d47db126
    Tobias Tebbi authored
    This is a reland of c33a1ef2
    
    It seems the revert was based on a flake.
    
    Original change's description:
    > Reland "[torque] move class tests to unittests"
    >
    > This is a reland of f589d561
    >
    > Now with an ASAN-container-overflow false positive workaround:
    > Somehow ASAN was unhappy about a simple
    > std::vector<std::string>::push_back.
    > Increasing the std::vector capacity before doing the push_back
    > strangely fixes the problem.
    >
    > Original change's description:
    > > [torque] move class tests to unittests
    > >
    > > This avoids the generation of fake external classes.
    > >
    > > Bug: v8:7793
    > > Change-Id: I9744b299d3ec474d72b298b4f6143f95e345d1d9
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625991
    > > Reviewed-by: Simon Zünd <szuend@chromium.org>
    > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#61778}
    >
    > TBR: szuend@chromium.org, sigurds@chromium.org
    > Bug: v8:7793
    > Change-Id: Ifa1958e4d6e850ba27632aa95c7efaf5ca4bfefa
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627970
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61807}
    
    Bug: v8:7793
    Change-Id: Ia403f1b784500c0903172f13e74c0b325e82599f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627980Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61819}
    d47db126
utils.h 9.55 KB