• Peter Marshall's avatar
    Reland "[cpu-profiler] Fix a bug which caused a pure virtual function call" · 3767ab39
    Peter Marshall authored
    This is a reland of c92a1dda
    
    Original change's description:
    > [cpu-profiler] Fix a bug which caused a pure virtual function call
    >
    > We need to remove each Sampler from the SamplerManager before we call
    > the Sampler destructor. This is because the signal handler can interrupt
    > the destructor, and call DoSampler(), which calls sampler->SampleStack()
    > on the sampler being destructed, causing general unhappiness and
    > "Pure virtual function called!" crashes.
    >
    > Bug: v8:8346, v8:5193
    > Change-Id: Iaa595a196eab33fb1af31584e9a68fd1ce0a18f6
    > Reviewed-on: https://chromium-review.googlesource.com/c/1293949
    > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Alexei Filippov <alph@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#56882}
    
    TBR=yangguo@chromium.org
    
    Bug: v8:8346, v8:5193
    Change-Id: I9878f65c868ff1aed6f3a587cba688c4241bad8c
    Reviewed-on: https://chromium-review.googlesource.com/c/1298893Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56976}
    3767ab39
cpu-profiler.cc 13.9 KB