-
Paolo Severini authored
The csuite.py script does not work correctly on Windows. It runs correctly in baseline mode, but there are two problems when running in compare mode: 1. In compare mode the output of benchmark.py is piped to the compare-baseline.py script, but Windows only execute python files if python.exe is the default program to open '.py' files, and this is not the case, by default, when python is installed as part of the depot_tools. Fix: explicitly add the 'python' command before compare-baseline.py. 2. By default CSuite prints the results to stdout using escapes codes that add color highlights. But this does not work on Windows when compare-baseline.py is launched with a pipe: python test/benchmarks/csuite/benchmark.py <...> | python test/benchmarks/csuite/compare-baseline.py <baseline_results> Fix: Do not use a pipe. Write the benchmark numbers for the compare-run into a separate file, and pass the path to this file to compare-baseline.py Change-Id: Ic22d5bd4b47901f0ba0f35bc2496441346d21c6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656855Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72807}
a974dd7e