• Seth Brenith's avatar
    [torque] Allow single-param annotations in AnnotationSet · fb453dd4
    Seth Brenith authored
    Extend the order-independent annotation parsing logic to include the
    following forms:
      @foo                // bare annotation (already supported)
      @foo(0x70)          // decimal literal
      @foo(HI)            // identifier
      @foo("hello there") // quoted string
    This is obviously still pretty far from annotations in other languages,
    which usually support arbitrary expressions and multiple parameters, but
    I think it's sufficient to cover a pretty good variety of usages. The
    existing class-field annotations @if and @ifnot are reimplemented in the
    new style, meaning they could now appear in any order relative to other
    annotations on the same field (and can be repeated, though I doubt it
    would be of much use to anybody).
    
    Change-Id: I97b7c0c9a541ca3126b5ae3a2484688b04dda9f4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1754947
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63285}
    fb453dd4
torque-parser.cc 75.9 KB