• Clemens Hammacher's avatar
    [Liftoff] Keep consistent register mapping in non-merged regions · 20b63300
    Clemens Hammacher authored
    We currently de-duplicate used registers also in regions which do not
    need merging. In those regions though it can never happen that we need
    to pass different values from any merge input. Apart from introducing
    unnecessary register moves, this also causes a DCHECK to fail, because
    we might later want to merge back different registers into one.
    
    Assume this initial stack state (where each letter is a register):
    [A B B C]
    If in any child block the two Bs get de-duplicated so something like
    [A B D C]
    then we run into trouble when merging back this state into the parent
    state, because both B and D would need to be put into B.
    In this case we can statically infer that B and D must hold the same
    value anyway, but having this situation does not make much sense in the
    first place, so the DCHECK fires correctly.
    
    R=titzer@chromium.org
    
    Bug: v8:8423, chromium:917412
    Change-Id: I24c36b062e04a134cf7051725afab98126753f31
    Reviewed-on: https://chromium-review.googlesource.com/c/1392190
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58522}
    20b63300
liftoff-assembler.cc 29.6 KB