• Jakob Kummerow's avatar
    [test] Object verification should not recurse · ad8f2f6f
    Jakob Kummerow authored
    When running with --verify-heap, ObjectVerify() is invoked for every
    live object anyway, so there is no need for individual FooVerify()
    implementations to recursively request verification of their
    sub-objects. If they do, (a) it is duplicated work of O(n²) complexity,
    and (b) it can cause fuzzer-generated tests to crash because they run
    out of stack space when they trigger heap verification with very little
    stack space left.
    
    Fixed: chromium:1106426
    Change-Id: Ib9bd444806b148fffc23d635f931dfe73fe7e4ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358746
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69477}
    ad8f2f6f
objects-debug.cc 64.2 KB