• Shu-yu Guo's avatar
    Reland^2 "[ptr-cage] Rename IsolateRoot to PtrComprCageBase" · 627b6b2f
    Shu-yu Guo authored
    This is a reland of e28dadc2
    
    The original failure was due to a stale Win32 bot. The reland failure
    was due to idempotent task deduplication returning the exact same
    failure. See crbug/1196064
    
    Original change's description:
    > [ptr-cage] Rename IsolateRoot to PtrComprCageBase
    >
    > Currently, IsolateRoot is both the address of the Isolate root and the
    > base address of the pointer compression reservation. This CL teases the
    > two uses apart by renaming IsolateRoot to PtrComprCageBase.
    >
    > - In addition to V8_COMPRESS_POINTERS, add a
    >   V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE (vs SHARED_CAGE).
    >
    > - Rename GetIsolate* helpers to GetPtrComprCageBase. When
    >   V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE is true, the helpers remain as
    >   aliases to GetPtrComprCageBase.
    >
    > - Rename kPtrComprIsolateRootAlignment to kPtrComprCageBaseAlignment.
    >
    > Bug: v8:11460
    > Change-Id: I1d715f678ce9a0b5731895612ca14f56579b1c48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783672
    > Commit-Queue: Shu-yu Guo <syg@chromium.org>
    > Auto-Submit: Shu-yu Guo <syg@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73790}
    
    Bug: v8:11460
    No-Try: true
    Tbr: ishell@chromium.org
    Tbr: rmcilroy@chromium.org
    Change-Id: Id69311cf3267ebe1297fff159de0be48b15b65a3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2806546Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73795}
    627b6b2f
field-index-inl.h 3.17 KB