-
Omer Katz authored
building the unittests target for example fails when cppgc_is_standalone is set to true due to conflicting implementations of trace-event.h. It is not clear from the output for these failures that V8 targets cannot be built with cppgc_is_standalone. We could disable all non-cppgc targets that depend on cppgc when cppgc_is_standalone is set, but that would be fragile and dirty. Since all V8 targets need to include cppgc-js headers, adding a static assert in cpp-heap.h would cover all V8 targets. The static assert doesn't hide the current output, butadds a clear and expllicit message stating that it cannot be done. Bug: chromium:1056170 Change-Id: I8bd1b1a5ada18d9688e6b78de4693386539d78bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826535Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73968}
37c7eb27