• Leszek Swirski's avatar
    [GetIsolate] Remove GetHeap in object setters · 1744f10a
    Leszek Swirski authored
    Remove the GetHeap call in object setters, replacing it with a new
    Heap::FromHeapObject method which explicitly tests for the object
    not being in RO space. The hope is that this method is used sparingly.
    
    As a drive-by, memoize the heap access in the write barrier macros,
    to avoid having to calculate the heap location twice.
    
    Bug: v8:7786
    Change-Id: I26d1c41c673eddced17be316da6d51a16ac853e7
    Reviewed-on: https://chromium-review.googlesource.com/1114614
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54033}
    1744f10a
objects.cc 690 KB