• Ng Zhi An's avatar
    [tools] Fix lldb_commands jco by casting call · c8350144
    Ng Zhi An authored
    Currently, running jco gives us an error message like so:
    
    (lldb) jco $pc
    Failed to evaluate command _v8_internal_Print_Code((void*)($pc)) :
    error: <user expression 0>:1:1: '_v8_internal_Print_Code' has unknown
    return type; cast the call to its declared return type
    _v8_internal_Print_Code((void*)($pc))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    The fix is to cast the call to (void). I've only used and found this
    issue with jco, but I think the other commands have the same issue, so
    fixing those together here.
    
    FYI I am using lldb version 11.
    
    Bug: v8:11879
    Change-Id: Id9d8e8091fd011585e6fea863de5b4d7c9d47c5a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994764Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75487}
    c8350144
lldb_commands.py 4.17 KB