• ivica.bogosavljevic's avatar
    MIPS: Reland of `Fix bad RegisterConfiguration usage in InstructionSequence unit tests` · c42bbec9
    ivica.bogosavljevic authored
    Reland 0cf56232
    
    The original patch got reverted because testing RegisterConfiguration was
    overwritten by turbofan RegisterConfiguration. This caused some test cases not being
    properly tested. The new patch uses correct RegisterConfiguration.
    
    Original commit message:
    Test InstructionSequenceTest has been initialized with a testing RegisterConfiguration
    instance defined in instruction-sequence-unittest.h, whereas class ExplicitOperand which
    is being tested used RegisterConfiguration from instruction.cc. In case these two
    instances are different, the tests would fail. The issue is fixed by using the same
    instance of RegisterConfiguration both for test code and code under test.
    
    Additionally, the tests in register-allocator-unittest.cc use hardcoded values
    for register and begin failing is the hardcoded register is not available for
    allocation. Fix by forcing the use of allocatable registers only.
    
    TEST=unittests.MoveOptimizerTest.RemovesRedundantExplicit,unittests.RegisterAllocatorTest.SpillPhi
    BUG=
    
    Review-Url: https://codereview.chromium.org/2595293002
    Cr-Commit-Position: refs/heads/master@{#41938}
    c42bbec9
instruction.h 53.2 KB