• Mythri's avatar
    Reland "Change SetProperty/SetSuperProperty to infer language mode when possible" · e2846ea6
    Mythri authored
    This is a reland of 0896599f with a fix for
    failing layout test.
    
    Original change's description:
    > Change SetProperty/SetSuperProperty to infer language mode when possible
    >
    > In most cases, the language mode can be inferred from the closure and
    > the context. Computing the language mode instead of passing it around
    > simplifies the ICs and will make it possible to go towards lazily
    > allocating feedback vectors. Currently ICs obtain the language mode from
    > the feedback vectors and with lazy feedback allocation we may not always
    > have feedback vectors. Since computing language mode is a bit expensive
    > we want to defer it as far as possible.
    >
    > In Array builtins and other builtins like Reflect.Set we need to force a
    > language mode when setting the properties. To support these cases the
    > SetProperty methods allow the language mode to be overridden when needed.
    >
    > This is a first cl in a series of cls, that will defer the language mode
    > computation further and remove language mode where it is not needed.
    >
    > BUG: v8:8580
    > Change-Id: I9c2396e3bcfe77c3c9d6760c46d86954d54744b9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1409426
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58893}
    
    TBR: ahaas@chromium.org
    Change-Id: Id5d81eae91b55638dbc72168f0e5203e684869fb
    Reviewed-on: https://chromium-review.googlesource.com/c/1421077
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59075}
    e2846ea6
ic.h 12.8 KB