• Bill Budge's avatar
    Revert "Reland "Reland "[compiler][wasm] Align Frame slots to value size""" · 797c1e3b
    Bill Budge authored
    This reverts commit 352b9ecb.
    
    Reason for revert: fuzzers turned up more problems:
    https://bugs.chromium.org/p/chromium/issues/detail?id=1171759
    https://bugs.chromium.org/p/chromium/issues/detail?id=1171846
    
    tbr=ahaas@chromium.org,neis@chromium.org
    
    Original change's description:
    > Reland "Reland "[compiler][wasm] Align Frame slots to value size""
    >
    > This is a reland of 1694925c
    >
    > Minor fix to linkage for constexpr.
    >
    > TBR=ahaas@chromium.org,neis@chromium.org
    >
    > Original change's description:
    > > Reland "[compiler][wasm] Align Frame slots to value size"
    > >
    > > This is a reland of cddaf66c
    > >
    > > Original change's description:
    > > > [compiler][wasm] Align Frame slots to value size
    > > >
    > > > - Adds an AlignedSlotAllocator class and tests, to unify slot
    > > >   allocation. This attempts to use alignment holes for smaller
    > > >   values.
    > > > - Reworks Frame to use the new allocator for stack slots.
    > > > - Reworks LinkageAllocator to use the new allocator for stack
    > > >   slots and for ARMv7 FP register aliasing.
    > > > - Fixes the RegisterAllocator to align spill slots.
    > > > - Fixes InstructionSelector to align spill slots.
    > > >
    > > > Bug: v8:9198
    > > >
    > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840
    > > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#71644}
    > >
    > > Bug: v8:9198
    > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390
    > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#72195}
    >
    > Bug: v8:9198
    > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72209}
    
    TBR=bbudge@chromium.org,neis@chromium.org,ahaas@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:9198
    Change-Id: Ifee566e3e82f2e774525996b038ce135190d0be1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660378
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72447}
    797c1e3b
wasm-compiler.cc 332 KB