• tzik's avatar
    Replace %RunMicrotasks with %PerformMicrotaskCheckpoint · 07011cc4
    tzik authored
    This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
    
    RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
    and may causes nested Microtasks in a problematic way. E.g. that confuses
    v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
    
    OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
    respects the microtask suppressions.
    
    As all existing tests don't call RunMicrotasks() in the suppressed situation
    (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
    not affect to these tests.
    
    Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
    Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58068}
    07011cc4
reject-in-constructor-opt.js 1.44 KB