• tzik's avatar
    Replace %RunMicrotasks with %PerformMicrotaskCheckpoint · 07011cc4
    tzik authored
    This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
    
    RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
    and may causes nested Microtasks in a problematic way. E.g. that confuses
    v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
    
    OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
    respects the microtask suppressions.
    
    As all existing tests don't call RunMicrotasks() in the suppressed situation
    (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
    not affect to these tests.
    
    Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
    Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58068}
    07011cc4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...