• ssanfilippo's avatar
    [Interpreter] Refactor bytecode generator test suite. · 6ae03059
    ssanfilippo authored
    Bytecode expectations have been moved to external (.golden) files,
    one per test. Each test in the suite builds a representation of the
    the compiled bytecode using BytecodeExpectationsPrinter. The output is
    then compared to the golden file. If the comparision fails, a textual
    diff can be used to identify the discrepancies.
    
    Only the test snippets are left in the cc file, which also allows to
    make it more compact and meaningful. Leaving the snippets in the cc
    file was a deliberate choice to allow keeping the "truth" about the
    tests in the cc file, which will rarely change, as opposed to golden
    files.
    
    Golden files can be generated and kept up to date using
    generate-bytecode-expectations, which also means that the test suite
    can be batch updated whenever the bytecode or golden format changes.
    
    The golden format has been slightly amended (no more comments about
    `void*`, add size of the bytecode array) following the consideration
    made while converting the tests.
    
    There is also a fix: BytecodeExpectationsPrinter::top_level_ was left
    uninitialized, leading to undefined behaviour.
    
    BUG=v8:4280
    LOG=N
    
    Review URL: https://codereview.chromium.org/1717293002
    
    Cr-Commit-Position: refs/heads/master@{#34285}
    6ae03059
TryFinally.golden 3.64 KB