• Tim van der Lippe's avatar
    Revert "[inspector] Use side-effect free debug evaluate for inherited accessors." · e9d36117
    Tim van der Lippe authored
    This reverts commit f9ebad01.
    
    Reason for revert: suspected root cause of crbug.com/1257806 Additionally, this patch might actually be incorrect as we eagerly evaluate native accessors, which can only happen if the debugger is running.
    
    Original change's description:
    > [inspector] Use side-effect free debug evaluate for inherited accessors.
    >
    > Replace the hard-coded blocklist ("Response.body" and "Request.body") in
    > the V8 inspector with proper side-effect free debug evaluate. This is
    > otherwise a non-functional change and in particular preserves the
    > behavior of reporting accessors as (own) data properties. That will be
    > tackled in a follow-up CL.
    >
    > This CL is possible because with https://crrev.com/c/3056879 Blink now
    > properly marks accessors as side-effect free consistently with what the
    > V8 inspector had done before.
    >
    > Doc: http://doc/1gLyyOlssS5zyCSEyybVC-5sp0UnNJj2hBoFyf6ryrTc
    > Bug: chromium:829571, chromium:1076820, chromium:1119900
    > Change-Id: Idb256accaf4cfb5db5982b3eb06ddcef588be635
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062573
    > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
    > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76019}
    
    Bug: chromium:829571, chromium:1076820, chromium:1119900, chromium:1257806
    Fixed: chromium:1265372
    Change-Id: Ia31a3022aaa9ddeae1f01eaa90e345f8bdbb21c9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259653
    Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77708}
    e9d36117
value-mirror.cc 66 KB