• vogelheim's avatar
    Revert of [Tracing] Remove unnecessary memory allocation in runtime call... · eb7ba290
    vogelheim authored
    Revert of [Tracing] Remove unnecessary memory allocation in runtime call stats. (patchset #1 id:1 of https://codereview.chromium.org/2342643004/ )
    
    Reason for revert:
    Revert because this breaks V8's roll into Chromium. ASAN complains about memory accesses in a particular unit test.
    
    Borked roll CL:
    https://codereview.chromium.org/2348833002/
    
    Reproduce breakage with:
    
    1, args.gn:
      v8_deprecation_warnings = true
      use_goma = true
      is_asan = true
    2, ninja -C out/... content_browsertests
    3, out/.../content_browsertests --gtest_filter=V8SamplingProfilerTest.*
    
    Original issue's description:
    > [Tracing] Remove unnecessary memory allocation in runtime call stats.
    >
    > Previously we didn't implement TRACE_STR_COPY when we write trace events to
    > file, which causes us to allocate a growing independent memory chunk for dumped
    > runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
    > this memory allocation can be avoided, this patch removes it.
    >
    > BUG=v8:5089
    >
    > Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
    > Cr-Commit-Position: refs/heads/master@{#39462}
    
    TBR=cbruni@chromium.org,fmeawad@chromium.org,lpy@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5089
    
    Review-Url: https://codereview.chromium.org/2349593004
    Cr-Commit-Position: refs/heads/master@{#39475}
    eb7ba290
counters.cc 11.6 KB