• Georg Neis's avatar
    Revert "[compiler, heap] Create LocalHeap outside of ExecuteJob" · 04c85d7c
    Georg Neis authored
    This reverts commit 44708a5b.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33692
    
    Original change's description:
    > [compiler, heap] Create LocalHeap outside of ExecuteJob
    >
    > Create LocalHeap directly in the Task or in GetOptimizedCodeNow and
    > pass its reference as argument to ExecuteJob. This allows us to create
    > LocalHeap differently for the main and background thread, e.g. by
    > passing an additional argument to the constructor in the future.
    > It will be required in the future anyways when the main thread will
    > have its own LocalHeap/LocalIsolate.
    >
    > Extending the scope of LocalHeap, also made
    > HandleBase::IsDereferenceAllowed more precise and uncovered two
    > potential issues: heap accesses in
    > OptimizingCompileDispatcher::CompileNext and PipelineImpl::AssembleCode
    > with --code-comments.
    >
    > LocalHeap can now be created in the parked state. Also fixed a data
    > race with LocalHeap's destructor publishing write barrier entries
    > without holding the lock.
    >
    > Bug: v8:10315
    > Change-Id: I9226972601a07b87108cd66efbbb6a0d118af58d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460818
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70521}
    
    TBR=ulan@chromium.org,neis@chromium.org,leszeks@chromium.org,solanes@chromium.org,dinfuehr@chromium.org
    
    Change-Id: I9dd1f8ca6237d5716b6d8938cef0ee3f642f3166
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10315
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474118Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70522}
    04c85d7c
js-heap-broker.cc 201 KB