• Benedikt Meurer's avatar
    [inspector][wasm] Unify locals, stack, and globals objects. · 85fdbd91
    Benedikt Meurer authored
    This change unifies the locals, stack, and globals objects exposed for
    WebAssembly frames via the Scope view and via DebugEvaluate to use the
    same underlying objects (implemented via interceptors). This also
    means that for locals and globals we now consistently expose names
    prefixed by a dollar symbol everywhere.
    
    Drive-by-fix: Move the debug::ScopeIterator implementation for WasmFrame
    into debug-wasm-support.cc, so WebAssembly scope details are all found
    in one place instead of scattered around the code.
    
    Drive-by-cleanup: Rename GetJSDebugProxy to GetWasmDebugProxy for
    consistency. GetJSDebugProxy is a bit misleading, since the debug proxy
    is not about JavaScript, but just exposed to JavaScript.
    
    Doc: http://bit.ly/devtools-wasm-entities
    Bug: chromium:1159307, chromium:1127914, chromium:1162229
    Change-Id: If932bd06bbce72542823f63dac1bd976ab33937a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615348
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72009}
    85fdbd91
debug-stack-trace-iterator.cc 6.82 KB