PRESUBMIT.py 2.1 KB
Newer Older
1
# Copyright 2022 the V8 project authors. All rights reserved.
2 3 4
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

5 6
import json

7 8 9
# This line is 'magic' in that git-cl looks for it to decide whether to
# use Python3 instead of Python2 when running the code in this file.
USE_PYTHON3 = True
10 11 12 13 14 15 16 17 18 19 20 21 22 23 24


def _CheckTrialsConfig(input_api, output_api):
  def FilterFile(affected_file):
    return input_api.FilterSourceFile(
        affected_file,
        files_to_check=(r'.+clusterfuzz_trials_config\.json',))

  results = []
  for f in input_api.AffectedFiles(
      file_filter=FilterFile, include_deletes=False):
    with open(f.AbsoluteLocalPath()) as j:
      try:
        trials = json.load(j)
        for trial in trials:
25 26 27
          if not all(
              k in trial for k in ('app_args', 'app_name', 'probability')):
            results.append('trial {} is not configured correctly'.format(trial))
28
          if trial['app_name'] != 'd8':
29
            results.append('trial {} has an incorrect app_name'.format(trial))
30
          if not isinstance(trial['probability'], float):
31
            results.append('trial {} probability is not a float'.format(trial))
32
          if not (0 <= trial['probability'] <= 1):
33 34 35 36 37 38
            results.append(
                'trial {} has invalid probability value'.format(trial))
          if not isinstance(trial['app_args'], str) or not trial['app_args']:
            results.append(
                'trial {} should have a non-empty string for app_args'.format(
                    trial))
39 40 41 42 43 44 45 46 47 48 49 50 51 52
      except Exception as e:
        results.append(
            'JSON validation failed for %s. Error:\n%s' % (f.LocalPath(), e))

  return [output_api.PresubmitError(r) for r in results]

def _CommonChecks(input_api, output_api):
  """Checks common to both upload and commit."""
  checks = [
    _CheckTrialsConfig,
  ]

  return sum([check(input_api, output_api) for check in checks], [])

53
def CheckChangeOnCommit(input_api, output_api):
54
  return _CommonChecks(input_api, output_api)
55 56

def CheckChangeOnUpload(input_api, output_api):
57
  return _CommonChecks(input_api, output_api)