module-decoder-unittest.cc 88.8 KB
Newer Older
1 2 3 4 5 6
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "test/unittests/test-utils.h"

rossberg's avatar
rossberg committed
7 8
#include "src/handles.h"
#include "src/objects-inl.h"
9
#include "src/wasm/module-decoder.h"
10
#include "src/wasm/wasm-features.h"
11
#include "src/wasm/wasm-limits.h"
12
#include "src/wasm/wasm-opcodes.h"
13
#include "test/common/wasm/flag-utils.h"
14
#include "test/common/wasm/wasm-macro-gen.h"
15 16 17
#include "testing/gmock-support.h"

using testing::HasSubstr;
18 19 20 21

namespace v8 {
namespace internal {
namespace wasm {
22
namespace module_decoder_unittest {
23

24 25 26 27 28 29 30 31
#define WASM_INIT_EXPR_I32V_1(val) WASM_I32V_1(val), kExprEnd
#define WASM_INIT_EXPR_I32V_2(val) WASM_I32V_2(val), kExprEnd
#define WASM_INIT_EXPR_I32V_3(val) WASM_I32V_3(val), kExprEnd
#define WASM_INIT_EXPR_I32V_4(val) WASM_I32V_4(val), kExprEnd
#define WASM_INIT_EXPR_I32V_5(val) WASM_I32V_5(val), kExprEnd
#define WASM_INIT_EXPR_F32(val) WASM_F32(val), kExprEnd
#define WASM_INIT_EXPR_I64(val) WASM_I64(val), kExprEnd
#define WASM_INIT_EXPR_F64(val) WASM_F64(val), kExprEnd
32
#define WASM_INIT_EXPR_ANYREF WASM_REF_NULL, kExprEnd
33 34
#define WASM_INIT_EXPR_GLOBAL(index) WASM_GET_GLOBAL(index), kExprEnd

35 36
#define EMPTY_BODY 0
#define NOP_BODY 2, 0, kExprNop
37

38 39
#define SIG_ENTRY_i_i SIG_ENTRY_x_x(kLocalI32, kLocalI32)

40
#define UNKNOWN_SECTION(size) 0, U32V_1(size + 5), ADD_COUNT('l', 'u', 'l', 'z')
41

42 43 44
template <typename... Args>
std::integral_constant<size_t, sizeof...(Args)> CountArgsHelper(Args...);
#define COUNT_ARGS(...) (decltype(CountArgsHelper(__VA_ARGS__))::value)
45

46 47 48 49 50 51 52 53 54 55 56
template <size_t num>
struct CheckLEB1 : std::integral_constant<size_t, num> {
  static_assert(num <= I32V_MAX(1), "LEB range check");
};
#define CHECK_LEB1(num) CheckLEB1<num>::value

#define ADD_COUNT(...) CHECK_LEB1(COUNT_ARGS(__VA_ARGS__)), __VA_ARGS__

#define SECTION(name, ...) k##name##SectionCode, ADD_COUNT(__VA_ARGS__)

#define SIGNATURES_SECTION(count, ...) SECTION(Type, U32V_1(count), __VA_ARGS__)
57
#define FUNCTION_SIGNATURES_SECTION(count, ...) \
58
  SECTION(Function, U32V_1(count), __VA_ARGS__)
59

60
#define FOO_STRING ADD_COUNT('f', 'o', 'o')
61 62
#define NO_LOCAL_NAMES 0

63 64 65 66
#define EMPTY_SIGNATURES_SECTION SECTION(Type, ENTRY_COUNT(0))
#define EMPTY_FUNCTION_SIGNATURES_SECTION SECTION(Function, ENTRY_COUNT(0))
#define EMPTY_FUNCTION_BODIES_SECTION SECTION(Code, ENTRY_COUNT(0))
#define SECTION_NAMES(...) \
67
  SECTION(Unknown, ADD_COUNT('n', 'a', 'm', 'e'), ##__VA_ARGS__)
68
#define EMPTY_NAMES_SECTION SECTION_NAMES()
69 70 71 72 73
#define SECTION_SRC_MAP(...)                                               \
  SECTION(Unknown,                                                         \
          ADD_COUNT('s', 'o', 'u', 'r', 'c', 'e', 'M', 'a', 'p', 'p', 'i', \
                    'n', 'g', 'U', 'R', 'L'),                              \
          ADD_COUNT(__VA_ARGS__))
74

75 76 77 78
#define FAIL_IF_NO_EXPERIMENTAL_EH(data)                                 \
  do {                                                                   \
    ModuleResult result = DecodeModule((data), (data) + sizeof((data))); \
    EXPECT_FALSE(result.ok());                                           \
79
  } while (false)
80

81 82 83 84 85
#define X1(...) __VA_ARGS__
#define X2(...) __VA_ARGS__, __VA_ARGS__
#define X3(...) __VA_ARGS__, __VA_ARGS__, __VA_ARGS__
#define X4(...) __VA_ARGS__, __VA_ARGS__, __VA_ARGS__, __VA_ARGS__

86
#define ONE_EMPTY_FUNCTION(sig_index) \
87
  SECTION(Function, ENTRY_COUNT(1), X1(sig_index))
88

89
#define TWO_EMPTY_FUNCTIONS(sig_index) \
90
  SECTION(Function, ENTRY_COUNT(2), X2(sig_index))
91

92
#define THREE_EMPTY_FUNCTIONS(sig_index) \
93
  SECTION(Function, ENTRY_COUNT(3), X3(sig_index))
94

95
#define FOUR_EMPTY_FUNCTIONS(sig_index) \
96
  SECTION(Function, ENTRY_COUNT(4), X4(sig_index))
97

98 99 100 101
#define ONE_EMPTY_BODY SECTION(Code, ENTRY_COUNT(1), X1(EMPTY_BODY))
#define TWO_EMPTY_BODIES SECTION(Code, ENTRY_COUNT(2), X2(EMPTY_BODY))
#define THREE_EMPTY_BODIES SECTION(Code, ENTRY_COUNT(3), X3(EMPTY_BODY))
#define FOUR_EMPTY_BODIES SECTION(Code, ENTRY_COUNT(4), X4(EMPTY_BODY))
102

103
#define SIGNATURES_SECTION_VOID_VOID \
104
  SECTION(Type, ENTRY_COUNT(1), SIG_ENTRY_v_v)
105 106

#define LINEAR_MEMORY_INDEX_0 0
titzer's avatar
titzer committed
107

108 109
#define EXCEPTION_ENTRY(sig_index) U32V_1(kExceptionAttribute), sig_index

110 111 112 113
#define EXPECT_VERIFIES(data)                                      \
  do {                                                             \
    ModuleResult result = DecodeModule(data, data + sizeof(data)); \
    EXPECT_TRUE(result.ok());                                      \
114 115
  } while (false)

116 117 118 119
#define EXPECT_FAILURE_LEN(data, length)                     \
  do {                                                       \
    ModuleResult result = DecodeModule(data, data + length); \
    EXPECT_FALSE(result.ok());                               \
120 121
  } while (false)

122 123
#define EXPECT_FAILURE(data) EXPECT_FAILURE_LEN(data, sizeof(data))

124 125 126 127 128 129
#define EXPECT_OFF_END_FAILURE(data, min)                           \
  do {                                                              \
    STATIC_ASSERT(min < arraysize(data));                           \
    for (size_t length = min; length < arraysize(data); length++) { \
      EXPECT_FAILURE_LEN(data, length);                             \
    }                                                               \
130
  } while (false)
131

132 133 134 135
#define EXPECT_OK(result)     \
  do {                        \
    EXPECT_TRUE(result.ok()); \
    if (!result.ok()) return; \
136 137
  } while (false)

138 139 140 141
#define EXPECT_NOT_OK(result, msg)                         \
  do {                                                     \
    EXPECT_FALSE(result.ok());                             \
    EXPECT_THAT(result.error().message(), HasSubstr(msg)); \
142 143
  } while (false)

144 145 146 147 148 149 150 151 152
static size_t SizeOfVarInt(size_t value) {
  size_t size = 0;
  do {
    size++;
    value = value >> 7;
  } while (value > 0);
  return size;
}

153
struct ValueTypePair {
154
  uint8_t code;
155
  ValueType type;
156 157 158 159 160 161 162 163
} kValueTypes[] = {
    {kLocalI32, kWasmI32},          // --
    {kLocalI64, kWasmI64},          // --
    {kLocalF32, kWasmF32},          // --
    {kLocalF64, kWasmF64},          // --
    {kLocalAnyFunc, kWasmAnyFunc},  // --
    {kLocalAnyRef, kWasmAnyRef}     // --
};
164

165
class WasmModuleVerifyTest : public TestWithIsolateAndZone {
166
 public:
167 168
  WasmFeatures enabled_features_;

169
  ModuleResult DecodeModule(const byte* module_start, const byte* module_end) {
170
    // Add the wasm magic and version number automatically.
171 172 173 174 175
    size_t size = static_cast<size_t>(module_end - module_start);
    byte header[] = {WASM_MODULE_HEADER};
    size_t total = sizeof(header) + size;
    auto temp = new byte[total];
    memcpy(temp, header, sizeof(header));
176 177 178
    if (size > 0) {
      memcpy(temp + sizeof(header), module_start, size);
    }
179 180 181
    ModuleResult result = DecodeWasmModule(
        enabled_features_, temp, temp + total, false, kWasmOrigin,
        isolate()->counters(), isolate()->allocator());
182 183 184 185 186
    delete[] temp;
    return result;
  }
  ModuleResult DecodeModuleNoHeader(const byte* module_start,
                                    const byte* module_end) {
187 188 189 190 191 192 193 194 195 196 197 198 199 200
    return DecodeWasmModule(enabled_features_, module_start, module_end, false,
                            kWasmOrigin, isolate()->counters(),
                            isolate()->allocator());
  }
};

namespace {
class EnableBoolScope {
 public:
  bool prev_;
  bool* ptr_;
  explicit EnableBoolScope(bool* ptr, bool val = true)
      : prev_(*ptr), ptr_(ptr) {
    *ptr = val;
201
  }
202
  ~EnableBoolScope() { *ptr_ = prev_; }
203
};
204

205 206 207 208 209 210 211
#define WASM_FEATURE_SCOPE(feat) \
  EnableBoolScope feat##_scope(&this->enabled_features_.feat)

#define WASM_FEATURE_SCOPE_VAL(feat, val) \
  EnableBoolScope feat##_scope(&this->enabled_features_.feat, val)
}  // namespace

212 213
TEST_F(WasmModuleVerifyTest, WrongMagic) {
  for (uint32_t x = 1; x; x <<= 1) {
214
    const byte data[] = {U32_LE(kWasmMagic ^ x), U32_LE(kWasmVersion)};
215 216
    ModuleResult result = DecodeModuleNoHeader(data, data + sizeof(data));
    EXPECT_FALSE(result.ok());
217
  }
218 219 220 221
}

TEST_F(WasmModuleVerifyTest, WrongVersion) {
  for (uint32_t x = 1; x; x <<= 1) {
222
    const byte data[] = {U32_LE(kWasmMagic), U32_LE(kWasmVersion ^ x)};
223 224
    ModuleResult result = DecodeModuleNoHeader(data, data + sizeof(data));
    EXPECT_FALSE(result.ok());
225 226 227
  }
}

228
TEST_F(WasmModuleVerifyTest, DecodeEmpty) {
229
  ModuleResult result = DecodeModule(nullptr, nullptr);
230
  EXPECT_TRUE(result.ok());
231
}
232 233

TEST_F(WasmModuleVerifyTest, OneGlobal) {
234
  static const byte data[] = {
235 236 237 238 239
      SECTION(Global,                     // --
              ENTRY_COUNT(1),             // --
              kLocalI32,                  // local type
              0,                          // immutable
              WASM_INIT_EXPR_I32V_1(13))  // init
240 241 242 243
  };

  {
    // Should decode to exactly one global.
244
    ModuleResult result = DecodeModule(data, data + sizeof(data));
245
    EXPECT_OK(result);
246 247 248
    EXPECT_EQ(1u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(0u, result.value()->data_segments.size());
249

250
    const WasmGlobal* global = &result.value()->globals.back();
251

252
    EXPECT_EQ(kWasmI32, global->type);
253
    EXPECT_EQ(0u, global->offset);
254
    EXPECT_FALSE(global->mutability);
255 256
    EXPECT_EQ(WasmInitExpr::kI32Const, global->init.kind);
    EXPECT_EQ(13, global->init.val.i32_const);
257 258
  }

259
  EXPECT_OFF_END_FAILURE(data, 1);
260 261
}

262
TEST_F(WasmModuleVerifyTest, AnyRefGlobal) {
263
  WASM_FEATURE_SCOPE(anyref);
264
  static const byte data[] = {
265 266 267 268 269
      SECTION(Global,                 // --
              ENTRY_COUNT(1),         // --
              kLocalAnyRef,           // local type
              0,                      // immutable
              WASM_INIT_EXPR_ANYREF)  // init
270 271 272 273 274 275
  };

  {
    // Should decode to exactly one global.
    ModuleResult result = DecodeModule(data, data + sizeof(data));
    EXPECT_OK(result);
276 277 278
    EXPECT_EQ(1u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(0u, result.value()->data_segments.size());
279

280
    const WasmGlobal* global = &result.value()->globals.back();
281 282 283 284 285 286 287 288

    EXPECT_EQ(kWasmAnyRef, global->type);
    EXPECT_FALSE(global->mutability);
    EXPECT_EQ(WasmInitExpr::kAnyRefConst, global->init.kind);
  }
}

TEST_F(WasmModuleVerifyTest, AnyRefGlobalWithGlobalInit) {
289
  WASM_FEATURE_SCOPE(anyref);
290
  static const byte data[] = {
291 292
      SECTION(Import,           // --
              ENTRY_COUNT(1),   // number of imports
293 294
              ADD_COUNT('m'),   // module name
              ADD_COUNT('f'),   // global name
295 296 297 298 299 300 301 302
              kExternalGlobal,  // import kind
              kLocalAnyRef,     // type
              0),               // mutability
      SECTION(Global,           // --
              ENTRY_COUNT(1),
              kLocalAnyRef,  // local type
              0,             // immutable
              WASM_INIT_EXPR_GLOBAL(0)),
303 304 305 306 307 308
  };

  {
    // Should decode to exactly one global.
    ModuleResult result = DecodeModule(data, data + sizeof(data));
    EXPECT_OK(result);
309 310 311
    EXPECT_EQ(2u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(0u, result.value()->data_segments.size());
312

313
    const WasmGlobal* global = &result.value()->globals.back();
314 315 316 317 318 319 320

    EXPECT_EQ(kWasmAnyRef, global->type);
    EXPECT_FALSE(global->mutability);
    EXPECT_EQ(WasmInitExpr::kGlobalIndex, global->init.kind);
  }
}

321 322
TEST_F(WasmModuleVerifyTest, Global_invalid_type) {
  static const byte data[] = {
323 324 325 326 327
      SECTION(Global,                      // --
              ENTRY_COUNT(1),              // --
              64,                          // invalid memory type
              1,                           // mutable
              WASM_INIT_EXPR_I32V_1(33)),  // init
328 329
  };

330
  EXPECT_FAILURE(data);
331 332 333 334
}

TEST_F(WasmModuleVerifyTest, Global_invalid_type2) {
  static const byte data[] = {
335 336 337 338 339
      SECTION(Global,                      // --
              ENTRY_COUNT(1),              // --
              kLocalVoid,                  // invalid memory type
              1,                           // mutable
              WASM_INIT_EXPR_I32V_1(33)),  // init
340 341
  };

342
  EXPECT_FAILURE(data);
343 344
}

345
TEST_F(WasmModuleVerifyTest, ZeroGlobals) {
346
  static const byte data[] = {SECTION(Global, ENTRY_COUNT(0))};
347
  ModuleResult result = DecodeModule(data, data + sizeof(data));
348
  EXPECT_OK(result);
349 350
}

351 352 353
TEST_F(WasmModuleVerifyTest, ExportMutableGlobal) {
  {
    static const byte data[] = {
354 355 356 357 358 359 360 361 362 363
        SECTION(Global,                         // --
                ENTRY_COUNT(1),                 // --
                kLocalI32,                      // local type
                0,                              // immutable
                WASM_INIT_EXPR_I32V_1(13)),     // init
        SECTION(Export,                         // --
                ENTRY_COUNT(1),                 // export count
                ADD_COUNT('n', 'a', 'm', 'e'),  // name
                kExternalGlobal,                // global
                0),                             // global index
364 365 366 367 368
    };
    EXPECT_VERIFIES(data);
  }
  {
    static const byte data[] = {
369 370 371 372 373 374 375 376 377 378
        SECTION(Global,                         // --
                ENTRY_COUNT(1),                 // --
                kLocalI32,                      // local type
                1,                              // mutable
                WASM_INIT_EXPR_I32V_1(13)),     // init
        SECTION(Export,                         // --
                ENTRY_COUNT(1),                 // export count
                ADD_COUNT('n', 'a', 'm', 'e'),  // name
                kExternalGlobal,                // global
                0),                             // global index
379
    };
380
    EXPECT_VERIFIES(data);
381 382 383
  }
}

384 385 386
static void AppendUint32v(std::vector<byte>& buffer, uint32_t val) {
  while (true) {
    uint32_t next = val >> 7;
387
    uint32_t out = val & 0x7F;
388 389 390 391 392 393 394 395 396 397 398
    if (next) {
      buffer.push_back(static_cast<byte>(0x80 | out));
      val = next;
    } else {
      buffer.push_back(static_cast<byte>(out));
      break;
    }
  }
}

TEST_F(WasmModuleVerifyTest, NGlobals) {
399
  static const byte data[] = {
400 401 402
      kLocalF32,                // memory type
      0,                        // immutable
      WASM_INIT_EXPR_F32(7.7),  // init
403
  };
404

405
  for (uint32_t i = 0; i < kV8MaxWasmGlobals; i = i * 13 + 1) {
406
    std::vector<byte> buffer;
407
    size_t size = SizeOfVarInt(i) + i * sizeof(data);
408
    const byte globals[] = {kGlobalSectionCode, U32V_5(size)};
409 410 411 412
    for (size_t g = 0; g != sizeof(globals); ++g) {
      buffer.push_back(globals[g]);
    }
    AppendUint32v(buffer, i);  // Number of globals.
413
    for (uint32_t j = 0; j < i; j++) {
414
      buffer.insert(buffer.end(), data, data + sizeof(data));
415 416 417
    }

    ModuleResult result = DecodeModule(&buffer[0], &buffer[0] + buffer.size());
418
    EXPECT_OK(result);
419 420 421 422
  }
}

TEST_F(WasmModuleVerifyTest, GlobalWithInvalidMemoryType) {
423 424 425 426 427
  static const byte data[] = {SECTION(Global,          // --
                                      ENTRY_COUNT(1),  // --
                                      33,              // memory type
                                      0,               // exported
                                      WASM_INIT_EXPR_I32V_1(1))};
428 429 430 431 432

  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, TwoGlobals) {
433 434 435 436 437 438 439 440
  static const byte data[] = {SECTION(Global,                      // --
                                      ENTRY_COUNT(2),              // --
                                      kLocalF32,                   // type
                                      0,                           // immutable
                                      WASM_INIT_EXPR_F32(22.0),    // --
                                      kLocalF64,                   // type
                                      1,                           // mutable
                                      WASM_INIT_EXPR_F64(23.0))};  // --
441 442 443

  {
    // Should decode to exactly two globals.
444
    ModuleResult result = DecodeModule(data, data + sizeof(data));
445
    EXPECT_OK(result);
446 447 448
    EXPECT_EQ(2u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(0u, result.value()->data_segments.size());
449

450
    const WasmGlobal* g0 = &result.value()->globals[0];
451

452
    EXPECT_EQ(kWasmF32, g0->type);
453
    EXPECT_EQ(0u, g0->offset);
454
    EXPECT_FALSE(g0->mutability);
455 456
    EXPECT_EQ(WasmInitExpr::kF32Const, g0->init.kind);

457
    const WasmGlobal* g1 = &result.value()->globals[1];
458

459
    EXPECT_EQ(kWasmF64, g1->type);
460
    EXPECT_EQ(8u, g1->offset);
461
    EXPECT_TRUE(g1->mutability);
462
    EXPECT_EQ(WasmInitExpr::kF64Const, g1->init.kind);
463 464
  }

465
  EXPECT_OFF_END_FAILURE(data, 1);
466 467
}

468
TEST_F(WasmModuleVerifyTest, ZeroExceptions) {
469
  static const byte data[] = {SECTION(Exception, ENTRY_COUNT(0))};
470
  FAIL_IF_NO_EXPERIMENTAL_EH(data);
471

472
  WASM_FEATURE_SCOPE(eh);
473 474
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
475
  EXPECT_EQ(0u, result.value()->exceptions.size());
476 477 478
}

TEST_F(WasmModuleVerifyTest, OneI32Exception) {
479 480
  static const byte data[] = {
      SECTION(Type, ENTRY_COUNT(1), SIG_ENTRY_v_x(kLocalI32)),  // sig#0 (i32)
481 482
      SECTION(Exception, ENTRY_COUNT(1),
              EXCEPTION_ENTRY(SIG_INDEX(0)))};  // except[0] (sig#0)
483
  FAIL_IF_NO_EXPERIMENTAL_EH(data);
484

485
  WASM_FEATURE_SCOPE(eh);
486 487
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
488
  EXPECT_EQ(1u, result.value()->exceptions.size());
489

490
  const WasmException& e0 = result.value()->exceptions.front();
491
  EXPECT_EQ(1u, e0.sig->parameter_count());
492
  EXPECT_EQ(kWasmI32, e0.sig->GetParam(0));
493 494 495
}

TEST_F(WasmModuleVerifyTest, TwoExceptions) {
496 497 498 499 500
  static const byte data[] = {
      SECTION(Type, ENTRY_COUNT(2),
              SIG_ENTRY_v_x(kLocalI32),               // sig#0 (i32)
              SIG_ENTRY_v_xx(kLocalF32, kLocalI64)),  // sig#1 (f32, i64)
      SECTION(Exception, ENTRY_COUNT(2),
501 502
              EXCEPTION_ENTRY(SIG_INDEX(1)),    // except[0] (sig#1)
              EXCEPTION_ENTRY(SIG_INDEX(0)))};  // except[1] (sig#0)
503 504
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

505
  WASM_FEATURE_SCOPE(eh);
506 507
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
508 509
  EXPECT_EQ(2u, result.value()->exceptions.size());
  const WasmException& e0 = result.value()->exceptions.front();
510
  EXPECT_EQ(2u, e0.sig->parameter_count());
511 512
  EXPECT_EQ(kWasmF32, e0.sig->GetParam(0));
  EXPECT_EQ(kWasmI64, e0.sig->GetParam(1));
513
  const WasmException& e1 = result.value()->exceptions.back();
514
  EXPECT_EQ(kWasmI32, e1.sig->GetParam(0));
515 516
}

517
TEST_F(WasmModuleVerifyTest, Exception_invalid_sig_index) {
518 519 520
  static const byte data[] = {
      SIGNATURES_SECTION_VOID_VOID,
      SECTION(Exception, ENTRY_COUNT(1),
521 522
              EXCEPTION_ENTRY(
                  SIG_INDEX(23)))};  // except[0] (sig#23 [out-of-bounds])
523 524 525 526
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  // Should fail decoding exception section.
  WASM_FEATURE_SCOPE(eh);
527 528
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "signature index 23 out of bounds");
529 530 531
}

TEST_F(WasmModuleVerifyTest, Exception_invalid_sig_return) {
532 533 534
  static const byte data[] = {
      SECTION(Type, ENTRY_COUNT(1), SIG_ENTRY_i_i),
      SECTION(Exception, ENTRY_COUNT(1),
535 536
              EXCEPTION_ENTRY(
                  SIG_INDEX(0)))};  // except[0] (sig#0 [invalid-return-type])
537
  FAIL_IF_NO_EXPERIMENTAL_EH(data);
538

539
  // Should fail decoding exception section.
540
  WASM_FEATURE_SCOPE(eh);
541 542
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "exception signature 0 has non-void return");
543 544
}

545 546 547 548 549 550 551 552 553 554 555 556 557
TEST_F(WasmModuleVerifyTest, Exception_invalid_attribute) {
  static const byte data[] = {
      SECTION(Type, ENTRY_COUNT(1), SIG_ENTRY_i_i),
      SECTION(Exception, ENTRY_COUNT(1), 23,
              SIG_INDEX(0))};  // except[0] (sig#0) [invalid-attribute]
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  // Should fail decoding exception section.
  WASM_FEATURE_SCOPE(eh);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "exception attribute 23 not supported");
}

558
TEST_F(WasmModuleVerifyTest, ExceptionSectionCorrectPlacement) {
559 560 561
  static const byte data[] = {SECTION(Import, ENTRY_COUNT(0)),
                              SECTION(Exception, ENTRY_COUNT(0)),
                              SECTION(Export, ENTRY_COUNT(0))};
562 563 564 565 566 567 568
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
}

569
TEST_F(WasmModuleVerifyTest, ExceptionSectionAfterExport) {
570 571
  static const byte data[] = {SECTION(Export, ENTRY_COUNT(0)),
                              SECTION(Exception, ENTRY_COUNT(0))};
572 573 574
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
575
  ModuleResult result = DecodeModule(data, data + sizeof(data));
576 577
  EXPECT_NOT_OK(result,
                "The Exception section must appear before the Export section");
578 579
}

580
TEST_F(WasmModuleVerifyTest, ExceptionSectionBeforeGlobal) {
581
  static const byte data[] = {SECTION(Exception, ENTRY_COUNT(0)),
582
                              SECTION(Global, ENTRY_COUNT(0))};
583 584 585
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
586
  ModuleResult result = DecodeModule(data, data + sizeof(data));
587
  EXPECT_NOT_OK(result, "unexpected section <Global>");
588 589
}

590 591 592
TEST_F(WasmModuleVerifyTest, ExceptionSectionAfterMemoryBeforeGlobal) {
  STATIC_ASSERT(kMemorySectionCode + 1 == kGlobalSectionCode);
  static const byte data[] = {SECTION(Memory, ENTRY_COUNT(0)),
593
                              SECTION(Exception, ENTRY_COUNT(0)),
594
                              SECTION(Global, ENTRY_COUNT(0))};
595 596 597 598
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
599
  EXPECT_NOT_OK(result, "unexpected section <Global>");
600 601
}

602
TEST_F(WasmModuleVerifyTest, ExceptionImport) {
603 604 605 606 607 608 609 610
  static const byte data[] = {
      SIGNATURES_SECTION_VOID_VOID,
      SECTION(Import,                           // section header
              ENTRY_COUNT(1),                   // number of imports
              ADD_COUNT('m'),                   // module name
              ADD_COUNT('e', 'x'),              // exception name
              kExternalException,               // import kind
              EXCEPTION_ENTRY(SIG_INDEX(0)))};  // except[0] (sig#0)
611 612 613 614 615
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
616 617
  EXPECT_EQ(1u, result.value()->exceptions.size());
  EXPECT_EQ(1u, result.value()->import_table.size());
618 619
}

620
TEST_F(WasmModuleVerifyTest, ExceptionExport) {
621 622 623 624 625 626 627 628
  static const byte data[] = {
      SIGNATURES_SECTION_VOID_VOID,
      SECTION(Exception, ENTRY_COUNT(1),
              EXCEPTION_ENTRY(SIG_INDEX(0))),  // except[0] (sig#0)
      SECTION(Export, ENTRY_COUNT(1),          // --
              NO_NAME,                         // --
              kExternalException,              // --
              EXCEPTION_INDEX(0))};
629 630 631 632 633
  FAIL_IF_NO_EXPERIMENTAL_EH(data);

  WASM_FEATURE_SCOPE(eh);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
634 635
  EXPECT_EQ(1u, result.value()->exceptions.size());
  EXPECT_EQ(1u, result.value()->export_table.size());
636 637
}

638
TEST_F(WasmModuleVerifyTest, OneSignature) {
titzer's avatar
titzer committed
639
  {
640
    static const byte data[] = {SIGNATURES_SECTION_VOID_VOID};
titzer's avatar
titzer committed
641 642 643 644
    EXPECT_VERIFIES(data);
  }

  {
645
    static const byte data[] = {SECTION(Type, ENTRY_COUNT(1), SIG_ENTRY_i_i)};
titzer's avatar
titzer committed
646 647
    EXPECT_VERIFIES(data);
  }
648 649 650 651
}

TEST_F(WasmModuleVerifyTest, MultipleSignatures) {
  static const byte data[] = {
652 653 654 655 656 657
      SECTION(
          Type,                                              // --
          ENTRY_COUNT(3),                                    // --
          SIG_ENTRY_v_v,                                     // void -> void
          SIG_ENTRY_x_x(kLocalI32, kLocalF32),               // f32 -> i32
          SIG_ENTRY_x_xx(kLocalI32, kLocalF64, kLocalF64)),  // f64,f64 -> i32
658 659
  };

660
  ModuleResult result = DecodeModule(data, data + sizeof(data));
661
  EXPECT_OK(result);
662 663 664 665 666 667 668 669 670
  EXPECT_EQ(3u, result.value()->signatures.size());
  if (result.value()->signatures.size() == 3) {
    EXPECT_EQ(0u, result.value()->signatures[0]->return_count());
    EXPECT_EQ(1u, result.value()->signatures[1]->return_count());
    EXPECT_EQ(1u, result.value()->signatures[2]->return_count());

    EXPECT_EQ(0u, result.value()->signatures[0]->parameter_count());
    EXPECT_EQ(1u, result.value()->signatures[1]->parameter_count());
    EXPECT_EQ(2u, result.value()->signatures[2]->parameter_count());
671 672
  }

673
  EXPECT_OFF_END_FAILURE(data, 1);
674 675
}

676 677 678
TEST_F(WasmModuleVerifyTest, DataSegmentWithImmutableImportedGlobal) {
  // Import 2 globals so that we can initialize data with a global index != 0.
  const byte data[] = {
679 680
      SECTION(Import,           // section header
              ENTRY_COUNT(2),   // number of imports
681 682
              ADD_COUNT('m'),   // module name
              ADD_COUNT('f'),   // global name
683 684 685
              kExternalGlobal,  // import kind
              kLocalI32,        // type
              0,                // mutability
686 687
              ADD_COUNT('n'),   // module name
              ADD_COUNT('g'),   // global name
688 689 690 691 692 693 694 695
              kExternalGlobal,  // import kind
              kLocalI32,        // type
              0),               // mutability
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_GLOBAL(1),  // dest addr
              U32V_1(3),                 // source size
              'a', 'b', 'c')             // data bytes
696 697 698
  };
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
699
  WasmInitExpr expr = result.value()->data_segments.back().dest_addr;
700
  EXPECT_EQ(WasmInitExpr::kGlobalIndex, expr.kind);
701
  EXPECT_EQ(1u, expr.val.global_index);
702 703 704 705 706
}

TEST_F(WasmModuleVerifyTest, DataSegmentWithMutableImportedGlobal) {
  // Only an immutable imported global can be used as an init_expr.
  const byte data[] = {
707 708
      SECTION(Import,           // section header
              ENTRY_COUNT(1),   // number of imports
709 710
              ADD_COUNT('m'),   // module name
              ADD_COUNT('f'),   // global name
711 712 713 714 715 716 717 718
              kExternalGlobal,  // import kind
              kLocalI32,        // type
              1),               // mutability
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_GLOBAL(0),  // dest addr
              U32V_1(3),                 // source size
              'a', 'b', 'c')             // data bytes
719 720 721 722 723 724
  };
  EXPECT_FAILURE(data);
}
TEST_F(WasmModuleVerifyTest, DataSegmentWithImmutableGlobal) {
  // Only an immutable imported global can be used as an init_expr.
  const byte data[] = {
725 726 727 728 729 730 731 732 733
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Global, ENTRY_COUNT(1),
              kLocalI32,                        // local type
              0,                                // immutable
              WASM_INIT_EXPR_I32V_3(0x9BBAA)),  // init
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_GLOBAL(0),  // dest addr
              U32V_1(3),                 // source size
              'a', 'b', 'c')             // data bytes
734 735 736 737
  };
  EXPECT_FAILURE(data);
}

738
TEST_F(WasmModuleVerifyTest, OneDataSegment) {
739
  const byte kDataSegmentSourceOffset = 24;
740
  const byte data[] = {
741 742 743 744 745
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_I32V_3(0x9BBAA),  // dest addr
              U32V_1(3),                       // source size
              'a', 'b', 'c')                   // data bytes
746 747 748
  };

  {
749
    EXPECT_VERIFIES(data);
750
    ModuleResult result = DecodeModule(data, data + sizeof(data));
751
    EXPECT_OK(result);
752 753 754
    EXPECT_EQ(0u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(1u, result.value()->data_segments.size());
755

756
    const WasmDataSegment* segment = &result.value()->data_segments.back();
757

758
    EXPECT_EQ(WasmInitExpr::kI32Const, segment->dest_addr.kind);
759
    EXPECT_EQ(0x9BBAA, segment->dest_addr.val.i32_const);
760 761
    EXPECT_EQ(kDataSegmentSourceOffset, segment->source.offset());
    EXPECT_EQ(3u, segment->source.length());
762 763
  }

764
  EXPECT_OFF_END_FAILURE(data, 14);
765 766 767
}

TEST_F(WasmModuleVerifyTest, TwoDataSegments) {
768 769
  const byte kDataSegment0SourceOffset = 24;
  const byte kDataSegment1SourceOffset = kDataSegment0SourceOffset + 11;
770

771
  const byte data[] = {
772 773 774 775 776 777 778 779 780 781 782
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data,
              ENTRY_COUNT(2),  // segment count
              LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_I32V_3(0x7FFEE),  // #0: dest addr
              U32V_1(4),                       // source size
              1, 2, 3, 4,                      // data bytes
              LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_I32V_3(0x6DDCC),  // #1: dest addr
              U32V_1(10),                      // source size
              1, 2, 3, 4, 5, 6, 7, 8, 9, 10)   // data bytes
783 784 785
  };

  {
786
    ModuleResult result = DecodeModule(data, data + sizeof(data));
787
    EXPECT_OK(result);
788 789 790
    EXPECT_EQ(0u, result.value()->globals.size());
    EXPECT_EQ(0u, result.value()->functions.size());
    EXPECT_EQ(2u, result.value()->data_segments.size());
791

792 793
    const WasmDataSegment* s0 = &result.value()->data_segments[0];
    const WasmDataSegment* s1 = &result.value()->data_segments[1];
794

795
    EXPECT_EQ(WasmInitExpr::kI32Const, s0->dest_addr.kind);
796
    EXPECT_EQ(0x7FFEE, s0->dest_addr.val.i32_const);
797 798
    EXPECT_EQ(kDataSegment0SourceOffset, s0->source.offset());
    EXPECT_EQ(4u, s0->source.length());
799

800
    EXPECT_EQ(WasmInitExpr::kI32Const, s1->dest_addr.kind);
801
    EXPECT_EQ(0x6DDCC, s1->dest_addr.val.i32_const);
802 803
    EXPECT_EQ(kDataSegment1SourceOffset, s1->source.offset());
    EXPECT_EQ(10u, s1->source.length());
804 805
  }

806
  EXPECT_OFF_END_FAILURE(data, 14);
807 808
}

809 810
TEST_F(WasmModuleVerifyTest, DataWithoutMemory) {
  const byte data[] = {
811 812 813 814
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_I32V_3(0x9BBAA),  // dest addr
              U32V_1(3),                       // source size
              'a', 'b', 'c')                   // data bytes
815 816 817 818
  };
  EXPECT_FAILURE(data);
}

819 820 821
TEST_F(WasmModuleVerifyTest, MaxMaximumMemorySize) {
  {
    const byte data[] = {
822
        SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 0, U32V_3(65536))};
823 824 825 826
    EXPECT_VERIFIES(data);
  }
  {
    const byte data[] = {
827
        SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 0, U32V_3(65537))};
828 829 830 831
    EXPECT_FAILURE(data);
  }
}

832 833
TEST_F(WasmModuleVerifyTest, DataSegment_wrong_init_type) {
  const byte data[] = {
834 835 836 837 838
      SECTION(Memory, ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,
              WASM_INIT_EXPR_F64(9.9),  // dest addr
              U32V_1(3),                // source size
              'a', 'b', 'c')            // data bytes
839 840 841
  };

  EXPECT_FAILURE(data);
842 843
}

844 845
TEST_F(WasmModuleVerifyTest, DataSegmentEndOverflow) {
  const byte data[] = {
846 847 848 849 850 851 852
      SECTION(Memory,  // memory section
              ENTRY_COUNT(1), kHasMaximumFlag, 28, 28),
      SECTION(Data,                      // data section
              ENTRY_COUNT(1),            // one entry
              LINEAR_MEMORY_INDEX_0,     // mem index
              WASM_INIT_EXPR_I32V_1(0),  // offset
              U32V_5(0xFFFFFFFF))        // size
853 854 855 856 857
  };

  EXPECT_FAILURE(data);
}

858
TEST_F(WasmModuleVerifyTest, OneIndirectFunction) {
859
  static const byte data[] = {
860
      // sig#0 ---------------------------------------------------------------
861
      SIGNATURES_SECTION_VOID_VOID,
862
      // funcs ---------------------------------------------------------------
863
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
864
      // table declaration ---------------------------------------------------
865 866 867
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 1),
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
868

869 870 871
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);
  if (result.ok()) {
872 873 874 875
    EXPECT_EQ(1u, result.value()->signatures.size());
    EXPECT_EQ(1u, result.value()->functions.size());
    EXPECT_EQ(1u, result.value()->tables.size());
    EXPECT_EQ(1u, result.value()->tables[0].initial_size);
876 877 878
  }
}

879 880 881
TEST_F(WasmModuleVerifyTest, ElementSectionWithInternalTable) {
  static const byte data[] = {
      // table ---------------------------------------------------------------
882
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 1),
883
      // elements ------------------------------------------------------------
884
      SECTION(Element, ENTRY_COUNT(0))};
885 886 887 888 889 890 891

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionWithImportedTable) {
  static const byte data[] = {
      // imports -------------------------------------------------------------
892
      SECTION(Import, ENTRY_COUNT(1),
893 894
              ADD_COUNT('m'),  // module name
              ADD_COUNT('t'),  // table name
895 896 897 898
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              1),              // initial size
899
      // elements ------------------------------------------------------------
900
      SECTION(Element, ENTRY_COUNT(0))};
901 902 903 904 905 906 907 908

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionWithoutTable) {
  // Test that an element section without a table causes a validation error.
  static const byte data[] = {
      // elements ------------------------------------------------------------
909 910 911 912 913
      SECTION(Element,
              ENTRY_COUNT(1),  // entry count
              0,               // table index
              0,               // offset
              0)               // number of elements
914 915 916 917 918
  };

  EXPECT_FAILURE(data);
}

919 920 921 922 923 924
TEST_F(WasmModuleVerifyTest, Regression_735887) {
  // Test with an invalid function index in the element section.
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs ---------------------------------------------------------------
925
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
926
      // table declaration ---------------------------------------------------
927
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 1),
928
      // elements ------------------------------------------------------------
929 930
      SECTION(Element,
              ENTRY_COUNT(1),  // entry count
931
              TABLE_INDEX0, WASM_INIT_EXPR_I32V_1(0),
932 933
              1,     // elements count
              0x9A)  // invalid I32V as function index
934 935 936 937 938
  };

  EXPECT_FAILURE(data);
}

939 940 941 942 943
TEST_F(WasmModuleVerifyTest, OneIndirectFunction_one_entry) {
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs ---------------------------------------------------------------
944
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
945
      // table declaration ---------------------------------------------------
946
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 1),
947
      // elements ------------------------------------------------------------
948 949
      SECTION(Element,
              ENTRY_COUNT(1),  // entry count
950
              TABLE_INDEX0, WASM_INIT_EXPR_I32V_1(0),
951
              1,  // elements count
952 953 954
              FUNC_INDEX(0)),
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
955 956

  ModuleResult result = DecodeModule(data, data + sizeof(data));
957
  EXPECT_OK(result);
958 959 960 961
  EXPECT_EQ(1u, result.value()->signatures.size());
  EXPECT_EQ(1u, result.value()->functions.size());
  EXPECT_EQ(1u, result.value()->tables.size());
  EXPECT_EQ(1u, result.value()->tables[0].initial_size);
962 963 964 965 966
}

TEST_F(WasmModuleVerifyTest, MultipleIndirectFunctions) {
  static const byte data[] = {
      // sig#0 -------------------------------------------------------
967 968 969 970
      SECTION(Type,
              ENTRY_COUNT(2),             // --
              SIG_ENTRY_v_v,              // void -> void
              SIG_ENTRY_v_x(kLocalI32)),  // void -> i32
971
      // funcs ------------------------------------------------------
972
      FOUR_EMPTY_FUNCTIONS(SIG_INDEX(0)),
973
      // table declaration -------------------------------------------
974
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 8),
975
      // table elements ----------------------------------------------
976 977
      SECTION(Element,
              ENTRY_COUNT(1),  // entry count
978
              TABLE_INDEX0, WASM_INIT_EXPR_I32V_1(0),
979 980 981
              ADD_COUNT(FUNC_INDEX(0), FUNC_INDEX(1), FUNC_INDEX(2),
                        FUNC_INDEX(3), FUNC_INDEX(0), FUNC_INDEX(1),
                        FUNC_INDEX(2), FUNC_INDEX(3))),
982
      FOUR_EMPTY_BODIES};
983

984
  ModuleResult result = DecodeModule(data, data + sizeof(data));
985
  EXPECT_OK(result);
986 987 988 989
  EXPECT_EQ(2u, result.value()->signatures.size());
  EXPECT_EQ(4u, result.value()->functions.size());
  EXPECT_EQ(1u, result.value()->tables.size());
  EXPECT_EQ(8u, result.value()->tables[0].initial_size);
990 991
}

992 993 994
TEST_F(WasmModuleVerifyTest, ElementSectionMultipleTables) {
  // Test that if we have multiple tables, in the element section we can target
  // and initialize all tables.
995
  WASM_FEATURE_SCOPE(anyref);
996
  WASM_FEATURE_SCOPE(bulk_memory);
997 998 999 1000
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs ---------------------------------------------------------------
1001
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1002
      // table declaration ---------------------------------------------------
1003 1004 1005
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyFunc, 0, 5,    // table 0
              kLocalAnyFunc, 0, 9),   // table 1
1006
      // elements ------------------------------------------------------------
1007 1008
      SECTION(Element,
              ENTRY_COUNT(2),            // entry count
1009
              TABLE_INDEX0,              // element for table 0
1010 1011 1012 1013 1014 1015 1016 1017
              WASM_INIT_EXPR_I32V_1(0),  // index
              1,                         // elements count
              FUNC_INDEX(0),             // function
              TABLE_INDEX(1),            // element for table 1
              WASM_INIT_EXPR_I32V_1(7),  // index
              2,                         // elements count
              FUNC_INDEX(0),             // entry 0
              FUNC_INDEX(0)),            // entry 1
1018 1019
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
1020 1021 1022 1023 1024 1025 1026

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionMixedTables) {
  // Test that if we have multiple tables, both imported and module-defined, in
  // the element section we can target and initialize all tables.
1027
  WASM_FEATURE_SCOPE(anyref);
1028
  WASM_FEATURE_SCOPE(bulk_memory);
1029 1030 1031 1032
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // imports -------------------------------------------------------------
1033
      SECTION(Import, ENTRY_COUNT(2),
1034 1035
              ADD_COUNT('m'),  // module name
              ADD_COUNT('t'),  // table name
1036 1037 1038 1039
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              5,               // initial size
1040 1041
              ADD_COUNT('m'),  // module name
              ADD_COUNT('s'),  // table name
1042 1043 1044 1045
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              10),             // initial size
1046
      // funcs ---------------------------------------------------------------
1047
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1048
      // table declaration ---------------------------------------------------
1049 1050 1051
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyFunc, 0, 15,   // table 0
              kLocalAnyFunc, 0, 19),  // table 1
1052
      // elements ------------------------------------------------------------
1053 1054
      SECTION(Element,
              4,                          // entry count
1055
              TABLE_INDEX0,               // element for table 0
1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072
              WASM_INIT_EXPR_I32V_1(0),   // index
              1,                          // elements count
              FUNC_INDEX(0),              // function
              TABLE_INDEX(1),             // element for table 1
              WASM_INIT_EXPR_I32V_1(7),   // index
              2,                          // elements count
              FUNC_INDEX(0),              // entry 0
              FUNC_INDEX(0),              // entry 1
              TABLE_INDEX(2),             // element for table 2
              WASM_INIT_EXPR_I32V_1(12),  // index
              1,                          // elements count
              FUNC_INDEX(0),              // function
              TABLE_INDEX(3),             // element for table 1
              WASM_INIT_EXPR_I32V_1(17),  // index
              2,                          // elements count
              FUNC_INDEX(0),              // entry 0
              FUNC_INDEX(0)),             // entry 1
1073 1074
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
1075 1076 1077 1078 1079 1080 1081

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionMultipleTablesArbitraryOrder) {
  // Test that the order in which tables are targeted in the element secion
  // can be arbitrary.
1082
  WASM_FEATURE_SCOPE(anyref);
1083
  WASM_FEATURE_SCOPE(bulk_memory);
1084 1085 1086 1087
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs ---------------------------------------------------------------
1088
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1089
      // table declaration ---------------------------------------------------
1090 1091 1092
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyFunc, 0, 5,    // table 0
              kLocalAnyFunc, 0, 9),   // table 1
1093
      // elements ------------------------------------------------------------
1094 1095
      SECTION(Element,
              ENTRY_COUNT(3),            // entry count
1096
              TABLE_INDEX0,              // element for table 1
1097 1098 1099 1100 1101 1102 1103 1104
              WASM_INIT_EXPR_I32V_1(0),  // index
              1,                         // elements count
              FUNC_INDEX(0),             // function
              TABLE_INDEX(1),            // element for table 0
              WASM_INIT_EXPR_I32V_1(7),  // index
              2,                         // elements count
              FUNC_INDEX(0),             // entry 0
              FUNC_INDEX(0),             // entry 1
1105
              TABLE_INDEX0,              // element for table 1
1106 1107 1108
              WASM_INIT_EXPR_I32V_1(3),  // index
              1,                         // elements count
              FUNC_INDEX(0)),            // function
1109 1110
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
1111 1112 1113 1114 1115 1116 1117

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionMixedTablesArbitraryOrder) {
  // Test that the order in which tables are targeted in the element secion can
  // be arbitrary. In this test, tables can be both imported and module-defined.
1118
  WASM_FEATURE_SCOPE(anyref);
1119
  WASM_FEATURE_SCOPE(bulk_memory);
1120 1121 1122 1123
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // imports -------------------------------------------------------------
1124
      SECTION(Import, ENTRY_COUNT(2),
1125 1126
              ADD_COUNT('m'),  // module name
              ADD_COUNT('t'),  // table name
1127 1128 1129 1130
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              5,               // initial size
1131 1132
              ADD_COUNT('m'),  // module name
              ADD_COUNT('s'),  // table name
1133 1134 1135 1136
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              10),             // initial size
1137
      // funcs ---------------------------------------------------------------
1138
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1139
      // table declaration ---------------------------------------------------
1140 1141 1142
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyFunc, 0, 15,   // table 0
              kLocalAnyFunc, 0, 19),  // table 1
1143
      // elements ------------------------------------------------------------
1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
      SECTION(Element,
              4,                          // entry count
              TABLE_INDEX(2),             // element for table 0
              WASM_INIT_EXPR_I32V_1(10),  // index
              1,                          // elements count
              FUNC_INDEX(0),              // function
              TABLE_INDEX(3),             // element for table 1
              WASM_INIT_EXPR_I32V_1(17),  // index
              2,                          // elements count
              FUNC_INDEX(0),              // entry 0
              FUNC_INDEX(0),              // entry 1
1155
              TABLE_INDEX0,               // element for table 2
1156 1157 1158 1159 1160 1161 1162 1163
              WASM_INIT_EXPR_I32V_1(2),   // index
              1,                          // elements count
              FUNC_INDEX(0),              // function
              TABLE_INDEX(1),             // element for table 1
              WASM_INIT_EXPR_I32V_1(7),   // index
              2,                          // elements count
              FUNC_INDEX(0),              // entry 0
              FUNC_INDEX(0)),             // entry 1
1164 1165
      // code ----------------------------------------------------------------
      ONE_EMPTY_BODY};
1166 1167 1168 1169 1170 1171 1172

  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionDontInitAnyRefTable) {
  // Test that tables of type 'AnyRef' cannot be initialized by the element
  // section.
1173
  WASM_FEATURE_SCOPE(anyref);
1174
  WASM_FEATURE_SCOPE(bulk_memory);
1175 1176 1177 1178
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs ---------------------------------------------------------------
1179
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1180
      // table declaration ---------------------------------------------------
1181 1182 1183
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyRef, 0, 5,     // table 0
              kLocalAnyFunc, 0, 9),   // table 1
1184
      // elements ------------------------------------------------------------
1185 1186
      SECTION(Element,
              ENTRY_COUNT(2),            // entry count
1187
              TABLE_INDEX0,              // element for table 0
1188 1189 1190 1191 1192 1193 1194 1195
              WASM_INIT_EXPR_I32V_1(0),  // index
              1,                         // elements count
              FUNC_INDEX(0),             // function
              TABLE_INDEX(1),            // element for table 1
              WASM_INIT_EXPR_I32V_1(7),  // index
              2,                         // elements count
              FUNC_INDEX(0),             // entry 0
              FUNC_INDEX(0)),            // entry 1
1196 1197 1198 1199 1200 1201 1202 1203
  };

  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, ElementSectionDontInitAnyRefImportedTable) {
  // Test that imported tables of type AnyRef cannot be initialized in the
  // elements section.
1204
  WASM_FEATURE_SCOPE(anyref);
1205
  WASM_FEATURE_SCOPE(bulk_memory);
1206 1207 1208 1209
  static const byte data[] = {
      // sig#0 ---------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // imports -------------------------------------------------------------
1210
      SECTION(Import, ENTRY_COUNT(2),
1211 1212
              ADD_COUNT('m'),  // module name
              ADD_COUNT('t'),  // table name
1213 1214 1215 1216
              kExternalTable,  // import kind
              kLocalAnyFunc,   // elem_type
              0,               // no maximum field
              5,               // initial size
1217 1218
              ADD_COUNT('m'),  // module name
              ADD_COUNT('s'),  // table name
1219 1220 1221 1222
              kExternalTable,  // import kind
              kLocalAnyRef,    // elem_type
              0,               // no maximum field
              10),             // initial size
1223
      // funcs ---------------------------------------------------------------
1224
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1225
      // table declaration ---------------------------------------------------
1226 1227 1228
      SECTION(Table, ENTRY_COUNT(2),  // section header
              kLocalAnyFunc, 0, 15,   // table 0
              kLocalAnyFunc, 0, 19),  // table 1
1229
      // elements ------------------------------------------------------------
1230 1231
      SECTION(Element,
              ENTRY_COUNT(4),             // entry count
1232
              TABLE_INDEX0,               // element for table 0
1233 1234 1235 1236 1237 1238 1239 1240
              WASM_INIT_EXPR_I32V_1(10),  // index
              1,                          // elements count
              FUNC_INDEX(0),              // function
              TABLE_INDEX(1),             // element for table 1
              WASM_INIT_EXPR_I32V_1(17),  // index
              2,                          // elements count
              FUNC_INDEX(0),              // entry 0
              FUNC_INDEX(0)),             // entry 1
1241 1242 1243 1244 1245
  };

  EXPECT_FAILURE(data);
}

1246 1247 1248
TEST_F(WasmModuleVerifyTest, IndirectFunctionNoFunctions) {
  static const byte data[] = {
      // sig#0 -------------------------------------------------------
1249
      SIGNATURES_SECTION_VOID_VOID,
1250
      // indirect table ----------------------------------------------
1251
      SECTION(Table, ENTRY_COUNT(1), 1, 0, 0)};
1252 1253 1254 1255 1256 1257 1258

  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, IndirectFunctionInvalidIndex) {
  static const byte data[] = {
      // sig#0 -------------------------------------------------------
1259
      SIGNATURES_SECTION_VOID_VOID,
1260
      // functions ---------------------------------------------------
1261
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1262
      // indirect table ----------------------------------------------
1263
      SECTION(Table, ENTRY_COUNT(1), 1, 1, 0)};
1264 1265 1266 1267

  EXPECT_FAILURE(data);
}

1268 1269
TEST_F(WasmModuleVerifyTest, MultipleTablesWithoutFlag) {
  static const byte data[] = {
1270 1271 1272 1273 1274 1275 1276 1277
      SECTION(Table,           // table section
              ENTRY_COUNT(2),  // 2 tables
              kLocalAnyFunc,   // table 1: type
              0,               // table 1: no maximum
              10,              // table 1: minimum size
              kLocalAnyFunc,   // table 2: type
              0,               // table 2: no maximum
              10),             // table 2: minimum size
1278 1279 1280 1281 1282
  };
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, MultipleTablesWithFlag) {
1283
  WASM_FEATURE_SCOPE(anyref);
1284
  static const byte data[] = {
1285 1286 1287 1288 1289 1290 1291 1292
      SECTION(Table,           // table section
              ENTRY_COUNT(2),  // 2 tables
              kLocalAnyFunc,   // table 1: type
              0,               // table 1: no maximum
              10,              // table 1: minimum size
              kLocalAnyRef,    // table 2: type
              0,               // table 2: no maximum
              11),             // table 2: minimum size
1293 1294 1295 1296 1297
  };

  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_OK(result);

1298
  EXPECT_EQ(2u, result.value()->tables.size());
1299

1300 1301
  EXPECT_EQ(10u, result.value()->tables[0].initial_size);
  EXPECT_EQ(kWasmAnyFunc, result.value()->tables[0].type);
1302

1303 1304
  EXPECT_EQ(11u, result.value()->tables[1].initial_size);
  EXPECT_EQ(kWasmAnyRef, result.value()->tables[1].type);
1305 1306
}

1307 1308
class WasmSignatureDecodeTest : public TestWithZone {
 public:
1309 1310 1311 1312 1313
  WasmFeatures enabled_features_;

  FunctionSig* DecodeSig(const byte* start, const byte* end) {
    return DecodeWasmSignatureForTesting(enabled_features_, zone(), start, end);
  }
1314
};
1315 1316

TEST_F(WasmSignatureDecodeTest, Ok_v_v) {
1317
  static const byte data[] = {SIG_ENTRY_v_v};
1318
  v8::internal::AccountingAllocator allocator;
1319
  Zone zone(&allocator, ZONE_NAME);
1320
  FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1321 1322

  EXPECT_TRUE(sig != nullptr);
1323 1324
  EXPECT_EQ(0u, sig->parameter_count());
  EXPECT_EQ(0u, sig->return_count());
1325 1326 1327
}

TEST_F(WasmSignatureDecodeTest, Ok_t_v) {
1328
  WASM_FEATURE_SCOPE(anyref);
1329 1330
  for (size_t i = 0; i < arraysize(kValueTypes); i++) {
    ValueTypePair ret_type = kValueTypes[i];
1331
    const byte data[] = {SIG_ENTRY_x(ret_type.code)};
1332
    FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1333 1334

    EXPECT_TRUE(sig != nullptr);
1335 1336
    EXPECT_EQ(0u, sig->parameter_count());
    EXPECT_EQ(1u, sig->return_count());
1337 1338 1339 1340 1341
    EXPECT_EQ(ret_type.type, sig->GetReturn());
  }
}

TEST_F(WasmSignatureDecodeTest, Ok_v_t) {
1342
  WASM_FEATURE_SCOPE(anyref);
1343 1344
  for (size_t i = 0; i < arraysize(kValueTypes); i++) {
    ValueTypePair param_type = kValueTypes[i];
1345
    const byte data[] = {SIG_ENTRY_v_x(param_type.code)};
1346
    FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1347 1348

    EXPECT_TRUE(sig != nullptr);
1349 1350
    EXPECT_EQ(1u, sig->parameter_count());
    EXPECT_EQ(0u, sig->return_count());
1351 1352 1353 1354 1355
    EXPECT_EQ(param_type.type, sig->GetParam(0));
  }
}

TEST_F(WasmSignatureDecodeTest, Ok_t_t) {
1356
  WASM_FEATURE_SCOPE(anyref);
1357 1358 1359 1360
  for (size_t i = 0; i < arraysize(kValueTypes); i++) {
    ValueTypePair ret_type = kValueTypes[i];
    for (size_t j = 0; j < arraysize(kValueTypes); j++) {
      ValueTypePair param_type = kValueTypes[j];
1361
      const byte data[] = {SIG_ENTRY_x_x(ret_type.code, param_type.code)};
1362
      FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1363 1364

      EXPECT_TRUE(sig != nullptr);
1365 1366
      EXPECT_EQ(1u, sig->parameter_count());
      EXPECT_EQ(1u, sig->return_count());
1367 1368 1369 1370 1371 1372 1373
      EXPECT_EQ(param_type.type, sig->GetParam(0));
      EXPECT_EQ(ret_type.type, sig->GetReturn());
    }
  }
}

TEST_F(WasmSignatureDecodeTest, Ok_i_tt) {
1374 1375
  WASM_FEATURE_SCOPE(anyref);
  WASM_FEATURE_SCOPE(mv);
1376 1377 1378 1379
  for (size_t i = 0; i < arraysize(kValueTypes); i++) {
    ValueTypePair p0_type = kValueTypes[i];
    for (size_t j = 0; j < arraysize(kValueTypes); j++) {
      ValueTypePair p1_type = kValueTypes[j];
1380 1381
      const byte data[] = {
          SIG_ENTRY_x_xx(kLocalI32, p0_type.code, p1_type.code)};
1382
      FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1383 1384

      EXPECT_TRUE(sig != nullptr);
1385 1386
      EXPECT_EQ(2u, sig->parameter_count());
      EXPECT_EQ(1u, sig->return_count());
1387 1388 1389 1390 1391 1392
      EXPECT_EQ(p0_type.type, sig->GetParam(0));
      EXPECT_EQ(p1_type.type, sig->GetParam(1));
    }
  }
}

1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414
TEST_F(WasmSignatureDecodeTest, Ok_tt_tt) {
  WASM_FEATURE_SCOPE(anyref);
  WASM_FEATURE_SCOPE(mv);
  for (size_t i = 0; i < arraysize(kValueTypes); i++) {
    ValueTypePair p0_type = kValueTypes[i];
    for (size_t j = 0; j < arraysize(kValueTypes); j++) {
      ValueTypePair p1_type = kValueTypes[j];
      const byte data[] = {SIG_ENTRY_xx_xx(p0_type.code, p1_type.code,
                                           p0_type.code, p1_type.code)};
      FunctionSig* sig = DecodeSig(data, data + sizeof(data));

      EXPECT_TRUE(sig != nullptr);
      EXPECT_EQ(2u, sig->parameter_count());
      EXPECT_EQ(2u, sig->return_count());
      EXPECT_EQ(p0_type.type, sig->GetParam(0));
      EXPECT_EQ(p1_type.type, sig->GetParam(1));
      EXPECT_EQ(p0_type.type, sig->GetReturn(0));
      EXPECT_EQ(p1_type.type, sig->GetReturn(1));
    }
  }
}

1415
TEST_F(WasmSignatureDecodeTest, TooManyParams) {
1416
  static const byte data[] = {kWasmFunctionTypeCode,
1417 1418
                              WASM_I32V_3(kV8MaxWasmFunctionParams + 1),
                              kLocalI32, 0};
1419
  FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1420 1421 1422 1423 1424
  EXPECT_FALSE(sig != nullptr);
}

TEST_F(WasmSignatureDecodeTest, TooManyReturns) {
  for (int i = 0; i < 2; i++) {
1425 1426
    bool enable_mv = i != 0;
    WASM_FEATURE_SCOPE_VAL(mv, enable_mv);
1427
    const int max_return_count = static_cast<int>(
1428
        enable_mv ? kV8MaxWasmFunctionMultiReturns : kV8MaxWasmFunctionReturns);
1429
    byte data[] = {kWasmFunctionTypeCode, 0, WASM_I32V_3(max_return_count + 1),
1430
                   kLocalI32};
1431
    FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1432 1433 1434 1435
    EXPECT_EQ(nullptr, sig);
  }
}

1436 1437 1438 1439 1440 1441 1442 1443
TEST_F(WasmSignatureDecodeTest, Fail_off_end) {
  byte data[256];
  for (int p = 0; p <= 255; p = p + 1 + p * 3) {
    for (int i = 0; i <= p; i++) data[i] = kLocalI32;
    data[0] = static_cast<byte>(p);

    for (int i = 0; i < p + 1; i++) {
      // Should fall off the end for all signatures.
1444
      FunctionSig* sig = DecodeSig(data, data + i);
1445 1446 1447 1448 1449
      EXPECT_EQ(nullptr, sig);
    }
  }
}

1450 1451
TEST_F(WasmSignatureDecodeTest, Fail_anyref_without_flag) {
  // Disable AnyRef support and check that decoding fails.
1452
  WASM_FEATURE_SCOPE_VAL(anyref, false);
1453 1454
  byte ref_types[] = {kLocalAnyFunc, kLocalAnyRef};
  for (byte invalid_type : ref_types) {
1455
    for (size_t i = 0;; i++) {
1456
      byte data[] = {SIG_ENTRY_x_xx(kLocalI32, kLocalI32, kLocalI32)};
1457
      if (i >= arraysize(data)) break;
1458
      data[i] = invalid_type;
1459
      FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1460 1461
      EXPECT_EQ(nullptr, sig);
    }
1462 1463 1464
  }
}

1465 1466
TEST_F(WasmSignatureDecodeTest, Fail_invalid_type) {
  byte kInvalidType = 76;
1467
  for (size_t i = 0;; i++) {
1468
    byte data[] = {SIG_ENTRY_x_xx(kLocalI32, kLocalI32, kLocalI32)};
1469
    if (i >= arraysize(data)) break;
1470
    data[i] = kInvalidType;
1471
    FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1472 1473 1474 1475
    EXPECT_EQ(nullptr, sig);
  }
}

1476 1477
TEST_F(WasmSignatureDecodeTest, Fail_invalid_ret_type1) {
  static const byte data[] = {SIG_ENTRY_x_x(kLocalVoid, kLocalI32)};
1478
  FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1479 1480
  EXPECT_EQ(nullptr, sig);
}
1481

1482 1483
TEST_F(WasmSignatureDecodeTest, Fail_invalid_param_type1) {
  static const byte data[] = {SIG_ENTRY_x_x(kLocalI32, kLocalVoid)};
1484
  FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1485 1486 1487 1488 1489
  EXPECT_EQ(nullptr, sig);
}

TEST_F(WasmSignatureDecodeTest, Fail_invalid_param_type2) {
  static const byte data[] = {SIG_ENTRY_x_xx(kLocalI32, kLocalI32, kLocalVoid)};
1490
  FunctionSig* sig = DecodeSig(data, data + sizeof(data));
1491
  EXPECT_EQ(nullptr, sig);
1492 1493
}

1494 1495
class WasmFunctionVerifyTest : public TestWithIsolateAndZone {
 public:
1496 1497 1498 1499
  FunctionResult DecodeWasmFunction(const ModuleWireBytes& wire_bytes,
                                    const WasmModule* module,
                                    const byte* function_start,
                                    const byte* function_end) {
1500 1501
    WasmFeatures enabled_features;
    return DecodeWasmFunctionForTesting(enabled_features, zone(), wire_bytes,
1502 1503 1504
                                        module, function_start, function_end,
                                        isolate()->counters());
  }
1505
};
1506 1507

TEST_F(WasmFunctionVerifyTest, Ok_v_v_empty) {
1508
  static const byte data[] = {
1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
      SIG_ENTRY_v_v,  // signature entry
      4,              // locals
      3,
      kLocalI32,  // --
      4,
      kLocalI64,  // --
      5,
      kLocalF32,  // --
      6,
      kLocalF64,  // --
1519
      kExprEnd    // body
1520 1521
  };

1522 1523 1524
  WasmModule module;
  FunctionResult result = DecodeWasmFunction(ModuleWireBytes({}), &module, data,
                                             data + sizeof(data));
1525
  EXPECT_OK(result);
1526

1527 1528
  if (result.value() && result.ok()) {
    WasmFunction* function = result.value().get();
1529 1530
    EXPECT_EQ(0u, function->sig->parameter_count());
    EXPECT_EQ(0u, function->sig->return_count());
1531
    EXPECT_EQ(COUNT_ARGS(SIG_ENTRY_v_v), function->code.offset());
1532
    EXPECT_EQ(sizeof(data), function->code.end_offset());
1533
    // TODO(titzer): verify encoding of local declarations
1534 1535
  }
}
1536

1537 1538 1539 1540 1541 1542
TEST_F(WasmModuleVerifyTest, SectionWithoutNameLength) {
  const byte data[] = {1};
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, TheLoneliestOfValidModulesTheTrulyEmptyOne) {
1543
  const byte data[] = {
1544
      0,  // unknown section code.
1545 1546
      0,  // Empty section name.
          // No section name, no content, nothing but sadness.
1547
      0,  // No section content.
1548
  };
1549
  EXPECT_VERIFIES(data);
1550 1551
}

1552 1553
TEST_F(WasmModuleVerifyTest, OnlyUnknownSectionEmpty) {
  const byte data[] = {
1554
      UNKNOWN_SECTION(0),
1555 1556
  };
  EXPECT_VERIFIES(data);
1557 1558
}

1559 1560
TEST_F(WasmModuleVerifyTest, OnlyUnknownSectionNonEmpty) {
  const byte data[] = {
1561
      UNKNOWN_SECTION(5),
1562 1563 1564 1565 1566
      0xFF,
      0xFF,
      0xFF,
      0xFF,
      0xFF,  // section data
1567
  };
1568
  EXPECT_VERIFIES(data);
1569 1570
}

1571 1572
TEST_F(WasmModuleVerifyTest, SignatureFollowedByEmptyUnknownSection) {
  const byte data[] = {
1573 1574
      // signatures
      SIGNATURES_SECTION_VOID_VOID,
1575
      // -----------------------------------------------------------
1576
      UNKNOWN_SECTION(0)};
1577 1578 1579 1580 1581
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, SignatureFollowedByUnknownSection) {
  const byte data[] = {
1582 1583
      // signatures
      SIGNATURES_SECTION_VOID_VOID,
1584
      // -----------------------------------------------------------
1585
      UNKNOWN_SECTION(5), 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
1586 1587
  };
  EXPECT_VERIFIES(data);
1588 1589
}

1590
TEST_F(WasmModuleVerifyTest, UnknownSectionOverflow) {
1591
  static const byte data[] = {
1592
      UNKNOWN_SECTION(9),
1593 1594 1595 1596 1597 1598 1599 1600 1601 1602
      1,
      2,
      3,
      4,
      5,
      6,
      7,
      8,
      9,
      10,  // 10 byte section
1603 1604 1605 1606
  };
  EXPECT_FAILURE(data);
}

1607
TEST_F(WasmModuleVerifyTest, UnknownSectionUnderflow) {
1608
  static const byte data[] = {
1609
      UNKNOWN_SECTION(333),
1610 1611 1612 1613
      1,
      2,
      3,
      4,  // 4 byte section
1614 1615 1616 1617
  };
  EXPECT_FAILURE(data);
}

1618 1619
TEST_F(WasmModuleVerifyTest, UnknownSectionSkipped) {
  static const byte data[] = {
1620
      UNKNOWN_SECTION(1),
1621
      0,  // one byte section
1622 1623 1624 1625
      SECTION(Global, ENTRY_COUNT(1),
              kLocalI32,                   // memory type
              0,                           // exported
              WASM_INIT_EXPR_I32V_1(33)),  // init
1626
  };
1627
  ModuleResult result = DecodeModule(data, data + sizeof(data));
1628
  EXPECT_OK(result);
1629

1630 1631 1632
  EXPECT_EQ(1u, result.value()->globals.size());
  EXPECT_EQ(0u, result.value()->functions.size());
  EXPECT_EQ(0u, result.value()->data_segments.size());
1633

1634
  const WasmGlobal* global = &result.value()->globals.back();
1635

1636
  EXPECT_EQ(kWasmI32, global->type);
1637
  EXPECT_EQ(0u, global->offset);
1638 1639
}

1640
TEST_F(WasmModuleVerifyTest, ImportTable_empty) {
1641 1642
  static const byte data[] = {SECTION(Type, ENTRY_COUNT(0)),
                              SECTION(Import, ENTRY_COUNT(0))};
1643 1644 1645
  EXPECT_VERIFIES(data);
}

1646
TEST_F(WasmModuleVerifyTest, ImportTable_nosigs1) {
1647
  static const byte data[] = {SECTION(Import, ENTRY_COUNT(0))};
1648 1649 1650
  EXPECT_VERIFIES(data);
}

1651 1652 1653
TEST_F(WasmModuleVerifyTest, ImportTable_mutable_global) {
  {
    static const byte data[] = {
1654 1655
        SECTION(Import,           // section header
                ENTRY_COUNT(1),   // number of imports
1656 1657
                ADD_COUNT('m'),   // module name
                ADD_COUNT('f'),   // global name
1658 1659 1660
                kExternalGlobal,  // import kind
                kLocalI32,        // type
                0),               // mutability
1661 1662 1663 1664 1665
    };
    EXPECT_VERIFIES(data);
  }
  {
    static const byte data[] = {
1666 1667
        SECTION(Import,           // section header
                ENTRY_COUNT(1),   // sig table
1668 1669
                ADD_COUNT('m'),   // module name
                ADD_COUNT('f'),   // global name
1670 1671 1672
                kExternalGlobal,  // import kind
                kLocalI32,        // type
                1),               // mutability
1673
    };
1674
    EXPECT_VERIFIES(data);
1675 1676 1677
  }
}

1678 1679
TEST_F(WasmModuleVerifyTest, ImportTable_mutability_malformed) {
  static const byte data[] = {
1680 1681
      SECTION(Import,
              ENTRY_COUNT(1),   // --
1682 1683
              ADD_COUNT('m'),   // module name
              ADD_COUNT('g'),   // global name
1684 1685 1686
              kExternalGlobal,  // import kind
              kLocalI32,        // type
              2),               // invalid mutability
1687 1688 1689 1690
  };
  EXPECT_FAILURE(data);
}

1691 1692
TEST_F(WasmModuleVerifyTest, ImportTable_nosigs2) {
  static const byte data[] = {
1693
      SECTION(Import, ENTRY_COUNT(1),  // sig table
1694 1695
              ADD_COUNT('m'),          // module name
              ADD_COUNT('f'),          // function name
1696 1697
              kExternalFunction,       // import kind
              SIG_INDEX(0)),           // sig index
1698
  };
1699 1700 1701 1702 1703
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, ImportTable_invalid_sig) {
  static const byte data[] = {
1704 1705
      SECTION(Type, ENTRY_COUNT(0)),   // --
      SECTION(Import, ENTRY_COUNT(1),  // --
1706 1707
              ADD_COUNT('m'),          // module name
              ADD_COUNT('f'),          // function name
1708 1709
              kExternalFunction,       // import kind
              SIG_INDEX(0)),           // sig index
1710 1711 1712 1713 1714 1715
  };
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, ImportTable_one_sig) {
  static const byte data[] = {
1716 1717
      // signatures
      SIGNATURES_SECTION_VOID_VOID,
1718
      SECTION(Import,
1719 1720 1721
              ENTRY_COUNT(1),     // --
              ADD_COUNT('m'),     // module name
              ADD_COUNT('f'),     // function name
1722 1723
              kExternalFunction,  // import kind
              SIG_INDEX(0)),      // sig index
1724 1725 1726 1727
  };
  EXPECT_VERIFIES(data);
}

1728 1729
TEST_F(WasmModuleVerifyTest, ImportTable_invalid_module) {
  static const byte data[] = {
1730
      // signatures
1731
      SIGNATURES_SECTION_VOID_VOID,  // --
1732 1733 1734
      SECTION(Import,                // --
              ENTRY_COUNT(1),        // --
              NO_NAME,               // module name
1735
              ADD_COUNT('f'),        // function name
1736 1737 1738
              kExternalFunction,     // import kind
              SIG_INDEX(0),          // sig index
              0),                    // auxiliary data
1739 1740 1741 1742
  };
  EXPECT_FAILURE(data);
}

1743 1744
TEST_F(WasmModuleVerifyTest, ImportTable_off_end) {
  static const byte data[] = {
1745 1746
      // signatures
      SIGNATURES_SECTION_VOID_VOID,
1747 1748 1749
      SECTION(Import, ENTRY_COUNT(1),
              ADD_COUNT('m'),      // module name
              ADD_COUNT('f'),      // function name
1750 1751
              kExternalFunction),  // import kind
      SIG_INDEX(0),                // sig index (outside import section!)
1752 1753
  };

1754
  EXPECT_OFF_END_FAILURE(data, arraysize(data) - 3);
1755 1756
}

1757
TEST_F(WasmModuleVerifyTest, ExportTable_empty1) {
1758 1759
  static const byte data[] = {                               // signatures
                              SIGNATURES_SECTION_VOID_VOID,  // --
1760
                              ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
1761
                              SECTION(Export, ENTRY_COUNT(0)),  // --
1762 1763
                              ONE_EMPTY_BODY};

1764
  ModuleResult result = DecodeModule(data, data + sizeof(data));
1765 1766
  EXPECT_OK(result);

1767 1768
  EXPECT_EQ(1u, result.value()->functions.size());
  EXPECT_EQ(0u, result.value()->export_table.size());
titzer's avatar
titzer committed
1769 1770
}

1771
TEST_F(WasmModuleVerifyTest, ExportTable_empty2) {
1772 1773
  static const byte data[] = {SECTION(Type, ENTRY_COUNT(0)),
                              SECTION(Export, ENTRY_COUNT(0))};
1774
  EXPECT_VERIFIES(data);
titzer's avatar
titzer committed
1775 1776 1777
}

TEST_F(WasmModuleVerifyTest, ExportTable_NoFunctions2) {
1778
  static const byte data[] = {SECTION(Export, ENTRY_COUNT(0))};
1779
  EXPECT_VERIFIES(data);
titzer's avatar
titzer committed
1780 1781 1782
}

TEST_F(WasmModuleVerifyTest, ExportTableOne) {
1783 1784 1785 1786 1787 1788 1789 1790 1791
  static const byte data[] = {
      // signatures
      SIGNATURES_SECTION_VOID_VOID, ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
      SECTION(Export,
              ENTRY_COUNT(1),     // exports
              NO_NAME,            // --
              kExternalFunction,  // --
              FUNC_INDEX(0)),     // --
      ONE_EMPTY_BODY};
1792
  ModuleResult result = DecodeModule(data, data + sizeof(data));
1793 1794
  EXPECT_OK(result);

1795 1796
  EXPECT_EQ(1u, result.value()->functions.size());
  EXPECT_EQ(1u, result.value()->export_table.size());
titzer's avatar
titzer committed
1797 1798
}

1799
TEST_F(WasmModuleVerifyTest, ExportNameWithInvalidStringLength) {
1800 1801 1802 1803 1804
  static const byte data[] = {
      // signatures
      SIGNATURES_SECTION_VOID_VOID, ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
      SECTION(Export,
              ENTRY_COUNT(1),     // exports
1805
              U32V_1(84),         // invalid string length
1806 1807 1808 1809 1810
              'e',                // --
              kExternalFunction,  // --
              FUNC_INDEX(0),      // --
              0, 0, 0)            // auxiliary data
  };
1811 1812 1813 1814

  EXPECT_FAILURE(data);
}

titzer's avatar
titzer committed
1815
TEST_F(WasmModuleVerifyTest, ExportTableTwo) {
1816 1817 1818 1819
  static const byte data[] = {
      // signatures
      SIGNATURES_SECTION_VOID_VOID, ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
      SECTION(Export,
1820 1821
              ENTRY_COUNT(2),                 // exports
              ADD_COUNT('n', 'a', 'm', 'e'),  // --
1822 1823 1824 1825 1826
              kExternalFunction,              // --
              FUNC_INDEX(0),                  // --
              ADD_COUNT('n', 'o', 'm'),       // --
              kExternalFunction,              // --
              FUNC_INDEX(0)),                 // --
1827
      ONE_EMPTY_BODY};
1828

1829
  ModuleResult result = DecodeModule(data, data + sizeof(data));
1830 1831
  EXPECT_OK(result);

1832 1833
  EXPECT_EQ(1u, result.value()->functions.size());
  EXPECT_EQ(2u, result.value()->export_table.size());
titzer's avatar
titzer committed
1834 1835 1836
}

TEST_F(WasmModuleVerifyTest, ExportTableThree) {
1837 1838 1839 1840 1841
  static const byte data[] = {
      // signatures
      SIGNATURES_SECTION_VOID_VOID, THREE_EMPTY_FUNCTIONS(SIG_INDEX(0)),
      SECTION(Export,
              ENTRY_COUNT(3),  // exports
1842
              ADD_COUNT('a'),  // --
1843
              kExternalFunction,
1844 1845
              FUNC_INDEX(0),   // --
              ADD_COUNT('b'),  // --
1846
              kExternalFunction,
1847 1848
              FUNC_INDEX(1),   // --
              ADD_COUNT('c'),  // --
1849 1850 1851
              kExternalFunction,
              FUNC_INDEX(2)),  // --
      THREE_EMPTY_BODIES};
1852
  ModuleResult result = DecodeModule(data, data + sizeof(data));
1853 1854
  EXPECT_OK(result);

1855 1856
  EXPECT_EQ(3u, result.value()->functions.size());
  EXPECT_EQ(3u, result.value()->export_table.size());
titzer's avatar
titzer committed
1857 1858 1859 1860
}

TEST_F(WasmModuleVerifyTest, ExportTableThreeOne) {
  for (int i = 0; i < 6; i++) {
1861 1862 1863 1864
    const byte data[] = {
        // signatures
        SIGNATURES_SECTION_VOID_VOID, THREE_EMPTY_FUNCTIONS(SIG_INDEX(0)),
        SECTION(Export,
1865 1866
                ENTRY_COUNT(1),       // exports
                ADD_COUNT('e', 'x'),  // --
1867 1868 1869
                kExternalFunction,
                FUNC_INDEX(i)),  // --
        THREE_EMPTY_BODIES};
titzer's avatar
titzer committed
1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880

    if (i < 3) {
      EXPECT_VERIFIES(data);
    } else {
      EXPECT_FAILURE(data);
    }
  }
}

TEST_F(WasmModuleVerifyTest, ExportTableOne_off_end) {
  static const byte data[] = {
1881
      // signatures
1882 1883 1884 1885 1886 1887 1888
      SIGNATURES_SECTION_VOID_VOID, ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
      SECTION(Export,
              ENTRY_COUNT(1),  // exports
              NO_NAME,         // --
              kExternalFunction,
              FUNC_INDEX(0),  // --
              0, 0, 0)        // auxiliary data
titzer's avatar
titzer committed
1889 1890
  };

1891
  EXPECT_OFF_END_FAILURE(data, arraysize(data) - 3);
titzer's avatar
titzer committed
1892 1893
}

1894 1895
TEST_F(WasmModuleVerifyTest, Regression_648070) {
  static const byte data[] = {
1896 1897 1898
      SECTION(Type, ENTRY_COUNT(0)),         // --
      SECTION(Function, U32V_5(3500228624))  // function count = 3500228624
  };                                         // --
1899 1900 1901
  EXPECT_FAILURE(data);
}

1902 1903 1904 1905 1906
TEST_F(WasmModuleVerifyTest, Regression_738097) {
  // The function body size caused an integer overflow in the module decoder.
  static const byte data[] = {
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // --
      FUNCTION_SIGNATURES_SECTION(1, 0),     // --
1907 1908 1909 1910
      SECTION(Code,                          // --
              ENTRY_COUNT(1),                // --
              U32V_5(0xFFFFFFFF),            // function size,
              0)                             // No real body
1911 1912 1913 1914
  };
  EXPECT_FAILURE(data);
}

1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939
TEST_F(WasmModuleVerifyTest, FunctionBodySizeLimit) {
  const uint32_t delta = 3;
  for (uint32_t body_size = kV8MaxWasmFunctionSize - delta;
       body_size < kV8MaxWasmFunctionSize + delta; body_size++) {
    byte data[] = {
        SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // --
        FUNCTION_SIGNATURES_SECTION(1, 0),     // --
        kCodeSectionCode,                      // code section
        U32V_5(1 + body_size + 5),             // section size
        1,                                     // # functions
        U32V_5(body_size)                      // body size
    };
    size_t total = sizeof(data) + body_size;
    byte* buffer = reinterpret_cast<byte*>(calloc(1, total));
    memcpy(buffer, data, sizeof(data));
    ModuleResult result = DecodeModule(buffer, buffer + total);
    if (body_size <= kV8MaxWasmFunctionSize) {
      EXPECT_TRUE(result.ok());
    } else {
      EXPECT_FALSE(result.ok());
    }
    free(buffer);
  }
}

1940
TEST_F(WasmModuleVerifyTest, FunctionBodies_empty) {
1941 1942 1943 1944 1945
  static const byte data[] = {
      EMPTY_SIGNATURES_SECTION,           // --
      EMPTY_FUNCTION_SIGNATURES_SECTION,  // --
      EMPTY_FUNCTION_BODIES_SECTION       // --
  };
1946 1947 1948 1949
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, FunctionBodies_one_empty) {
1950
  static const byte data[] = {
1951 1952 1953
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // --
      FUNCTION_SIGNATURES_SECTION(1, 0),     // --
      ONE_EMPTY_BODY                         // --
1954
  };
1955 1956 1957 1958
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, FunctionBodies_one_nop) {
1959
  static const byte data[] = {
1960 1961 1962
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),    // --
      FUNCTION_SIGNATURES_SECTION(1, 0),       // --
      SECTION(Code, ENTRY_COUNT(1), NOP_BODY)  // --
1963
  };
1964 1965 1966 1967
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, FunctionBodies_count_mismatch1) {
1968
  static const byte data[] = {
1969 1970 1971
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // --
      FUNCTION_SIGNATURES_SECTION(2, 0, 0),  // --
      ONE_EMPTY_BODY                         // --
1972
  };
1973 1974 1975 1976
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, FunctionBodies_count_mismatch2) {
1977
  static const byte data[] = {
1978 1979 1980
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),              // --
      FUNCTION_SIGNATURES_SECTION(1, 0),                 // --
      SECTION(Code, ENTRY_COUNT(2), NOP_BODY, NOP_BODY)  // --
1981
  };
1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992
  EXPECT_FAILURE(data);
}

TEST_F(WasmModuleVerifyTest, Names_empty) {
  static const byte data[] = {
      EMPTY_SIGNATURES_SECTION, EMPTY_FUNCTION_SIGNATURES_SECTION,
      EMPTY_FUNCTION_BODIES_SECTION, EMPTY_NAMES_SECTION};
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, Names_one_empty) {
1993 1994
  // TODO(wasm): This test does not test anything (corrupt name section does not
  // fail validation).
1995
  static const byte data[] = {
1996 1997
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),                      // --
      FUNCTION_SIGNATURES_SECTION(1, 0),                         // --
1998
      ONE_EMPTY_BODY,                                            // --
1999
      SECTION_NAMES(ENTRY_COUNT(1), FOO_STRING, NO_LOCAL_NAMES)  // --
2000 2001 2002 2003 2004
  };
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, Names_two_empty) {
2005 2006
  // TODO(wasm): This test does not test anything (corrupt name section does not
  // fail validation).
2007
  static const byte data[] = {
2008 2009 2010 2011 2012 2013
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),       // --
      FUNCTION_SIGNATURES_SECTION(2, 0, 0),       // --
      TWO_EMPTY_BODIES,                           // --
      SECTION_NAMES(ENTRY_COUNT(2),               // --
                    FOO_STRING, NO_LOCAL_NAMES,   // --
                    FOO_STRING, NO_LOCAL_NAMES),  // --
2014 2015 2016 2017
  };
  EXPECT_VERIFIES(data);
}

2018 2019
TEST_F(WasmModuleVerifyTest, Regression684855) {
  static const byte data[] = {
2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031
      SECTION_NAMES(0xFB,  // functions count
                    0x27,  // |
                    0x00,  // function name length
                    0xFF,  // local names count
                    0xFF,  // |
                    0xFF,  // |
                    0xFF,  // |
                    0xFF,  // |
                    0xFF,  // error: "varint too large"
                    0xFF,  // |
                    0x00,  // --
                    0x00)  // --
2032 2033 2034 2035
  };
  EXPECT_VERIFIES(data);
}

2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060
TEST_F(WasmModuleVerifyTest, FunctionSectionWithoutCodeSection) {
  static const byte data[] = {
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // Type section.
      FUNCTION_SIGNATURES_SECTION(1, 0),     // Function section.
  };
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "function count is 1, but code section is absent");
}

TEST_F(WasmModuleVerifyTest, CodeSectionWithoutFunctionSection) {
  static const byte data[] = {ONE_EMPTY_BODY};
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "function body count 1 mismatch (0 expected)");
}

TEST_F(WasmModuleVerifyTest, EmptyFunctionSectionWithoutCodeSection) {
  static const byte data[] = {SECTION(Function, ENTRY_COUNT(0))};
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, EmptyCodeSectionWithoutFunctionSection) {
  static const byte data[] = {SECTION(Code, ENTRY_COUNT(0))};
  EXPECT_VERIFIES(data);
}

2061 2062
class WasmInitExprDecodeTest : public TestWithZone {
 public:
2063
  WasmInitExprDecodeTest() = default;
2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077

  WasmFeatures enabled_features_;

  WasmInitExpr DecodeInitExpr(const byte* start, const byte* end) {
    return DecodeWasmInitExprForTesting(enabled_features_, start, end);
  }
};

#define EXPECT_INIT_EXPR(Type, type, value, ...)                   \
  {                                                                \
    static const byte data[] = {__VA_ARGS__, kExprEnd};            \
    WasmInitExpr expr = DecodeInitExpr(data, data + sizeof(data)); \
    EXPECT_EQ(WasmInitExpr::k##Type##Const, expr.kind);            \
    EXPECT_EQ(value, expr.val.type##_const);                       \
2078 2079
  }

2080 2081 2082 2083 2084 2085 2086 2087
#define EXPECT_INIT_EXPR_FAIL(...)                                 \
  {                                                                \
    static const byte data[] = {__VA_ARGS__, kExprEnd};            \
    WasmInitExpr expr = DecodeInitExpr(data, data + sizeof(data)); \
    EXPECT_EQ(WasmInitExpr::kNone, expr.kind);                     \
  }

TEST_F(WasmInitExprDecodeTest, InitExpr_i32) {
2088 2089 2090 2091 2092 2093
  EXPECT_INIT_EXPR(I32, i32, 33, WASM_I32V_1(33));
  EXPECT_INIT_EXPR(I32, i32, -21, WASM_I32V_1(-21));
  EXPECT_INIT_EXPR(I32, i32, 437, WASM_I32V_2(437));
  EXPECT_INIT_EXPR(I32, i32, 77777, WASM_I32V_3(77777));
}

2094
TEST_F(WasmInitExprDecodeTest, InitExpr_f32) {
2095 2096 2097 2098 2099 2100
  EXPECT_INIT_EXPR(F32, f32, static_cast<float>(13.1), WASM_F32(13.1));
  EXPECT_INIT_EXPR(F32, f32, static_cast<float>(-21.1), WASM_F32(-21.1));
  EXPECT_INIT_EXPR(F32, f32, static_cast<float>(437.2), WASM_F32(437.2));
  EXPECT_INIT_EXPR(F32, f32, static_cast<float>(77777.3), WASM_F32(77777.3));
}

2101
TEST_F(WasmInitExprDecodeTest, InitExpr_i64) {
2102 2103 2104 2105 2106 2107
  EXPECT_INIT_EXPR(I64, i64, 33, WASM_I64V_1(33));
  EXPECT_INIT_EXPR(I64, i64, -21, WASM_I64V_2(-21));
  EXPECT_INIT_EXPR(I64, i64, 437, WASM_I64V_5(437));
  EXPECT_INIT_EXPR(I64, i64, 77777, WASM_I64V_7(77777));
}

2108
TEST_F(WasmInitExprDecodeTest, InitExpr_f64) {
2109 2110 2111 2112 2113 2114
  EXPECT_INIT_EXPR(F64, f64, 83.22, WASM_F64(83.22));
  EXPECT_INIT_EXPR(F64, f64, -771.3, WASM_F64(-771.3));
  EXPECT_INIT_EXPR(F64, f64, 43703.0, WASM_F64(43703.0));
  EXPECT_INIT_EXPR(F64, f64, 77999.1, WASM_F64(77999.1));
}

2115 2116
TEST_F(WasmInitExprDecodeTest, InitExpr_AnyRef) {
  WASM_FEATURE_SCOPE(anyref);
2117
  static const byte data[] = {kExprRefNull, kExprEnd};
2118
  WasmInitExpr expr = DecodeInitExpr(data, data + sizeof(data));
2119 2120 2121
  EXPECT_EQ(WasmInitExpr::kAnyRefConst, expr.kind);
}

2122
TEST_F(WasmInitExprDecodeTest, InitExpr_illegal) {
2123 2124 2125 2126 2127 2128 2129
  EXPECT_INIT_EXPR_FAIL(WASM_I32V_1(0), WASM_I32V_1(0));
  EXPECT_INIT_EXPR_FAIL(WASM_GET_LOCAL(0));
  EXPECT_INIT_EXPR_FAIL(WASM_SET_LOCAL(0, WASM_I32V_1(0)));
  EXPECT_INIT_EXPR_FAIL(WASM_I32_ADD(WASM_I32V_1(0), WASM_I32V_1(0)));
  EXPECT_INIT_EXPR_FAIL(WASM_IF_ELSE(WASM_ZERO, WASM_ZERO, WASM_ZERO));
}

2130 2131
TEST_F(WasmModuleVerifyTest, Multiple_Named_Sections) {
  static const byte data[] = {
2132 2133 2134
      SECTION(Unknown, ADD_COUNT('X'), 17, 18),                    // --
      SECTION(Unknown, ADD_COUNT('f', 'o', 'o'), 5, 6, 7, 8, 9),   // --
      SECTION(Unknown, ADD_COUNT('o', 't', 'h', 'e', 'r'), 7, 8),  // --
2135 2136 2137
  };
  EXPECT_VERIFIES(data);
}
2138

2139
TEST_F(WasmModuleVerifyTest, Section_Name_No_UTF8) {
2140
  static const byte data[] = {SECTION(Unknown, 1, 0xFF, 17, 18)};
2141 2142 2143
  EXPECT_FAILURE(data);
}

2144 2145 2146
class WasmModuleCustomSectionTest : public TestWithIsolateAndZone {
 public:
  void CheckSections(const byte* module_start, const byte* module_end,
2147
                     const CustomSectionOffset* expected, size_t num_expected) {
2148 2149 2150 2151 2152 2153
    std::vector<CustomSectionOffset> custom_sections =
        DecodeCustomSections(module_start, module_end);

    CHECK_EQ(num_expected, custom_sections.size());

    for (size_t i = 0; i < num_expected; i++) {
2154 2155 2156 2157 2158 2159 2160 2161 2162 2163
      EXPECT_EQ(expected[i].section.offset(),
                custom_sections[i].section.offset());
      EXPECT_EQ(expected[i].section.length(),
                custom_sections[i].section.length());
      EXPECT_EQ(expected[i].name.offset(), custom_sections[i].name.offset());
      EXPECT_EQ(expected[i].name.length(), custom_sections[i].name.length());
      EXPECT_EQ(expected[i].payload.offset(),
                custom_sections[i].payload.offset());
      EXPECT_EQ(expected[i].payload.length(),
                custom_sections[i].payload.length());
2164 2165 2166 2167 2168
    }
  }
};

TEST_F(WasmModuleCustomSectionTest, ThreeUnknownSections) {
2169
  static constexpr byte data[] = {
2170 2171 2172 2173 2174
      U32_LE(kWasmMagic),                                  // --
      U32_LE(kWasmVersion),                                // --
      SECTION(Unknown, 1, 'X', 17, 18),                    // --
      SECTION(Unknown, 3, 'f', 'o', 'o', 5, 6, 7, 8, 9),   // --
      SECTION(Unknown, 5, 'o', 't', 'h', 'e', 'r', 7, 8),  // --
2175 2176
  };

2177 2178 2179 2180 2181
  static const CustomSectionOffset expected[] = {
      // section, name, payload
      {{10, 4}, {11, 1}, {12, 2}},  // --
      {{16, 9}, {17, 3}, {20, 5}},  // --
      {{27, 8}, {28, 5}, {33, 2}},  // --
2182 2183 2184 2185 2186 2187 2188
  };

  CheckSections(data, data + sizeof(data), expected, arraysize(expected));
}

TEST_F(WasmModuleCustomSectionTest, TwoKnownTwoUnknownSections) {
  static const byte data[] = {
2189 2190 2191 2192 2193 2194
      U32_LE(kWasmMagic),                                          // --
      U32_LE(kWasmVersion),                                        // --
      SIGNATURES_SECTION(2, SIG_ENTRY_v_v, SIG_ENTRY_v_v),         // --
      SECTION(Unknown, ADD_COUNT('X'), 17, 18),                    // --
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),                            // --
      SECTION(Unknown, ADD_COUNT('o', 't', 'h', 'e', 'r'), 7, 8),  // --
2195 2196
  };

2197 2198 2199 2200
  static const CustomSectionOffset expected[] = {
      // section, name, payload
      {{19, 4}, {20, 1}, {21, 2}},  // --
      {{29, 8}, {30, 5}, {35, 2}},  // --
2201 2202 2203 2204 2205
  };

  CheckSections(data, data + sizeof(data), expected, arraysize(expected));
}

2206
TEST_F(WasmModuleVerifyTest, SourceMappingURLSection) {
2207 2208
  static const byte data[] = {
      SECTION_SRC_MAP('s', 'r', 'c', '/', 'x', 'y', 'z', '.', 'c')};
2209 2210
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_TRUE(result.ok());
2211
  EXPECT_EQ("src/xyz.c", result.value()->source_map_url);
2212 2213 2214
}

TEST_F(WasmModuleVerifyTest, BadSourceMappingURLSection) {
2215 2216
  static const byte data[] = {
      SECTION_SRC_MAP('s', 'r', 'c', '/', 'x', 0xff, 'z', '.', 'c')};
2217 2218
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_TRUE(result.ok());
2219
  EXPECT_EQ(0u, result.value()->source_map_url.size());
2220 2221 2222
}

TEST_F(WasmModuleVerifyTest, MultipleSourceMappingURLSections) {
2223 2224
  static const byte data[] = {SECTION_SRC_MAP('a', 'b', 'c'),
                              SECTION_SRC_MAP('p', 'q', 'r')};
2225 2226
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_TRUE(result.ok());
2227
  EXPECT_EQ("abc", result.value()->source_map_url);
2228 2229
}

2230
TEST_F(WasmModuleVerifyTest, MultipleNameSections) {
2231
  static const byte data[] = {
2232 2233
      SECTION_NAMES(0, ADD_COUNT(ADD_COUNT('a', 'b', 'c'))),
      SECTION_NAMES(0, ADD_COUNT(ADD_COUNT('p', 'q', 'r', 's')))};
2234 2235
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_TRUE(result.ok());
2236
  EXPECT_EQ(3u, result.value()->name.length());
2237 2238
}

2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262
TEST_F(WasmModuleVerifyTest, PassiveDataSegment) {
  static const byte data[] = {
      // memory declaration ----------------------------------------------------
      SECTION(Memory, ENTRY_COUNT(1), 0, 1),
      // data segments  --------------------------------------------------------
      SECTION(Data, ENTRY_COUNT(1), PASSIVE, ADD_COUNT('h', 'i')),
  };
  EXPECT_FAILURE(data);
  WASM_FEATURE_SCOPE(bulk_memory);
  EXPECT_VERIFIES(data);
  EXPECT_OFF_END_FAILURE(data, arraysize(data) - 5);
}

TEST_F(WasmModuleVerifyTest, PassiveElementSegment) {
  static const byte data[] = {
      // sig#0 -----------------------------------------------------------------
      SIGNATURES_SECTION_VOID_VOID,
      // funcs -----------------------------------------------------------------
      ONE_EMPTY_FUNCTION(SIG_INDEX(0)),
      // table declaration -----------------------------------------------------
      SECTION(Table, ENTRY_COUNT(1), kLocalAnyFunc, 0, 1),
      // element segments  -----------------------------------------------------
      SECTION(Element, ENTRY_COUNT(1), PASSIVE,
              ADD_COUNT(FUNC_INDEX(0), FUNC_INDEX(0))),
2263 2264
      // code ------------------------------------------------------------------
      ONE_EMPTY_BODY};
2265 2266 2267 2268 2269 2270
  EXPECT_FAILURE(data);
  WASM_FEATURE_SCOPE(bulk_memory);
  EXPECT_VERIFIES(data);
  EXPECT_OFF_END_FAILURE(data, arraysize(data) - 5);
}

2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293
TEST_F(WasmModuleVerifyTest, DataCountSectionCorrectPlacement) {
  static const byte data[] = {SECTION(Element, ENTRY_COUNT(0)),
                              SECTION(DataCount, ENTRY_COUNT(0)),
                              SECTION(Code, ENTRY_COUNT(0))};
  EXPECT_FAILURE(data);
  WASM_FEATURE_SCOPE(bulk_memory);
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, DataCountSectionAfterCode) {
  static const byte data[] = {SECTION(Code, ENTRY_COUNT(0)),
                              SECTION(DataCount, ENTRY_COUNT(0))};
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result,
                "The DataCount section must appear before the Code section");
}

TEST_F(WasmModuleVerifyTest, DataCountSectionBeforeElement) {
  static const byte data[] = {SECTION(DataCount, ENTRY_COUNT(0)),
                              SECTION(Element, ENTRY_COUNT(0))};
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
2294
  EXPECT_NOT_OK(result, "unexpected section <Element>");
2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311
}

TEST_F(WasmModuleVerifyTest, DataCountSectionAfterStartBeforeElement) {
  STATIC_ASSERT(kStartSectionCode + 1 == kElementSectionCode);
  static const byte data[] = {
      // We need the start section for this test, but the start section must
      // reference a valid function, which requires the type and function
      // sections too.
      SIGNATURES_SECTION(1, SIG_ENTRY_v_v),  // Type section.
      FUNCTION_SIGNATURES_SECTION(1, 0),     // Function section.

      SECTION(Start, U32V_1(0)),           // Start section.
      SECTION(DataCount, ENTRY_COUNT(0)),  // DataCount section.
      SECTION(Element, ENTRY_COUNT(0))     // Element section.
  };
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
2312
  EXPECT_NOT_OK(result, "unexpected section <Element>");
2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363
}

TEST_F(WasmModuleVerifyTest, MultipleDataCountSections) {
  static const byte data[] = {SECTION(DataCount, ENTRY_COUNT(0)),
                              SECTION(DataCount, ENTRY_COUNT(0))};
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "Multiple DataCount sections not allowed");
}

TEST_F(WasmModuleVerifyTest, DataCountSegmentCountMatch) {
  static const byte data[] = {
      SECTION(Memory, ENTRY_COUNT(1), 0, 1),  // Memory section.
      SECTION(DataCount, ENTRY_COUNT(1)),     // DataCount section.
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,  // Data section.
              WASM_INIT_EXPR_I32V_1(12), ADD_COUNT('h', 'i'))};

  EXPECT_FAILURE(data);
  WASM_FEATURE_SCOPE(bulk_memory);
  EXPECT_VERIFIES(data);
}

TEST_F(WasmModuleVerifyTest, DataCountSegmentCount_greater) {
  static const byte data[] = {
      SECTION(Memory, ENTRY_COUNT(1), 0, 1),  // Memory section.
      SECTION(DataCount, ENTRY_COUNT(3)),     // DataCount section.
      SECTION(Data, ENTRY_COUNT(0))};         // Data section.
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "data segments count 0 mismatch (3 expected)");
}

TEST_F(WasmModuleVerifyTest, DataCountSegmentCount_less) {
  static const byte data[] = {
      SECTION(Memory, ENTRY_COUNT(1), 0, 1),  // Memory section.
      SECTION(DataCount, ENTRY_COUNT(0)),     // DataCount section.
      SECTION(Data, ENTRY_COUNT(1), LINEAR_MEMORY_INDEX_0,  // Data section.
              WASM_INIT_EXPR_I32V_1(12), ADD_COUNT('a', 'b', 'c'))};
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "data segments count 1 mismatch (0 expected)");
}

TEST_F(WasmModuleVerifyTest, DataCountSegmentCount_omitted) {
  static const byte data[] = {SECTION(Memory, ENTRY_COUNT(1), 0, 1),
                              SECTION(DataCount, ENTRY_COUNT(1))};
  WASM_FEATURE_SCOPE(bulk_memory);
  ModuleResult result = DecodeModule(data, data + sizeof(data));
  EXPECT_NOT_OK(result, "data segments count 0 mismatch (1 expected)");
}

2364 2365 2366 2367
#undef WASM_FEATURE_SCOPE
#undef WASM_FEATURE_SCOPE_VAL
#undef EXPECT_INIT_EXPR
#undef EXPECT_INIT_EXPR_FAIL
2368 2369 2370 2371 2372 2373 2374 2375
#undef WASM_INIT_EXPR_I32V_1
#undef WASM_INIT_EXPR_I32V_2
#undef WASM_INIT_EXPR_I32V_3
#undef WASM_INIT_EXPR_I32V_4
#undef WASM_INIT_EXPR_I32V_5
#undef WASM_INIT_EXPR_F32
#undef WASM_INIT_EXPR_I64
#undef WASM_INIT_EXPR_F64
2376
#undef WASM_INIT_EXPR_ANYREF
2377 2378 2379 2380 2381
#undef WASM_INIT_EXPR_GLOBAL
#undef EMPTY_BODY
#undef NOP_BODY
#undef SIG_ENTRY_i_i
#undef UNKNOWN_SECTION
2382 2383 2384
#undef COUNT_ARGS
#undef CHECK_LEB1
#undef ADD_COUNT
2385 2386 2387 2388 2389 2390 2391 2392 2393 2394
#undef SECTION
#undef SIGNATURES_SECTION
#undef FUNCTION_SIGNATURES_SECTION
#undef FOO_STRING
#undef NO_LOCAL_NAMES
#undef EMPTY_SIGNATURES_SECTION
#undef EMPTY_FUNCTION_SIGNATURES_SECTION
#undef EMPTY_FUNCTION_BODIES_SECTION
#undef SECTION_NAMES
#undef EMPTY_NAMES_SECTION
2395
#undef SECTION_SRC_MAP
2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410
#undef FAIL_IF_NO_EXPERIMENTAL_EH
#undef X1
#undef X2
#undef X3
#undef X4
#undef ONE_EMPTY_FUNCTION
#undef TWO_EMPTY_FUNCTIONS
#undef THREE_EMPTY_FUNCTIONS
#undef FOUR_EMPTY_FUNCTIONS
#undef ONE_EMPTY_BODY
#undef TWO_EMPTY_BODIES
#undef THREE_EMPTY_BODIES
#undef FOUR_EMPTY_BODIES
#undef SIGNATURES_SECTION_VOID_VOID
#undef LINEAR_MEMORY_INDEX_0
2411
#undef EXCEPTION_ENTRY
2412 2413 2414 2415 2416
#undef EXPECT_VERIFIES
#undef EXPECT_FAILURE_LEN
#undef EXPECT_FAILURE
#undef EXPECT_OFF_END_FAILURE
#undef EXPECT_OK
2417
#undef EXPECT_NOT_OK
2418

2419
}  // namespace module_decoder_unittest
2420 2421 2422
}  // namespace wasm
}  // namespace internal
}  // namespace v8