merge_to_branch.py 9.42 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
#!/usr/bin/env python
# Copyright 2014 the V8 project authors. All rights reserved.
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
#     * Redistributions of source code must retain the above copyright
#       notice, this list of conditions and the following disclaimer.
#     * Redistributions in binary form must reproduce the above
#       copyright notice, this list of conditions and the following
#       disclaimer in the documentation and/or other materials provided
#       with the distribution.
#     * Neither the name of Google Inc. nor the names of its
#       contributors may be used to endorse or promote products derived
#       from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29
import argparse
30
from collections import OrderedDict
31
import sys
32 33 34

from common_includes import *

35 36 37
def IsSvnNumber(rev):
  return rev.isdigit() and len(rev) < 8

38 39 40 41
class Preparation(Step):
  MESSAGE = "Preparation."

  def RunStep(self):
42
    if os.path.exists(self.Config("ALREADY_MERGING_SENTINEL_FILE")):
43
      if self._options.force:
44
        os.remove(self.Config("ALREADY_MERGING_SENTINEL_FILE"))
45
      elif self._options.step == 0:  # pragma: no cover
46
        self.Die("A merge is already in progress")
47
    open(self.Config("ALREADY_MERGING_SENTINEL_FILE"), "a").close()
48

49
    self.InitialEnvironmentChecks(self.default_cwd)
50 51

    self["merge_to_branch"] = self._options.branch
52 53 54 55 56 57 58 59 60

    self.CommonPrepare()
    self.PrepareBranch()


class CreateBranch(Step):
  MESSAGE = "Create a fresh branch for the patch."

  def RunStep(self):
61
    self.GitCreateBranch(self.Config("BRANCHNAME"),
62
                         self.vc.RemoteBranch(self["merge_to_branch"]))
63 64 65 66 67 68


class SearchArchitecturePorts(Step):
  MESSAGE = "Search for corresponding architecture ports."

  def RunStep(self):
69 70
    self["full_revision_list"] = list(OrderedDict.fromkeys(
        self._options.revisions))
71
    port_revision_list = []
72
    for revision in self["full_revision_list"]:
73
      # Search for commits which matches the "Port XXX" pattern.
74
      git_hashes = self.GitLog(reverse=True, format="%H",
75
                               grep="^[Pp]ort %s" % revision,
76
                               branch=self.vc.RemoteMasterBranch())
77 78
      for git_hash in git_hashes.splitlines():
        revision_title = self.GitLog(n=1, format="%s", git_hash=git_hash)
79 80

        # Is this revision included in the original revision list?
81 82 83
        if git_hash in self["full_revision_list"]:
          print("Found port of %s -> %s (already included): %s"
                % (revision, git_hash, revision_title))
84
        else:
85 86 87
          print("Found port of %s -> %s: %s"
                % (revision, git_hash, revision_title))
          port_revision_list.append(git_hash)
88 89 90 91 92 93

    # Do we find any port?
    if len(port_revision_list) > 0:
      if self.Confirm("Automatically add corresponding ports (%s)?"
                      % ", ".join(port_revision_list)):
        #: 'y': Add ports to revision list.
94
        self["full_revision_list"].extend(port_revision_list)
95 96


97 98
class CreateCommitMessage(Step):
  MESSAGE = "Create commit message."
99

100 101 102 103 104 105
  def _create_commit_description(self, commit_hash):
    patch_merge_desc = self.GitLog(n=1, format="%s", git_hash=commit_hash)
    description = "Merged: " + patch_merge_desc + "\n"
    description += "Revision: " + commit_hash + "\n\n"
    return description

106 107
  def RunStep(self):

108 109
    # Stringify: ["abcde", "12345"] -> "abcde, 12345"
    self["revision_list"] = ", ".join(self["full_revision_list"])
110

111
    if not self["revision_list"]:  # pragma: no cover
112 113
      self.Die("Revision list is empty.")

114
    msg_pieces = []
115

116 117 118 119 120 121 122
    if len(self["full_revision_list"]) > 1:
      self["commit_title"] = "Merged: Squashed multiple commits."
      for commit_hash in self["full_revision_list"]:
        msg_pieces.append(self._create_commit_description(commit_hash))
    else:
      commit_hash = self["full_revision_list"][0]
      full_description = self._create_commit_description(commit_hash).split("\n")
123

124 125 126 127 128 129 130
      #Truncate title because of code review tool
      title = full_description[0]
      if len(title) > 100:
        title = title[:96] + " ..."

      self["commit_title"] = title
      msg_pieces.append(full_description[1] + "\n\n")
131 132

    bugs = []
133
    for commit_hash in self["full_revision_list"]:
134
      msg = self.GitLog(n=1, git_hash=commit_hash)
135 136
      for bug in re.findall(r"^[ \t]*BUG[ \t]*=[ \t]*(.*?)[ \t]*$", msg, re.M):
        bugs.extend(s.strip() for s in bug.split(","))
137
    bug_aggregate = ",".join(sorted(filter(lambda s: s and s != "none", bugs)))
138
    if bug_aggregate:
139 140
      msg_pieces.append("BUG=%s\nLOG=N\n" % bug_aggregate)

141 142
    msg_pieces.append("NOTRY=true\nNOPRESUBMIT=true\nNOTREECHECKS=true\n")

143
    self["new_commit_msg"] = "".join(msg_pieces)
144 145 146 147 148 149


class ApplyPatches(Step):
  MESSAGE = "Apply patches for selected revisions."

  def RunStep(self):
150
    for commit_hash in self["full_revision_list"]:
151
      print("Applying patch for %s to %s..."
152
            % (commit_hash, self["merge_to_branch"]))
153
      patch = self.GitGetPatch(commit_hash)
154
      TextToFile(patch, self.Config("TEMPORARY_PATCH_FILE"))
155
      self.ApplyPatch(self.Config("TEMPORARY_PATCH_FILE"))
156
    if self._options.patch:
157
      self.ApplyPatch(self._options.patch)
158 159 160 161 162

class CommitLocal(Step):
  MESSAGE = "Commit to local branch."

  def RunStep(self):
163
    # Add a commit message title.
164 165
    self["new_commit_msg"] = "%s\n\n%s" % (self["commit_title"],
                                           self["new_commit_msg"])
166 167
    TextToFile(self["new_commit_msg"], self.Config("COMMITMSG_FILE"))
    self.GitCommit(file_name=self.Config("COMMITMSG_FILE"))
168 169 170 171 172

class CommitRepository(Step):
  MESSAGE = "Commit to the repository."

  def RunStep(self):
173
    self.GitCheckout(self.Config("BRANCHNAME"))
174
    self.WaitForLGTM()
175
    self.GitPresubmit()
176
    self.vc.CLLand()
177 178 179 180 181 182

class CleanUp(Step):
  MESSAGE = "Cleanup."

  def RunStep(self):
    self.CommonCleanup()
183 184 185 186
    print "*** SUMMARY ***"
    print "branch: %s" % self["merge_to_branch"]
    if self["revision_list"]:
      print "patches: %s" % self["revision_list"]
187 188


189 190 191
class MergeToBranch(ScriptsBase):
  def _Description(self):
    return ("Performs the necessary steps to merge revisions from "
192 193 194
            "master to release branches like 4.5. This script does not "
            "version the commit. See http://goo.gl/9ke2Vw for more "
            "information.")
195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216

  def _PrepareOptions(self, parser):
    group = parser.add_mutually_exclusive_group(required=True)
    group.add_argument("--branch", help="The branch to merge to.")
    parser.add_argument("revisions", nargs="*",
                        help="The revisions to merge.")
    parser.add_argument("-f", "--force",
                        help="Delete sentinel file.",
                        default=False, action="store_true")
    parser.add_argument("-m", "--message",
                        help="A commit message for the patch.")
    parser.add_argument("-p", "--patch",
                        help="A patch file to apply as part of the merge.")

  def _ProcessOptions(self, options):
    if len(options.revisions) < 1:
      if not options.patch:
        print "Either a patch file or revision numbers must be specified"
        return False
      if not options.message:
        print "You must specify a merge comment if no patches are specified"
        return False
217
    options.bypass_upload_hooks = True
218 219
    # CC ulan to make sure that fixes are merged to Google3.
    options.cc = "ulan@chromium.org"
220

221 222 223 224 225
    if len(options.branch.split('.')) > 2:
      print ("This script does not support merging to roll branches. "
             "Please use tools/release/roll_merge.py for this use case.")
      return False

226 227 228 229 230 231 232
    # Make sure to use git hashes in the new workflows.
    for revision in options.revisions:
      if (IsSvnNumber(revision) or
          (revision[0:1] == "r" and IsSvnNumber(revision[1:]))):
        print "Please provide full git hashes of the patches to merge."
        print "Got: %s" % revision
        return False
233 234
    return True

235 236 237 238 239 240 241 242 243 244
  def _Config(self):
    return {
      "BRANCHNAME": "prepare-merge",
      "PERSISTFILE_BASENAME": "/tmp/v8-merge-to-branch-tempfile",
      "ALREADY_MERGING_SENTINEL_FILE":
          "/tmp/v8-merge-to-branch-tempfile-already-merging",
      "TEMPORARY_PATCH_FILE": "/tmp/v8-prepare-merge-tempfile-temporary-patch",
      "COMMITMSG_FILE": "/tmp/v8-prepare-merge-tempfile-commitmsg",
    }

245 246 247 248 249
  def _Steps(self):
    return [
      Preparation,
      CreateBranch,
      SearchArchitecturePorts,
250
      CreateCommitMessage,
251 252 253 254 255 256 257
      ApplyPatches,
      CommitLocal,
      UploadStep,
      CommitRepository,
      CleanUp,
    ]

258

259
if __name__ == "__main__":  # pragma: no cover
260
  sys.exit(MergeToBranch().Run())