• Dale Curtis's avatar
    avformat/mov: Fix trampling of ctts during seeks when sidx support is enabled. · 37e8edc9
    Dale Curtis authored
    When sidx box support is enabled, the code will skip reading all
    trun boxes (each containing ctts entries for samples inthat box).
    
    If seeks are attempted before all ctts values are known, the old
    code would dump ctts entries into the wrong location. These are
    then used to compute pts values which leads to out of order and
    incorrectly timestamped packets.
    
    This patch fixes ctts processing by always using the index returned
    by av_add_index_entry() as the ctts_data index. When the index gains
    new entries old values are reshuffled as appropriate.
    
    This approach makes sense since the mov demuxer is already relying
    on the mapping of AVIndex entries to samples for correct demuxing.
    
    As a result of this all ctts entries are now 1-count. A followup
    change will be submitted to remove support for > 1 count entries
    which will simplify seeking.
    
    Notes for future improvement:
    Probably there are other boxes (stts, stsc, etc) that are impacted
    by this issue... this patch only attempts to fix ctts since it
    completely breaks packet timestamping.
    
    This patch continues using an array for the ctts data, which is not
    the most ideal given the rearrangement that needs to happen (via
    memmove as new entries are read in). Ideally AVIndex and the ctts
    data would be set-type structures so addition is always worst case
    O(lg(n)) instead of the O(n^2) that exists now; this slowdown is
    noticeable during seeks.
    Signed-off-by: 's avatarDale Curtis <dalecurtis@chromium.org>
    Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    37e8edc9
Name
Last commit
Last update
..
acodec-adpcm-ima_qt Loading commit data...
acodec-adpcm-ima_qt-trellis Loading commit data...
acodec-adpcm-ima_wav Loading commit data...
acodec-adpcm-ima_wav-trellis Loading commit data...
acodec-adpcm-ms Loading commit data...
acodec-adpcm-ms-trellis Loading commit data...
acodec-adpcm-swf Loading commit data...
acodec-adpcm-swf-trellis Loading commit data...
acodec-adpcm-yamaha Loading commit data...
acodec-adpcm-yamaha-trellis Loading commit data...
acodec-alac Loading commit data...
acodec-flac Loading commit data...
acodec-mp2 Loading commit data...
acodec-pcm-alaw Loading commit data...
acodec-pcm-f32be Loading commit data...
acodec-pcm-f32le Loading commit data...
acodec-pcm-f64be Loading commit data...
acodec-pcm-f64le Loading commit data...
acodec-pcm-mulaw Loading commit data...
acodec-pcm-s16be Loading commit data...
acodec-pcm-s16le Loading commit data...
acodec-pcm-s24be Loading commit data...
acodec-pcm-s24le Loading commit data...
acodec-pcm-s32be Loading commit data...
acodec-pcm-s32le Loading commit data...
acodec-pcm-s8 Loading commit data...
acodec-pcm-u8 Loading commit data...
cache-pipe Loading commit data...
extra-mp3 Loading commit data...
extra-mp4 Loading commit data...
lavf-aiff Loading commit data...
lavf-alaw Loading commit data...
lavf-asf Loading commit data...
lavf-au Loading commit data...
lavf-avi Loading commit data...
lavf-bmp Loading commit data...
lavf-dv_fmt Loading commit data...
lavf-ffm Loading commit data...
lavf-flv_fmt Loading commit data...
lavf-gif Loading commit data...
lavf-gxf Loading commit data...
lavf-jpg Loading commit data...
lavf-mkv Loading commit data...
lavf-mmf Loading commit data...
lavf-mov Loading commit data...
lavf-mpg Loading commit data...
lavf-mulaw Loading commit data...
lavf-mxf Loading commit data...
lavf-mxf_d10 Loading commit data...
lavf-mxf_opatom Loading commit data...
lavf-mxf_opatom_audio Loading commit data...
lavf-nut Loading commit data...
lavf-ogg Loading commit data...
lavf-pbmpipe Loading commit data...
lavf-pcx Loading commit data...
lavf-pgm Loading commit data...
lavf-pgmpipe Loading commit data...
lavf-ppm Loading commit data...
lavf-ppmpipe Loading commit data...
lavf-rm Loading commit data...
lavf-sgi Loading commit data...
lavf-swf Loading commit data...
lavf-tga Loading commit data...
lavf-tiff Loading commit data...
lavf-ts Loading commit data...
lavf-voc Loading commit data...
lavf-wav Loading commit data...
lavf-wtv Loading commit data...
lavf-yuv4mpeg Loading commit data...
mkv-codec-delay Loading commit data...
vsynth_lena-asv1 Loading commit data...
vsynth_lena-asv2 Loading commit data...
vsynth_lena-dnxhd-1080i Loading commit data...
vsynth_lena-dnxhd-4k-hr-lb Loading commit data...
vsynth_lena-dnxhd-720p Loading commit data...
vsynth_lena-dnxhd-720p-rd Loading commit data...
vsynth_lena-dv Loading commit data...
vsynth_lena-dv-411 Loading commit data...
vsynth_lena-dv-50 Loading commit data...
vsynth_lena-ffv1 Loading commit data...
vsynth_lena-flashsv Loading commit data...
vsynth_lena-flv Loading commit data...
vsynth_lena-h261 Loading commit data...
vsynth_lena-h263 Loading commit data...
vsynth_lena-h263p Loading commit data...
vsynth_lena-huffyuv Loading commit data...
vsynth_lena-jpegls Loading commit data...
vsynth_lena-ljpeg Loading commit data...
vsynth_lena-mjpeg Loading commit data...
vsynth_lena-mpeg1 Loading commit data...
vsynth_lena-mpeg1b Loading commit data...
vsynth_lena-mpeg2-422 Loading commit data...
vsynth_lena-mpeg2-idct-int Loading commit data...
vsynth_lena-mpeg2-ilace Loading commit data...
vsynth_lena-mpeg2-ivlc-qprd Loading commit data...
vsynth_lena-mpeg2-thread Loading commit data...
vsynth_lena-mpeg2-thread-ivlc Loading commit data...
vsynth_lena-mpeg4 Loading commit data...
vsynth_lena-mpeg4-adap Loading commit data...
vsynth_lena-mpeg4-adv Loading commit data...
vsynth_lena-mpeg4-error Loading commit data...
vsynth_lena-mpeg4-nr Loading commit data...
vsynth_lena-mpeg4-nsse Loading commit data...
vsynth_lena-mpeg4-qpel Loading commit data...
vsynth_lena-mpeg4-qprd Loading commit data...
vsynth_lena-mpeg4-rc Loading commit data...
vsynth_lena-mpeg4-thread Loading commit data...
vsynth_lena-msmpeg4 Loading commit data...
vsynth_lena-msmpeg4v2 Loading commit data...
vsynth_lena-rgb Loading commit data...
vsynth_lena-roqvideo Loading commit data...
vsynth_lena-rv10 Loading commit data...
vsynth_lena-rv20 Loading commit data...
vsynth_lena-snow Loading commit data...
vsynth_lena-snow-ll Loading commit data...
vsynth_lena-svq1 Loading commit data...
vsynth_lena-wmv1 Loading commit data...
vsynth_lena-wmv2 Loading commit data...
vsynth_lena-yuv Loading commit data...