-
Rostislav Pehlivanov authored
This commit rewrites the PNS implementation and significantly improves sonic quality. The previous implementation marked an incredibly big amount of SFBs to predict when there was no need for this and this resulted in quite a large amount of artifacts. Also the quantization was incorrect (av_clip(4+log2f(...))) which led to 3x the intensity for PNS values leading to even more artifacts. This commit rewrites the PNS search function and introduces a major change: the PNS values are synthesized and are compared to the current coefficients in addition to passing through the revised checks to see whether PNS can be used. This decreases distortions and makes the current PNS implementation mainly focused on replacing any low-power non-zero bands as well as adding any zeroed bands back. The current encoder's performance is enough (especially with IS) so PNS isn't really required except to fill in the occasional few bands as well as extend any zeroed high frequency, so this combination which is already enabled by default works to get as much quality as it can within the bits allowed. Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
033e5894