- 05 Apr, 2020 4 commits
-
-
Andreas Rheinhardt authored
The code for GAB2 subtitles predates refcounting AVPackets. So in order to transfer the ownership of a packet's data pkt->data was simply stored and the packet zeroed; in the end (i.e. in the read_close-function) this data was then simply freed with av_freep(). This of course leads to a leak of an AVBufferRef and an AVBuffer. It has been fixed by keeping and eventually unreferencing the packet's buf instead. Additionally, the packet is now reset via av_packet_unref(). Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-
Andreas Rheinhardt authored
An AVIStream (intended to be used as private data for an AVStream) would leak in this scenario. Also return a more fitting error code instead of AVERROR_INVALIDDATA. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-
Andreas Rheinhardt authored
If one uses a build without dv demuxer, an AVIStream struct that is destined to be used as private data for an AVStream by the avi demuxer would leak, because it has been moved from the AVStream (that is going to be freed) and only stored in a local variable (in order to be used for another AVStream), but if the dv demuxer is disabled, the earlier code returned immediately instead. Also return a better error code in this scenario (instead of AVERROR_INVALIDDATA). Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-
Andreas Rheinhardt authored
Using ff_free_stream() makes the code more readable, more future-proof (the old code freed AVCodecContexts and AVCodecParameters and its substructures manually, so that there is a chance that there would be a memleak for some time if new substructures were added) and reduces code size. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-
- 12 Mar, 2020 1 commit
-
-
Paul B Mahol authored
Fixes decoding of came2_2020-01-13__20-38-58_21-00-00__Chn2.avi
-
- 16 Feb, 2020 1 commit
-
-
Michael Niedermayer authored
Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long' Fixes: Ticket8149 Found-by: Suhwan Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 12 Dec, 2019 2 commits
-
-
Andreas Rheinhardt authored
These functions already free it themselves before they allocate the new extradata. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Andreas Rheinhardt authored
It is not uncommon to find code where the caller thinks to know better what the return value should be than the callee. E.g. something like "if (av_new_packet(pkt, size) < 0) return AVERROR(ENOMEM);". This commit changes several instances of this to instead forward the actual error. Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Oct, 2019 1 commit
-
-
Andreas Rheinhardt authored
bswap.h was included since 7b114c09, yet since 3788a3c0 no explicit use of anything from bswap.h has been made, so remove this header. (Only AV_RL32 is used and while this might imply swapping on big-endian systems, it is contained in libavutil/intreadwrite.h.) Signed-off-by:
Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 08 Oct, 2019 1 commit
-
-
Steven Liu authored
Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
Steven Liu <lq@chinaffmpeg.org>
-
- 10 Sep, 2019 1 commit
-
-
Jun Zhao authored
free the value in error handling path to avoid the memory leak. Signed-off-by:
Jun Zhao <barryjzhao@tencent.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 31 Aug, 2019 1 commit
-
-
Marton Balint authored
Some security cams generate this, as well as some versions of VirtualDub and VLC so support for _reading_ such files is justified. Fixes ticket #7110. See also this discussion: https://patchwork.ffmpeg.org/patch/8744/Signed-off-by:
Marton Balint <cus@passwd.hu>
-
- 10 May, 2019 1 commit
-
-
Carl Eugen Hoyos authored
AVCodecContext->bit_rate is int64_t since 7404f3bd Unbreaks non-interleaved detection of v210 4k avi files, broken since 0eec40b7. Reported-by: Xavier Càmara, Centre de Conservació i Restauració, Filmoteca de Catalunya
-
- 21 Mar, 2019 1 commit
-
-
Carl Eugen Hoyos authored
Reviewed-by: Lauri Kasanen Reviewed-by: Tomas Härdin
-
- 20 Mar, 2019 1 commit
-
-
Carl Eugen Hoyos authored
-
- 21 Aug, 2018 1 commit
-
-
Paul B Mahol authored
-
- 10 Mar, 2018 1 commit
-
-
Michael Niedermayer authored
Fixes: signed integer overflow: 3775922176 * 4278190080 cannot be represented in type 'long' Fixes: Chromium bug 791237 Reported-by:
Matt Wolenetz <wolenetz@google.com> Reviewed-by:
Matt Wolenetz <wolenetz@google.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 26 Oct, 2017 1 commit
-
-
James Almer authored
This prevents potential ABI issues with GetByteContext. Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 01 Sep, 2017 1 commit
-
-
Anton Khirnov authored
(cherry picked from commit 6f554521) Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 11 Aug, 2017 1 commit
-
-
Michael Niedermayer authored
This fixes loosing packets Fixes: big.avi Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 31 May, 2017 2 commits
-
-
Michael Niedermayer authored
This prevents part of one exploit leading to an information leak Found-by: Emil Lerner and Pavel Cheremushkin Reported-by:
Thierry Foucu <tfoucu@google.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes: subtitle.avi from vlc/ticket/1162 Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 29 Mar, 2017 2 commits
-
-
Clément Bœsch authored
-
Clément Bœsch authored
-
- 15 Feb, 2017 1 commit
-
-
Alexandra Hájková authored
Some muxers may use the BMP_HEADER Format Data size instead of the ASF-specific one. Bug-Id: 1020 CC: libav-stable@libav.org Signed-off-by:
Diego Biurrun <diego@biurrun.de>
-
- 11 Feb, 2017 1 commit
-
-
Anton Khirnov authored
-
- 03 Jan, 2017 1 commit
-
-
Tobias Rapp authored
Signed-off-by:
Tobias Rapp <t.rapp@noa-archive.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 23 Dec, 2016 1 commit
-
-
Tobias Rapp authored
Fixes pts gaps when reading AVI files > 256GiB generated by FFmpeg. Signed-off-by:
Tobias Rapp <t.rapp@noa-archive.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 30 Nov, 2016 1 commit
-
-
Andreas Cadhalpun authored
Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
-
- 27 Oct, 2016 1 commit
-
-
Diego Biurrun authored
This also kills some warnings with certain compiler options.
-
- 18 Oct, 2016 1 commit
-
-
Carl Eugen Hoyos authored
-
- 17 Oct, 2016 1 commit
-
-
Carl Eugen Hoyos authored
Fixes demuxing the sample file from github pull request 197, the size of its idx1 tag is 6171936 bytes, followed by a JUNK tag of 9505704 bytes.
-
- 02 Oct, 2016 2 commits
-
-
Vittorio Giovara authored
Palette format is always in RGBA.
-
Vittorio Giovara authored
This simplifies the code a bit, does not change output data in any way.
-
- 30 Sep, 2016 1 commit
-
-
Anton Khirnov authored
It is supposed to be a flag. The only currently defined value is AVIO_SEEKABLE_NORMAL, but other ones may be added in the future. However all the current lavf code treats this field as a bool (mainly for historical reasons). Change all those cases to properly check for AVIO_SEEKABLE_NORMAL.
-
- 28 Sep, 2016 2 commits
-
-
Michael Niedermayer authored
Fixes null pointer dereference Fixes: 1/null_point.avi Found-by:
连一汉 <lianyihan@360.cn> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
This assert can with crafted files fail, a warning is already printed for this case. Fixes assertion failure Fixes:1/assert.avi Found-by:
连一汉 <lianyihan@360.cn> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Sep, 2016 2 commits
-
-
James Almer authored
Signed-off-by:
James Almer <jamrial@gmail.com>
-
Michael Niedermayer authored
Found-by:
连一汉 <lianyihan@360.cn> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 02 Sep, 2016 1 commit
-
-
Michael Niedermayer authored
Fixes: 360/test.poc Found-by:
连一汉 <lianyihan@360.cn> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-