1. 13 Jan, 2018 2 commits
    • Rostislav Pehlivanov's avatar
      fate: remove the fate-aac-ltp-encode test · 6c4b9eb9
      Rostislav Pehlivanov authored
      It tests a useless profile which sounds no better than regular aac and which
      takes extremely long to encoder something. Also it has been behind experimental
      flag for as long as it has been supported.
      Should be removed altogether sometime in the future.
      6c4b9eb9
    • Rostislav Pehlivanov's avatar
      aacenc: use the fast coder as the default · fcb681ac
      Rostislav Pehlivanov authored
      The twoloop coder sounds decent at low bitrates, however at higher bitrates
      it sounds worse than the fast coder (which used to be the old twoloop coder
      before October 2015) and needs quite a lot more CPU.
      Change the default to fast. It has been well tested and has had little changes
      over the years so its been confirmed to be quite stable.
      Also change its description (not valid for more than a year) and the
      documentation.
      Signed-off-by: 's avatarRostislav Pehlivanov <atomnuker@gmail.com>
      fcb681ac
  2. 25 Aug, 2017 1 commit
  3. 24 May, 2017 2 commits
  4. 24 Oct, 2016 1 commit
  5. 03 Apr, 2016 1 commit
  6. 05 Mar, 2016 1 commit
  7. 04 Feb, 2016 1 commit
  8. 27 Jan, 2016 1 commit
  9. 20 Jan, 2016 1 commit
  10. 17 Jan, 2016 1 commit
  11. 13 Jan, 2016 3 commits
    • Claudio Freire's avatar
      AAC encoder: fix I/S relative error evaluation · aa64a483
      Claudio Freire authored
      The relative error between two encoding strategies is the simple
      difference of rate-distortion values, and not the absolute
      difference. An absolute measure would allow worsening of the
      quantization error as well as improving.
      aa64a483
    • Claudio Freire's avatar
      AAC encoder: various fixes in M/S coding · 6711aa21
      Claudio Freire authored
      1. Fix sf_idx and band_type addressing to address only the first
      subwindow in the group (others could hold garbage values)
      
      2. Don't step on ms_mask when is_mask is set. I/S selection
      already sets the ms_mask properly and shouldn't be overridden.
      
      3. Use mid/sid cb/sf when computing coding error, as should be
      since those are the cb/sfs that will eventually be set.
      
      4. Fix distortion computation on multi-subwindow groups (was
      subtracting the bits terms multiple times)
      
      5. Clear ms_mask when one side uses PNS and the other doesn't.
      When using PNS, ms_mask signals correlated noise, which can be
      detected just like regular M/S detection, so we don't skip
      noise bands, but when only one side uses PNS setting the flag
      can confuse some encoders, so avoid that.
      6711aa21
    • Claudio Freire's avatar
      AAC encoder: avoid assertion failure on PNS · 00d481b2
      Claudio Freire authored
      In rare corner cases it could still fail an assert on sf_diff due
      to failure to update prev_sf in some code paths. Fix that case.
      00d481b2
  12. 13 Dec, 2015 1 commit
  13. 08 Dec, 2015 2 commits
  14. 06 Dec, 2015 1 commit
  15. 03 Dec, 2015 1 commit
  16. 02 Dec, 2015 1 commit
    • Claudio Freire's avatar
      AAC encoder: improve SF range utilization · ca203e99
      Claudio Freire authored
      This patch does 4 things, all of which interact and thus it
      woudln't be possible to commit them separately without causing
      either quality regressions or assertion failures.
      
      Fate comparison targets don't all reflect improvements in
      quality, yet listening tests show substantially improved quality
      and stability.
      
      1. Increase SF range utilization.
      
      The spec requires SF delta values to be constrained within the
      range -60..60. The previous code was applying that range to
      the whole SF array and not only the deltas of consecutive values,
      because doing so requires smarter code: zeroing or otherwise
      skipping a band may invalidate lots of SF choices.
      
      This patch implements that logic to allow the coders to utilize
      the full dynamic range of scalefactors, increasing quality quite
      considerably, and fixing delta-SF-related assertion failures,
      since now the limitation is enforced rather than asserted.
      
      2. PNS tweaks
      
      The previous modification makes big improvements in twoloop's
      efficiency, and every time that happens PNS logic needs to be
      tweaked accordingly to avoid it from stepping all over twoloop's
      decisions. This patch includes modifications of the sort.
      
      3. Account for lowpass cutoff during PSY analysis
      
      The closer PSY's allocation is to final allocation the better
      the quality is, and given these modifications, twoloop is now
      very efficient at avoiding holes. Thus, to compute accurate
      thresholds, PSY needs to account for the lowpass applied
      implicitly during twoloop (by zeroing high bands).
      
      This patch makes twoloop set the cutoff in psymodel's context
      the first time it runs, and makes PSY account for it during
      threshold computation, making PE and threshold computations
      closer to the final allocation and thus achieving better
      subjective quality.
      
      4. Tweaks to RC lambda tracking loop in relation to PNS
      
      Without this tweak some corner cases cause quality regressions.
      Basically, lambda needs to react faster to overall bitrate
      efficiency changes since now PNS can be quite successful in
      enforcing maximum bitrates, when PSY allocates too many bits
      to the lower bands, suppressing the signals RC logic uses to
      lower lambda in those cases and causing aggressive PNS.
      
      This tweak makes PNS much less aggressive, though it can still
      use some further tweaks.
      
      Also update MIPS specializations and adjust fuzz
      
      Also in lavc/mips/aacpsy_mips.h: remove trailing whitespace
      ca203e99
  17. 29 Nov, 2015 1 commit
    • Claudio Freire's avatar
      AAC encoder: make pe.min a local minimum · 88e498a8
      Claudio Freire authored
      As noted in a comment, pe.min in the reference encoder
      is centered around current pe. The bit reservoir algo
      needs pe.min to be a local minimum, because it can only
      account for local PE variations. If it's set to a global
      minimum as was being done, bit reservoir logic doesn't
      work as efficiently.
      
      This patch tries to forget old minimums and converge to
      a local minimum without losing the stability of the
      previous solution. Listening tests until now suggest this
      solves numerous RC issues.
      88e498a8
  18. 26 Nov, 2015 1 commit
  19. 27 Oct, 2015 2 commits
  20. 26 Oct, 2015 2 commits
  21. 17 Oct, 2015 7 commits
  22. 12 Oct, 2015 1 commit
  23. 11 Oct, 2015 2 commits
    • Claudio Freire's avatar
      AAC encoder tests: increase fuzz for pred test · 79f2014f
      Claudio Freire authored
      MIPS needs more fuzz
      79f2014f
    • Claudio Freire's avatar
      AAC encoder: Extensive improvements · 01ecb717
      Claudio Freire authored
      This finalizes merging of the work in the patches in ticket #2686.
      
      Improvements to twoloop and RC logic are extensive.
      
      The non-exhaustive list of twoloop improvments includes:
       - Tweaks to distortion limits on the RD optimization phase of twoloop
       - Deeper search in twoloop
       - PNS information marking to let twoloop decide when to use it
         (turned out having the decision made separately wasn't working)
       - Tonal band detection and priorization
       - Better band energy conservation rules
       - Strict hole avoidance
      
      For rate control:
       - Use psymodel's bit allocation to allow proper use of the bit
         reservoir. Don't work against the bit reservoir by moving lambda
         in the opposite direction when psymodel decides to allocate more/less
         bits to a frame.
       - Retry the encode if the effective rate lies outside a reasonable
         margin of psymodel's allocation or the selected ABR.
       - Log average lambda at the end. Useful info for everyone, but especially
         for tuning of the various encoder constants that relate to lambda
         feedback.
      
      Psy:
       - Do not apply lowpass with a FIR filter, instead just let the coder
         zero bands above the cutoff. The FIR filter induces group delay,
         and while zeroing bands causes ripple, it's lost in the quantization
         noise.
       - Experimental VBR bit allocation code
       - Tweak automatic lowpass filter threshold to maximize audio bandwidth
         at all bitrates while still providing acceptable, stable quality.
      
      I/S:
       - Phase decision fixes. Unrelated to #2686, but the bugs only surfaced
         when the merge was finalized. Measure I/S band energy accounting for
         phase, and prevent I/S and M/S from being applied both.
      
      PNS:
       - Avoid marking short bands with PNS when they're part of a window
         group in which there's a large variation of energy from one window
         to the next. PNS can't preserve those and the effect is extremely
         noticeable.
      
      M/S:
       - Implement BMLD protection similar to the specified in
         ISO-IEC/13818:7-2003, Appendix C Section 6.1. Since M/S decision
         doesn't conform to section 6.1, a different method had to be
         implemented, but should provide equivalent protection.
       - Move the decision logic closer to the method specified in
         ISO-IEC/13818:7-2003, Appendix C Section 6.1. Specifically,
         make sure M/S needs less bits than dual stereo.
       - Don't apply M/S in bands that are using I/S
      
      Now, this of course needed adjustments in the compare targets and
      fuzz factors of the AAC encoder's fate tests, but if wondering why
      the targets go up (more distortion), consider the previous coder
      was using too many bits on LF content (far more than required by
      psy), and thus those signals will now be more distorted, not less.
      
      The extra distortion isn't audible though, I carried extensive
      ABX testing to make sure.
      
      A very similar patch was also extensively tested by Kamendo2 in
      the context of #2686.
      01ecb717
  24. 25 Sep, 2015 1 commit
    • Claudio Freire's avatar
      AAC encoder: tweak PNS usage to be more aggressive · 9458a62d
      Claudio Freire authored
      This patch tweaks search_for_pns to be both more
      aggressive and more careful when applying PNS. On
      the one side, it will again try to use PNS on zero
      (or effectively zero) bands. For this, both zeroes
      and band_type have to be checked (some ZERO bands
      aren't marked in zeroes). On the other side, a more
      accurate rate-distortion measure avoids using PNS
      where it would cause audible distortion.
      
      Also fixed a small bug in the computation of freq
      that caused PNS usage on low-frequency bands during
      8-short windows. This allows re-enabling PNS during
      8-short.
      9458a62d
  25. 23 Sep, 2015 1 commit
    • Claudio Freire's avatar
      AAC encoder: tweak rate-distortion logic · 7ec74ae4
      Claudio Freire authored
      This patch modifies the encode frame function to
      retry encoding the frame when the resulting bit count
      is too far off target, but only adjusting lambda
      in small, incremental step. It also makes the logic
      more conservative - otherwise it will contend with
      bit reservoir-related variations in bit allocation,
      and result in artifacts when frame have to be truncated
      (usually at high bit rates transitioning from low
      complexity to high complexity).
      7ec74ae4
  26. 19 Sep, 2015 1 commit