- 31 Oct, 2015 11 commits
-
-
Matt Oliver authored
Signed-off-by:Matt Oliver <protogonoi@gmail.com>
-
Agatha Hu authored
Signed-off-by:Timo Rothenpieler <timo@rothenpieler.org>
-
Ganesh Ajjanagadde authored
clSetKernelArg can return an error due to lack of memory (for instance): https://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/clSetKernelArg.html. Thus this error must be propagated. Currently should not trigger warnings, but adds robustness. Untested. Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
Ganesh Ajjanagadde <gajjanagadde@gmail.com>
-
Ganesh Ajjanagadde authored
qsort is called indirectly in filter_frame, suggesting its performance criticality. AV_QSORT is substantially faster due to the inlining of the comparison callback. Thus, the increase in performance should be worth the increase in binary size. This optimization is just a low hanging fruit. The trac ticket 1430 is a request for an improved deshake filter. Sample benchmark (x86-64, Haswell, GNU/Linux): File: original from https://trac.ffmpeg.org/ticket/1430 command: ffmpeg -stream_loop 8 -i file.webm -vf deshake=rx=64:ry=64 -f null - Timer truncated at 1024 runs. new: 28260 decicycles in qsort, 1 runs, 0 skips 35570 decicycles in qsort, 2 runs, 0 skips 39010 decicycles in qsort, 4 runs, 0 skips 46897 decicycles in qsort, 8 runs, 0 skips 40442 decicycles in qsort, 16 runs, 0 skips 41611 decicycles in qsort, 32 runs, 0 skips 40345 decicycles in qsort, 64 runs, 0 skips 38967 decicycles in qsort, 128 runs, 0 skips 38647 decicycles in qsort, 256 runs, 0 skips 40238 decicycles in qsort, 512 runs, 0 skips 39676 decicycles in qsort, 1024 runs, 0 skips old: 1740280 decicycles in qsort, 1 runs, 0 skips 923560 decicycles in qsort, 2 runs, 0 skips 511330 decicycles in qsort, 4 runs, 0 skips 309720 decicycles in qsort, 8 runs, 0 skips 194900 decicycles in qsort, 16 runs, 0 skips 142686 decicycles in qsort, 32 runs, 0 skips 112516 decicycles in qsort, 64 runs, 0 skips 98166 decicycles in qsort, 128 runs, 0 skips 88147 decicycles in qsort, 256 runs, 0 skips 88706 decicycles in qsort, 512 runs, 0 skips 86783 decicycles in qsort, 1024 runs, 0 skips Reviewed-by:
Nicolas George <george@nsup.org> Reviewed-by:
-
Matt Oliver authored
Signed-off-by: -
Matt Oliver authored
Signed-off-by: -
Ganesh Ajjanagadde authored
This simplifies and cleans up the code. Furthermore, it is much faster due to absence of the slow log computation. Reviewed-by:
-
Michael Niedermayer authored
Signed-off-by: -
Michael Niedermayer authored
Signed-off-by: -
Michael Niedermayer authored
Signed-off-by: -
Michael Niedermayer authored
Signed-off-by:
-
- 30 Oct, 2015 12 commits
-
-
Michael Niedermayer authored
Should fix build on x86_32-msvc2012 The alternative of emulating fmin/fmax* turns out to be non trivial Signed-off-by: -
Muhammad Faiz authored
Signed-off-by: -
Marton Balint authored
ffprobe.xsd already contains the tag element. Reviewed-by:
Stefano Sabatini <stefasab@gmail.com> Signed-off-by:
Marton Balint <cus@passwd.hu>
-
Ganesh Ajjanagadde authored
ISO C restricts enumerator values to the range of int. Thus (for instance) 0x80000000 unfortunately does not work, and throws a warning with -Wpedantic on clang 3.7. This fixes it by using alternative expressions that result in identical values but do not have this issue. Tested with FATE. Reviewed-by:
Ronald S. Bultje <rsbultje@gmail.com> Reviewed-by:
-
Ganesh Ajjanagadde authored
Current code is fine, this just adds robustness. Reviewed-by:
-
Ganesh Ajjanagadde authored
av_gcd is now always defined regardless of input. This documents this change in the "documented API". Two benefits (closely related): 1. The function is robust, and there is no need to worry about INT64_MIN, etc. 2. Clients of av_gcd, like av_reduce, can now be made fully correct. Currently, av_reduce can trigger undefined behavior if e.g num is INT64_MIN due to integer overflow in the FFABS. Furthermore, this undefined behavior is completely undocumented, and could be a fuzzer's paradise. The FFABS was needed in the past as av_gcd was undefined for negative inputs. In order to make av_reduce robust, it is essential to guarantee that av_gcd works for all int64_t. Reviewed-by:
-
Nicolas George authored
Fix a segfault when no encoder is found for a default codec with a complex filter graph.
-
Steven Robertson authored
Signed-off-by:
Steven Robertson <steven@strobe.cc> Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
-
Michael Niedermayer authored
Signed-off-by: -
Michael Niedermayer authored
Fixes regression with iJi.ogv Signed-off-by: -
Carl Eugen Hoyos authored
QT ignores the value written in the frame header. Issue reported by forum user Koracas.
-
Carl Eugen Hoyos authored
-
- 29 Oct, 2015 17 commits
-
-
Ganesh Ajjanagadde authored
This ensures that no undefined behavior is invoked, while retaining identical return values in all cases and at no loss of performance (identical asm on clang and gcc). Essentially, this patch exchanges undefined behavior with implementation defined behavior, a strict improvement. Rationale: 1. The ideal solution is to have the return type a uint64_t. This unfortunately requires an API change. 2. The only pathological behavior happens if both arguments are INT64_MIN, to the best of my knowledge. In such a case, the implementation defined behavior is invoked in the sense that UINT64_MAX is interpreted as INT64_MIN, which any reasonable implementation will do. In any case, any usage where both arguments are INT64_MIN is a fuzzer anyway. 3. Alternatives of checking, etc require branching and lose performance for no concrete gain - no client cares about av_gcd's actual value when both args are INT64_MIN. Even if it did, on sane platforms (e.g all the ones FFmpeg cares about), it produces a correct gcd, namely INT64_MIN. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is more concise and conveys the intent better. Furthermore, it is likely more precise as well due to lack of floating point division. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Andreas Cadhalpun authored
It is an internal swscale function and thus should not be exported. Reviewed-by:
Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
-
Andreas Cadhalpun authored
It is an internal swscale symbol and thus should not be exported. Reviewed-by:
-
Andreas Cadhalpun authored
They are not in public headers and not used outside of libavformat. Reviewed-by:
Hendrik Leppkes <h.leppkes@gmail.com> Signed-off-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. The expression has also been accordingly simplified. Reviewed-by:
-
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by:
-
