1. 12 Dec, 2019 2 commits
  2. 09 Aug, 2019 1 commit
    • Olivier Maignial's avatar
      avformat/rtpdec_mpeg4: Fix integer parameters size check in SDP fmtp line · c29d81e7
      Olivier Maignial authored
      === PROBLEM ===
      
      I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line:
          ffmpeg -v verbose -y -i "rtsp://<ip>/my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4
      
      FFmpeg then fail to record audio and output this logs:
          [rtsp @ 0xcda1f0] The profile-level-id field size is invalid (40)
          [rtsp @ 0xcda1f0] Error parsing AU headers
          ...
          [rtsp @ 0xcda1f0] Could not find codec parameters for stream 1 (Audio: aac, 48000 Hz, 1 channels): unspecified sample format
      
      In SDP provided by my RTSP server I had this fmtp line:
          a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188; sizeLength=13; indexLength=3; indexDeltaLength=3;
      
      In FFmpeg code, I found a check introduced by commit 24130234. It disallows values greater than 32 for fmtp line parameters.
      RFC-4566 (SDP: Session Description Protocol) do not give any limit of size on interger parameters given in an fmtp line.
      
      However, In RFC-6416 (RTP Payload Format for MPEG-4 Audio/Visual Streams) give examples of "profile-level-id" values for AAC, up to 55.
      
      === FIX ===
      
      As each parameter may have its own min and max values
      I propose to introduce a range for each parameter.
      For this patch I used RFC-3640 and ISO/IEC 14496-1 as reference for validity ranges.
      
      This patch fix my problem and I now can record my RTSP AAC stream to mp4.
      It has passed the full fate tests suite sucessfully.
      Signed-off-by: 's avatarOlivier Maignial <olivier.maignial@smile.fr>
      Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
      c29d81e7
  3. 14 Feb, 2018 1 commit
  4. 11 Feb, 2017 1 commit
  5. 07 Feb, 2017 1 commit
  6. 13 Jan, 2017 1 commit
  7. 21 Nov, 2016 1 commit
  8. 23 Aug, 2016 1 commit
  9. 04 May, 2016 1 commit
  10. 23 Feb, 2016 1 commit
    • Anton Khirnov's avatar
      lavf: replace AVStream.codec with AVStream.codecpar · 9200514a
      Anton Khirnov authored
      Currently, AVStream contains an embedded AVCodecContext instance, which
      is used by demuxers to export stream parameters to the caller and by
      muxers to receive stream parameters from the caller. It is also used
      internally as the codec context that is passed to parsers.
      
      In addition, it is also widely used by the callers as the decoding (when
      demuxer) or encoding (when muxing) context, though this has been
      officially discouraged since Libav 11.
      
      There are multiple important problems with this approach:
          - the fields in AVCodecContext are in general one of
              * stream parameters
              * codec options
              * codec state
            However, it's not clear which ones are which. It is consequently
            unclear which fields are a demuxer allowed to set or a muxer allowed to
            read. This leads to erratic behaviour depending on whether decoding or
            encoding is being performed or not (and whether it uses the AVStream
            embedded codec context).
          - various synchronization issues arising from the fact that the same
            context is used by several different APIs (muxers/demuxers,
            parsers, bitstream filters and encoders/decoders) simultaneously, with
            there being no clear rules for who can modify what and the different
            processes being typically delayed with respect to each other.
          - avformat_find_stream_info() making it necessary to support opening
            and closing a single codec context multiple times, thus
            complicating the semantics of freeing various allocated objects in the
            codec context.
      
      Those problems are resolved by replacing the AVStream embedded codec
      context with a newly added AVCodecParameters instance, which stores only
      the stream parameters exported by the demuxers or read by the muxers.
      9200514a
  11. 27 Jul, 2015 1 commit
  12. 24 Feb, 2015 7 commits
  13. 21 Feb, 2015 3 commits
  14. 14 Feb, 2015 1 commit
  15. 24 Dec, 2014 1 commit
  16. 15 Dec, 2014 1 commit
  17. 09 Jul, 2014 1 commit
  18. 13 Oct, 2013 1 commit
  19. 05 May, 2013 1 commit
  20. 20 Jan, 2013 2 commits
  21. 16 Jan, 2013 1 commit
  22. 15 Jan, 2013 1 commit
  23. 21 Dec, 2012 1 commit
  24. 12 Dec, 2012 1 commit
  25. 09 Oct, 2012 1 commit
  26. 07 Aug, 2012 1 commit
  27. 06 Jul, 2012 1 commit
  28. 08 Apr, 2012 1 commit
  29. 06 Feb, 2012 1 commit
  30. 28 Nov, 2011 1 commit