Commits · a08681f1e614152184615e2bcd71c3d63835f810 · Linshizhi / ffmpeg.wasm-core

05 Dec, 2015 21 commits

avcodec/dirac_parser: Check that there is a previous PU before accessing it · a08681f1

Michael Niedermayer authored Dec 05, 2015

Fixes out of array read
Fixes: 99d142c47e6ba3510a74b872a1a2ae72/asan_heap-oob_11b36f4_3811_0f5c69e7609a88a580135678de1df844.dxa

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

a08681f1

avcodec/dirac_parser: Add basic validity checks for next_pu_offset and prev_pu_offset · c7d6ec94
Michael Niedermayer authored Dec 05, 2015
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
c7d6ec94
avcodec/dirac_parser: Fix potential overflows in pointer checks · 79798f7c
Michael Niedermayer authored Dec 05, 2015
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
79798f7c
doc/encoders.texi: remove forgotten mention of "experimental" from libvo-aacenc · 49b82bc9
Rostislav Pehlivanov authored Dec 05, 2015
```
Previous documentation commit overlooked that particular mention.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
```
49b82bc9

aacenc: remove the experimental flag · d9791a86

Rostislav Pehlivanov authored Dec 05, 2015

Thiss commit removes the experimental flag from the native AAC Encoder
and thus makes it the default.

After a lot of work, done by myself and Claudio Freire, the quality of
this encoder rivals and surpasses libfdk_aac in some situations. The
encoder had instability issues earlier which prevented it from having
its experimental flag removed, however the last commits done by Claudio
removed the last known source of instability and solved a lot of
problems which were previously observed. The issues were caused by the
various coding tools interfering with the scalefactor indices. Thus,
with these problems solved, it should now be possible to declare this
encoder as the default and recommend that the users should use it
instead of others provided by external libraries, as it is both faster
and has a subjectively higher quality with selected tracks.
The encoder has still yet to be fine tuned for every possible audio file
type like music or voice, so it is hoped that with the experimental flag
removed the users should be able to provide feedback and make the
encoder better than the alternatives for every type of audio and at
every bitrate.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>

d9791a86

doc/encoders.texi: update documentation for the native AAC encoder · e34e3619

Rostislav Pehlivanov authored Dec 05, 2015

Since the next commit removes the experimental flag from the encoder
it's better to update the documentation which has been around in its
current form for as long as the encoder itself.
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>

e34e3619

aacenc: mark coders other than twoloop as experimental · b270ec9a

Rostislav Pehlivanov authored Dec 05, 2015

ANMR has some interesting things coming up but is currently not in a
shape fit for non-experimental usage. Same with "FAST".
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>

b270ec9a

aacenc: mark the "faac"-like coder for removal · 3a6e0208

Rostislav Pehlivanov authored Dec 05, 2015

This coder produces a much lower quality audio than the rest, is much
slower and is unstable. Hasn't been updated for a very long time as
well, hence it is more appropriate to remove it since it also depends on
a big burden of a code (the encode_window_bands_info function which is
just as old, just as unstable and bad and in no way modifiable or
fixable).
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>

3a6e0208

avfilter/af_stereotools: check s->length size · a525b844
Paul B Mahol authored Dec 05, 2015
```
Signed-off-by: Paul B Mahol <onemda@gmail.com>
```
a525b844

avcodec/wmaprodec: Check bits per sample to be within the range not causing integer overflows · 66e05f6f

Michael Niedermayer authored Dec 05, 2015

Fixes: 549d5aab1480d10f2a775ed90b0342f1/signal_sigabrt_7ffff6ae7cc9_5643_96bbb0cfe3e28be1dadfce1075016345.wma

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

66e05f6f

avcodec/utils: Fix overflow in get_bit_rates computations · 15d14ce4

Michael Niedermayer authored Dec 05, 2015

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

15d14ce4

avcodec/pcm: Fix overflow in bitrate computation · 2de8bfd2

Michael Niedermayer authored Dec 05, 2015

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

2de8bfd2

avcodec/wmaprodec: Fix overflow of cutoff · 0c56f830

Michael Niedermayer authored Dec 05, 2015

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

0c56f830

avformat/smacker: fix integer overflow with pts_inc · 7ed47e97

Michael Niedermayer authored Dec 05, 2015

Fixes: ce19e41f0ef1e52a23edc488faecdb58/asan_heap-oob_2504e97_4202_ffa0df1baed14022b9bfd4f8ac23d0cb.smk

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

7ed47e97

avfilter/codecview: reindent after previous commit · 3f46e7ba
Clément Bœsch authored Dec 05, 2015

3f46e7ba
avfilter/codecview: add QP support · 560d1e7b
Clément Bœsch authored Aug 31, 2015

560d1e7b

Merge commit '' · 3b0f63e1

Hendrik Leppkes authored Dec 05, 2015

* commit '9f57f134':
  configure: ObjC support
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

3b0f63e1

libavformat/mov.c: allow QuickTime metadata to come after traks · a16243a4

Neil Birkbeck authored Dec 04, 2015

QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed.
Signed-off-by: Neil Birkbeck <neil.birkbeck@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

a16243a4

ffmpeg: When streamcopying, only add the input seek position when copying timestamps. · 5b6c0fdb

Simon Thelen authored Nov 22, 2015

Using -ss as an input option shifts timestamps down by the seek, so it
doesn't have to be added to the recording time when checking whether to
stop.

Fixes #977
Signed-off-by: Simon Thelen <ffmpeg-dev@c-14.de>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

5b6c0fdb

AAC encoder: ANMR, avoid empty search ranges · 293c170f
Claudio Freire authored Dec 05, 2015
```
Avoid generating broken paths when some bands have an
empty search space.
```
293c170f

aaccoder: prevent crash of anmr coder · 7a4652dd

Andreas Cadhalpun authored Dec 04, 2015

If minq is negative, the range of sf_idx can be larger than
SCALE_MAX_DIFF allows, causing assertion failures later in
encode_scale_factors.
Reviewed-by: Claudio Freire <klaussfreire@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

7a4652dd

04 Dec, 2015 19 commits

swscale/utils: Fix for runtime error: left shift of negative value -1 · 325b5936

Michael Niedermayer authored Dec 04, 2015

Fixes: c106b36fa36db8ff8f3ed0c82be7bea2/asan_heap-oob_32699f0_6321_467b9a1d7e03d7cfd310b7e65dc53bcc.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

325b5936

avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int · 4f241988

Michael Niedermayer authored Dec 04, 2015

Fixes: b293a6479bb4b5286cff24d356bfd955/asan_generic_225c3c9_7819_cc526b657450c6cdef1371b526499626.mkv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

4f241988

mips: add p5600 core optimizations · 1a538a14

Vicente Olivert Riera authored Dec 03, 2015

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

1a538a14

mips: remove --mips32r5 configure option · c8419035

Vicente Olivert Riera authored Dec 03, 2015

Having a configure option with the same name as a MIPS ISA is confusing,
so better to remove it. This option was being used to add some
optimizations to a specific core (p5600). We will add the optimizations
just when the p5600 core has been detected, in a later patch.
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c8419035

avformat/flvdec: Fix left shift of 137 by 24 places cannot be represented in type int · ab7ff380

Michael Niedermayer authored Dec 04, 2015

Fixes: 3c857d4d90365731524716e6d051e43a/signal_sigsegv_7f4f59bcc29e_1386_20abd2c8e655cb9c75b24368e65fe3b1.flv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

ab7ff380

avformat/msf: Check channels when reading the header · 689a8674

Michael Niedermayer authored Dec 04, 2015

Fixes integer overflow
Fixes: 0c2625f236ced104d402b4a03c0d65c7/asan_generic_274e1ce_5990_9314e7a67c26aecf011b178ade9f217c.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

689a8674

avcodec/jpeg2000dec: Check bpno in decode_cblk() · a85b02dc

Michael Niedermayer authored Dec 04, 2015

Fixes: undefined shift
Fixes: c409ef86f892335a0a164b5871174d5a/asan_heap-oob_1dff564_2159_162b7234616deab02b544410455eb07b.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

a85b02dc

avfilter: add audio emphasis filter · 5d2cc00d
Paul B Mahol authored Nov 30, 2015
```
Signed-off-by: Paul B Mahol <onemda@gmail.com>
```
5d2cc00d
ffmpeg: enable echoing with command and debug modes · 7234e04e
Clément Bœsch authored Nov 19, 2015
```
Allow seeing text when pressing 'c' or 'd'.
```
7234e04e
avcodec/mpegvideo: use constants for rc_strategy · 60532348
Clément Bœsch authored Nov 21, 2015

60532348
swscale: use AV_OPT_TYPE_BOOL for {src,dst}_range options · 010caed2
Clément Bœsch authored Nov 21, 2015

010caed2
swresample: use AV_OPT_TYPE_BOOL for linear_interp and cheby options · c1f114a8
Clément Bœsch authored Nov 21, 2015

c1f114a8
avformat: use AV_OPT_TYPE_BOOL in a bunch of places · 43ecec0f
Clément Bœsch authored Nov 21, 2015

43ecec0f
avfilter: use AV_OPT_TYPE_BOOL in a bunch of places · 0e62b5d1
Clément Bœsch authored Nov 21, 2015

0e62b5d1
avcodec: use AV_OPT_TYPE_BOOL in a bunch of places · fb99ef0b
Clément Bœsch authored Nov 21, 2015

fb99ef0b

ffmdec: reject zero-sized chunks · a611375d

Andreas Cadhalpun authored Dec 02, 2015

If size is zero, avio_get_str fails, leaving the buffer uninitialized.
This causes invalid reads in av_set_options_string.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

a611375d

ffmdec: only seek back at EOF if a server is attached · 488e9a06

Andreas Cadhalpun authored Dec 02, 2015

Otherwise the ffm demuxer can return the same packets endlessly, if
there is no server attached.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

488e9a06

libavcodec/aacsbr_tablegen: fix tablegen on windows · 3c4e4918

Hendrik Leppkes authored Dec 02, 2015

Including these headers is not needed and breaks building on Windows as it
tries to activate the full compat tools, which are not needed for host
tools.

3c4e4918

avcodec: include tablegen compat header before the tablegen functionality · 42a9aead
Hendrik Leppkes authored Dec 02, 2015

42a9aead