Commits · 9fe07908c3f67d59cf4db5668d61b34506189590 · Linshizhi / ffmpeg.wasm-core

15 Dec, 2019 16 commits

avcodec/adpcm: Clip predictor for APC · 9fe07908

Michael Niedermayer authored Nov 21, 2019

Fixes: signed integer overflow: -2147483648 - 13 cannot be represented in type 'int'
Fixes: 18893/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_APC_fuzzer-5630760442920960

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

9fe07908

avcodec/targa: Check colors vs. available space · 01593278

Michael Niedermayer authored Nov 21, 2019

Fixes: Timeout (37sec -> 52ms)
Fixes: 18892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TARGA_fuzzer-5739537854889984

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

01593278

tools/target_dec_fuzzer: Adjust threshold for dst · 5a8877da

Michael Niedermayer authored Nov 23, 2019

Fixes: Timeout (400sec -> 14sec)
Fixes: 18989/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5175008116867072

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

5a8877da

avcodec/dstdec: Use get_ur_golomb_jpegls() · a76690c0

Michael Niedermayer authored Sep 30, 2019

Fixes: shift exponent -4 is negative
Fixes: 17793/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5766088435957760
Fixes: 18989/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5175008116867072

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a76690c0

avcodec/wmavoice: Check remaining input in parse_packet_header() · 19c41969

Michael Niedermayer authored Nov 23, 2019

Fixes: Infinite loop
Fixes: 18914/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-5731902946541568

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

19c41969

avcodec/wmalosslessdec: Fix 2 overflows in mclms · 92455c8c

Michael Niedermayer authored Nov 20, 2019

Fixes: signed integer overflow: 2038337026 + 109343477 cannot be represented in type 'int'
Fixes: 18886/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5673660505653248

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

92455c8c

avcodec/decode: Fix integer overflow in max_samples check · 6b7bcd43

Michael Niedermayer authored Nov 20, 2019

Fixes: signed integer overflow: 1677721600 * 32 cannot be represented in type 'int'
Fixes: 18885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5741242185154560

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

6b7bcd43

avcodec/wmaprodec: Fixes integer overflow with 32bit samples · a9cc69c0

Michael Niedermayer authored Nov 20, 2019

Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
Fixes: 18860/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAPRO_fuzzer-5755223125786624

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a9cc69c0

avcodec/adpcm: Fix invalid shift in xa_decode() · 50db30b4

Michael Niedermayer authored Nov 20, 2019

Fixes: left shift of negative value -1
Fixes: 18859/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_XA_fuzzer-5748474213040128

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

50db30b4

avcodec/wmavoice: Add FF_CODEC_CAP_INIT_CLEANUP · 5d0b3e28

Michael Niedermayer authored Nov 18, 2019

Fixes: memleaks
Fixes: 18855/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-5687647317524480

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

5d0b3e28

avcodec/wmalosslessdec: Fix several integer issues · ec3fe670

Michael Niedermayer authored Nov 18, 2019

Fixes: shift exponent -1 is negative (and others)
Fixes: 18852/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5660855295541248

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

ec3fe670

avcodec/wmalosslessdec: Check that padding bits is not more than sample bits · 9d428265

Michael Niedermayer authored Nov 18, 2019

Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
Fixes: 18817/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5713317180211200

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

9d428265

avcodec/iff: Skip overflowing runs in decode_delta_d() · 185f441b

Michael Niedermayer authored Nov 18, 2019

Fixes: Timeout (107sec - 75ms>
Fixes: 18812/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-6295585225441280

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

185f441b

avcodec/apedec: Set error on error in ape_decode_value_3860() · 2c2ee67f

Michael Niedermayer authored Nov 18, 2019

Fixes: Timeout (unknown -> 15sec)
Fixes: 18808/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5677586072207360

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

2c2ee67f

avcodec/pnm: Check that the header is not truncated · c94cb8d9

Michael Niedermayer authored Dec 14, 2019

Fixes: Ticket8430
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c94cb8d9

avcodec/mp3_header_decompress_bsf: Check sample_rate_index · f064c7c4

Michael Niedermayer authored Dec 13, 2019

Fixes: out of array read
Fixes: 19309/clusterfuzz-testcase-minimized-ffmpeg_BSF_MP3_HEADER_DECOMPRESS_fuzzer-5651002950942720

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

f064c7c4

14 Dec, 2019 6 commits

avfilter/x86/vf_interlace: always use unaligned movs · 1f8e4393

Marton Balint authored Dec 06, 2019

Fixes crashes in command lines such as:

ffmpeg -f lavfi -i testsrc2=704x576:r=50,interlace,pad=720:576:8 -f null none

Related to ticket #6491.
Signed-off-by: Marton Balint <cus@passwd.hu>

1f8e4393

avfilter/vf_interlace: do not interlace already interlaced frames · 4cd2cee7

Marton Balint authored Dec 06, 2019

The filter used to work this way before it was merged into tinterlace.
Signed-off-by: Marton Balint <cus@passwd.hu>

4cd2cee7

avfilter/vf_tinterlace: add support for bypassing already interlaced frames · 6498522b
Marton Balint authored Dec 06, 2019
```
The old interlace filter worked this way before it was merged with tinterlace.
Signed-off-by: Marton Balint <cus@passwd.hu>
```
6498522b

avfilter/vf_interlace: restore lowpass mode constants · 28b5dc61

Marton Balint authored Dec 06, 2019

The documentation still mentions numerical constants in addition to textual
ones. It is also wrong to use distinct modes as flags and it disallows us to
actually use the flags field for real flags in the future.
Signed-off-by: Marton Balint <cus@passwd.hu>

28b5dc61

lavu/pixfmt: Cosmetics, remove wrong end-of-comment markers. · 8b5ef2dc
Carl Eugen Hoyos authored Dec 14, 2019

8b5ef2dc
lavc/pnmdec: Fix 16bit decoding. · 19314348
Carl Eugen Hoyos authored Dec 13, 2019
```
Regression since cdb5479c
Reported by irc user tTh from Mixart-Myrys
```
19314348

13 Dec, 2019 7 commits

avcodec/simple_idct_template: fix integer overflow · 24424a65
Paul B Mahol authored Dec 13, 2019

24424a65

avcodec/cbs_av1_syntax_template: Check num_y_points · bbe27890

Michael Niedermayer authored Dec 11, 2019

"It is a requirement of bitstream conformance that num_y_points is less than or equal to 14."

Fixes: index 24 out of bounds for type 'uint8_t [24]'
Fixes: 19282/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_MERGE_fuzzer-5747424845103104

Note, also needs a23dd336

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: jamrial
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

bbe27890

convert_from_tensorflow.py: add support when kernel size is 1*1 with one... · e52070e8

Guo, Yejun authored Nov 22, 2019

convert_from_tensorflow.py: add support when kernel size is 1*1 with one input/output channel (gray image)
Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
Signed-off-by: Pedro Arthur <bygrandao@gmail.com>

e52070e8

avfilter/vf_dnn_processing: refine code for better naming · ed9fc2e3
Guo, Yejun authored Nov 22, 2019
```
Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
Signed-off-by: Pedro Arthur <bygrandao@gmail.com>
```
ed9fc2e3

fate/cbs: use the rawvideo muxer for AV1 tests · 54d09eb8

James Almer authored Dec 12, 2019

The IVF muxer autoinserts the av1_metadata filter unconditionally, which is
not desirable for these tests.
Signed-off-by: James Almer <jamrial@gmail.com>

54d09eb8

avfilter/vf_datascope: add decimal output · 824324db
Paul B Mahol authored Dec 13, 2019

824324db

configure: Check for the SetDllDirectory and GetModuleHandle functions · 06ec9c47

Martin Storsjö authored Dec 11, 2019

These functions aren't available when building for the restricted
UWP/WinRT/WinStore API subsets.

Normally when building in this mode, one is probably only building
the libraries, but being able to build ffmpeg.exe still is useful
(and a ffmpeg.exe targeting these API subsets still can be run
e.g. in wine, for testing).
Signed-off-by: Martin Storsjö <martin@martin.st>

06ec9c47

12 Dec, 2019 11 commits

checkasm: af_afir: Use a dynamic tolerance depending on values · f58bda64

Martin Storsjö authored Dec 11, 2019

As the values generated by av_bmg_get can be arbitrarily large
(only the stddev is specified), we can't use a fixed tolerance.
Calculate a dynamic tolerance (like in float_dsp from 38f966b2),
based on the individual steps of the calculation.

This fixes running this test with certain seeds, when built with
clang for mingw/x86_32.
Signed-off-by: Martin Storsjö <martin@martin.st>

f58bda64

avfilter: Fix type in av_log for random_seed in cellauto and life · 9d1f7870

Michael Niedermayer authored Dec 07, 2019

Fixes CID 1456556 / 1456555
Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

9d1f7870

avcodec/v210dec: move the stride read after its fully initialized · ab304436

Michael Niedermayer authored Dec 01, 2019

Fixes: out of array read
Fixes: 19129/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_V210_fuzzer-5068171023482880
Maybe fixes: 19130/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_V210_fuzzer-5637264407527424

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

ab304436

lavc/utils.c: fix code indentations · 7aef2f59

Linjie Fu authored Dec 11, 2019

Introduced since 4b4a02b8.
Signed-off-by: Linjie Fu <linjie.fu@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

7aef2f59

lavc/mips: simplify the switch code · bffb9326

Linjie Fu authored Dec 11, 2019

Signed-off-by: Linjie Fu <linjie.fu@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

bffb9326

avformat: Don't free old extradata before ff_alloc/get_extradata · 82d61a9c

Andreas Rheinhardt authored Dec 11, 2019

These functions already free it themselves before they allocate the new
extradata.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

82d61a9c

avformat: Forward errors where possible · c1e439d7

Andreas Rheinhardt authored Dec 10, 2019

It is not uncommon to find code where the caller thinks to know better
what the return value should be than the callee. E.g. something like
"if (av_new_packet(pkt, size) < 0) return AVERROR(ENOMEM);". This commit
changes several instances of this to instead forward the actual error.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c1e439d7

avformat/rtpdec_hevc: Don't reimplement ff_alloc_extradata · cb88cdf7

Andreas Rheinhardt authored Dec 10, 2019

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

cb88cdf7

avformat/apngdec: Don't free extradata manually · c1d300f8

Andreas Rheinhardt authored Dec 10, 2019

The extradata will be freed automatically when the corresponding stream
gets freed.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c1d300f8

avformat/apngdec: Make sure that extradata is zero-padded · 2e328a8a

Andreas Rheinhardt authored Dec 10, 2019

Zeroing the padding has been forgotten.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

2e328a8a

avformat/mov: Use ff_alloc_extradata for dvdsub extradata · 56ce2ad2

Andreas Rheinhardt authored Dec 10, 2019

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Reviewed-by: "mypopy@gmail.com" <mypopy@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

56ce2ad2