- 23 Mar, 2016 1 commit
-
-
Ganesh Ajjanagadde authored
No idea why in commit 01ecb717 the checks were removed; this can lead to NULL pointer dereferences. This effectively reverts that portion of the commit. Reviewed-by: Benoit Fouet <benoit.fouet@free.fr> Reviewed-by: Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by: Ganesh Ajjanagadde <gajjanag@gmail.com>
-
- 02 Dec, 2015 1 commit
-
-
Claudio Freire authored
This patch does 4 things, all of which interact and thus it woudln't be possible to commit them separately without causing either quality regressions or assertion failures. Fate comparison targets don't all reflect improvements in quality, yet listening tests show substantially improved quality and stability. 1. Increase SF range utilization. The spec requires SF delta values to be constrained within the range -60..60. The previous code was applying that range to the whole SF array and not only the deltas of consecutive values, because doing so requires smarter code: zeroing or otherwise skipping a band may invalidate lots of SF choices. This patch implements that logic to allow the coders to utilize the full dynamic range of scalefactors, increasing quality quite considerably, and fixing delta-SF-related assertion failures, since now the limitation is enforced rather than asserted. 2. PNS tweaks The previous modification makes big improvements in twoloop's efficiency, and every time that happens PNS logic needs to be tweaked accordingly to avoid it from stepping all over twoloop's decisions. This patch includes modifications of the sort. 3. Account for lowpass cutoff during PSY analysis The closer PSY's allocation is to final allocation the better the quality is, and given these modifications, twoloop is now very efficient at avoiding holes. Thus, to compute accurate thresholds, PSY needs to account for the lowpass applied implicitly during twoloop (by zeroing high bands). This patch makes twoloop set the cutoff in psymodel's context the first time it runs, and makes PSY account for it during threshold computation, making PE and threshold computations closer to the final allocation and thus achieving better subjective quality. 4. Tweaks to RC lambda tracking loop in relation to PNS Without this tweak some corner cases cause quality regressions. Basically, lambda needs to react faster to overall bitrate efficiency changes since now PNS can be quite successful in enforcing maximum bitrates, when PSY allocates too many bits to the lower bands, suppressing the signals RC logic uses to lower lambda in those cases and causing aggressive PNS. This tweak makes PNS much less aggressive, though it can still use some further tweaks. Also update MIPS specializations and adjust fuzz Also in lavc/mips/aacpsy_mips.h: remove trailing whitespace
-
- 11 Oct, 2015 2 commits
-
-
Claudio Freire authored
Reindent
-
Claudio Freire authored
This finalizes merging of the work in the patches in ticket #2686. Improvements to twoloop and RC logic are extensive. The non-exhaustive list of twoloop improvments includes: - Tweaks to distortion limits on the RD optimization phase of twoloop - Deeper search in twoloop - PNS information marking to let twoloop decide when to use it (turned out having the decision made separately wasn't working) - Tonal band detection and priorization - Better band energy conservation rules - Strict hole avoidance For rate control: - Use psymodel's bit allocation to allow proper use of the bit reservoir. Don't work against the bit reservoir by moving lambda in the opposite direction when psymodel decides to allocate more/less bits to a frame. - Retry the encode if the effective rate lies outside a reasonable margin of psymodel's allocation or the selected ABR. - Log average lambda at the end. Useful info for everyone, but especially for tuning of the various encoder constants that relate to lambda feedback. Psy: - Do not apply lowpass with a FIR filter, instead just let the coder zero bands above the cutoff. The FIR filter induces group delay, and while zeroing bands causes ripple, it's lost in the quantization noise. - Experimental VBR bit allocation code - Tweak automatic lowpass filter threshold to maximize audio bandwidth at all bitrates while still providing acceptable, stable quality. I/S: - Phase decision fixes. Unrelated to #2686, but the bugs only surfaced when the merge was finalized. Measure I/S band energy accounting for phase, and prevent I/S and M/S from being applied both. PNS: - Avoid marking short bands with PNS when they're part of a window group in which there's a large variation of energy from one window to the next. PNS can't preserve those and the effect is extremely noticeable. M/S: - Implement BMLD protection similar to the specified in ISO-IEC/13818:7-2003, Appendix C Section 6.1. Since M/S decision doesn't conform to section 6.1, a different method had to be implemented, but should provide equivalent protection. - Move the decision logic closer to the method specified in ISO-IEC/13818:7-2003, Appendix C Section 6.1. Specifically, make sure M/S needs less bits than dual stereo. - Don't apply M/S in bands that are using I/S Now, this of course needed adjustments in the compare targets and fuzz factors of the AAC encoder's fate tests, but if wondering why the targets go up (more distortion), consider the previous coder was using too many bits on LF content (far more than required by psy), and thus those signals will now be more distorted, not less. The extra distortion isn't audible though, I carried extensive ABX testing to make sure. A very similar patch was also extensively tested by Kamendo2 in the context of #2686.
-
- 31 May, 2015 1 commit
-
-
Vittorio Giovara authored
-
- 14 Oct, 2014 2 commits
-
-
Michael Niedermayer authored
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
Michael Niedermayer authored
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
- 13 Apr, 2014 1 commit
-
-
Michael Niedermayer authored
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
- 30 Jun, 2013 1 commit
-
-
Carl Eugen Hoyos authored
Fixes ticket #2732.
-
- 20 Mar, 2013 1 commit
-
-
Bojan Zivkovic authored
Signed-off-by: Bojan Zivkovic <bojan@mips.com> Reviewed-by: Nedeljko Babic <Nedeljko.Babic@imgtec.com> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
- 07 Mar, 2013 1 commit
-
-
Michael Niedermayer authored
The IIR filter numerically diverges in such cases, this could easily be fixed but would make the filter slower on some platforms Fixes Ticket2246 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
- 15 Aug, 2012 1 commit
-
-
Martin Storsjö authored
Signed-off-by: Martin Storsjö <martin@martin.st>
-
- 07 Aug, 2012 1 commit
-
-
Anton Khirnov authored
-
- 29 Jul, 2012 1 commit
-
-
Michael Niedermayer authored
Improves subjective quality Formula and testing by: kamedo2 <fujisakihir90@yahoo.co.jp> Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-
- 28 Jan, 2012 1 commit
-
-
Alex Converse authored
-
- 23 Jan, 2012 2 commits
-
-
Nathan Caldwell authored
Signed-off-by: Alex Converse <alex.converse@gmail.com>
-
Nathan Caldwell authored
Signed-off-by: Alex Converse <alex.converse@gmail.com>
-
- 29 Jun, 2011 1 commit
-
-
Nathan Caldwell authored
-
- 08 May, 2011 1 commit
-
-
Nathan Caldwell authored
Instead use the function pointers directly.
-
- 19 Mar, 2011 1 commit
-
-
Mans Rullgard authored
Signed-off-by: Mans Rullgard <mans@mansr.com>
-
- 21 Jan, 2011 2 commits
-
-
Justin Ruggles authored
Signed-off-by: Mans Rullgard <mans@mansr.com> (cherry picked from commit 75b98610)
-
Justin Ruggles authored
Signed-off-by: Mans Rullgard <mans@mansr.com> (cherry picked from commit d42dc217)
-
- 20 Jan, 2011 2 commits
-
-
Justin Ruggles authored
Signed-off-by: Mans Rullgard <mans@mansr.com>
-
Justin Ruggles authored
Signed-off-by: Mans Rullgard <mans@mansr.com>
-
- 30 Aug, 2010 1 commit
-
-
Alex Converse authored
Originally committed as revision 24999 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
- 10 Jul, 2010 1 commit
-
-
Martin Storsjö authored
Originally committed as revision 24159 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
- 28 Jun, 2010 2 commits
-
-
Alex Converse authored
Originally committed as revision 23868 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
Alex Converse authored
Originally committed as revision 23867 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
- 02 Apr, 2010 1 commit
-
-
Alex Converse authored
The heuristic for estimating a good cutoff is busted. Originally committed as revision 22779 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
- 14 Jul, 2009 1 commit
-
-
Alex Converse authored
Originally committed as revision 19429 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
- 08 Jul, 2009 4 commits
-
-
Diego Biurrun authored
move statements after if/for to the next line. Originally committed as revision 19378 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
Diego Biurrun authored
Originally committed as revision 19377 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
Alex Converse authored
Originally committed as revision 19376 to svn://svn.ffmpeg.org/ffmpeg/trunk
-
Alex Converse authored
Originally committed as revision 19375 to svn://svn.ffmpeg.org/ffmpeg/trunk
-