- 03 Apr, 2018 1 commit
-
-
wm4 authored
PSEUDOPAL pixel formats are not paletted, but carried a palette with the intention of allowing code to treat unpaletted formats as paletted. The palette simply mapped the byte values to the resulting RGB values, making it some sort of LUT for RGB conversion. It was used for 1 byte formats only: RGB4_BYTE, BGR4_BYTE, RGB8, BGR8, GRAY8. The first 4 are awfully obscure, used only by some ancient bitmap formats. The last one, GRAY8, is more common, but its treatment is grossly incorrect. It considers full range GRAY8 only, so GRAY8 coming from typical Y video planes was not mapped to the correct RGB values. This cannot be fixed, because AVFrame.color_range can be freely changed at runtime, and there is nothing to ensure the pseudo palette is updated. Also, nothing actually used the PSEUDOPAL palette data, except xwdenc (trivially changed in the previous commit). All other code had to treat it as a special case, just to ignore or to propagate palette data. In conclusion, this was just a very strange old mechnaism that has no real justification to exist anymore (although it may have been nice and useful in the past). Now it's an artifact that makes the API harder to use: API users who allocate their own pixel data have to be aware that they need to allocate the palette, or FFmpeg will crash on them in _some_ situations. On top of this, there was no API to allocate the pseuo palette outside of av_frame_get_buffer(). This patch not only deprecates AV_PIX_FMT_FLAG_PSEUDOPAL, but also makes the pseudo palette optional. Nothing accesses it anymore, though if it's set, it's propagated. It's still allocated and initialized for compatibility with API users that rely on this feature. But new API users do not need to allocate it. This was an explicit goal of this patch. Most changes replace AV_PIX_FMT_FLAG_PSEUDOPAL with FF_PSEUDOPAL. I first tried #ifdefing all code, but it was a mess. The FF_PSEUDOPAL macro reduces the mess, and still allows defining FF_API_PSEUDOPAL to 0. Passes FATE with FF_API_PSEUDOPAL enabled and disabled. In addition, FATE passes with FF_API_PSEUDOPAL set to 1, but with allocation functions manually changed to not allocating a palette.
-
- 18 Mar, 2018 2 commits
-
-
wm4 authored
This adds a way for an API user to transfer QP data and metadata without having to keep the reference to AVFrame, and without having to explicitly care about QP APIs. It might also provide a way to finally remove the deprecated QP related fields. In the end, the QP table should be handled in a very similar way to e.g. AV_FRAME_DATA_MOTION_VECTORS. There are two side data types, because I didn't care about having to repack the QP data so the table and the metadata are in a single AVBufferRef. Otherwise it would have either required a copy on decoding (extra slowdown for something as obscure as the QP data), or would have required making intrusive changes to the codecs which support export of this data. The new side data types are added under deprecation guards, because I don't intend to change the status of the QP export as being deprecated (as it was before this patch too).
-
wm4 authored
Everything related to the QP data is deprecated, with qp_table_buf being an inconsistent exception. Some parts were under the deprecation guards, some not. It probably didn't even compile.
-
- 01 Mar, 2018 1 commit
-
-
Rostislav Pehlivanov authored
Signed-off-by:
Rostislav Pehlivanov <atomnuker@gmail.com>
-
- 10 Nov, 2017 1 commit
-
-
Michael Niedermayer authored
This gives FFmpeg libs a field that they can freely and safely use. Avoiding the need of wrapping of a users opaque_ref field and its issues. Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 29 Oct, 2017 1 commit
-
-
James Almer authored
The fields can be accessed directly, so these are not needed anymore. Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 23 Oct, 2017 1 commit
-
-
James Almer authored
Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 08 Aug, 2017 1 commit
-
-
wm4 authored
Signed-off-by:
Anton Khirnov <anton@khirnov.net> Merged from Libav commit 47399ccd.
-
- 26 Jul, 2017 2 commits
-
-
wm4 authored
Signed-off-by:
Anton Khirnov <anton@khirnov.net>
-
James Almer authored
Reviwed-by:
Rostislav Pehlivanov <atomnuker@gmail.com> Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 06 Apr, 2017 1 commit
-
-
Steve Lhomme authored
As found in HEVC. Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 03 Mar, 2017 1 commit
-
-
Michael Niedermayer authored
Found a case where we use size==0, the other related commits remain needed, and should be sufficient to fix the original issue This reverts commit 7e4f32f4. Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Feb, 2017 2 commits
-
-
Michael Niedermayer authored
There should be no case that needs this and its a potential for creating corner cases Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
The size 0 special case causes side data to be created which is different and a special case if for any reasons size = 0 is passed Fixes: multiple runtime error: null pointer passed as argument 1, which is declared to never be null Fixes: 653/clusterfuzz-testcase-5773837415219200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 13 Feb, 2017 1 commit
-
-
wm4 authored
This is an extended version of the AVFrame.opaque field, which can be used to attach arbitrary user information to an AVFrame. The usefulness of the opaque field is rather limited, because it can store only up to 32 bits of information (or 64 bit on 64 bit systems). It's not possible to set this field to a memory allocation, because there is no way to deallocate it correctly. The opaque_ref field circumvents this by letting the user set an AVBuffer, which makes the user data refcounted. Signed-off-by:
Anton Khirnov <anton@khirnov.net> Merges Libav commit 04f3bd34.
-
- 11 Feb, 2017 2 commits
-
-
wm4 authored
This is an extended version of the AVFrame.opaque field, which can be used to attach arbitrary user information to an AVFrame. The usefulness of the opaque field is rather limited, because it can store only up to 32 bits of information (or 64 bit on 64 bit systems). It's not possible to set this field to a memory allocation, because there is no way to deallocate it correctly. The opaque_ref field circumvents this by letting the user set an AVBuffer, which makes the user data refcounted. Signed-off-by:
Anton Khirnov <anton@khirnov.net>
-
Anton Khirnov authored
This will avoid every caller from hardcoding some specific alignment, which may break in the future with new instruction sets.
-
- 30 Jan, 2017 1 commit
-
-
Marton Balint authored
I wonder how unknown layouts ever worked without this? Reviewed-by:
Nicolas George <george@nsup.org> Reviewed-by:
Hendrik Leppkes <h.leppkes@gmail.com> Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
Marton Balint <cus@passwd.hu>
-
- 12 Jan, 2017 1 commit
-
-
Anton Khirnov authored
Extend the width/height doxy to clarify that it should store coded values.
-
- 16 Nov, 2016 2 commits
-
-
Michael Niedermayer authored
Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
Michael Niedermayer authored
Fixes null pointer dereference Fixes: 189/FOO Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpegSigned-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 19 Sep, 2016 1 commit
-
-
Sasi Inguva authored
Signed-off-by:
Sasi Inguva <isasi@google.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Jul, 2016 1 commit
-
-
James Almer authored
The accessors are needed only from outside libavutil. Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 21 Jun, 2016 1 commit
-
-
Anton Khirnov authored
Currently it's exported as AVFrame.pkt_pts, which is also the only use for that field. The reason it is done like this is that lavc used to export various codec-specific "timing" information in AVFrame.pts, which is not done anymore. Since it is confusing to the callers to have a separate field which is used only for decoder timestamps and nothing else, deprecate pkt_pts and use just AVFrame.pts everywhere.
-
- 05 Jun, 2016 1 commit
-
-
Michael Niedermayer authored
This should detect caes where these functions are called in unclean destinations
-
- 18 Feb, 2016 1 commit
-
-
Diego Biurrun authored
-
- 14 Feb, 2016 1 commit
-
-
Anton Khirnov authored
-
- 13 Feb, 2016 1 commit
-
-
Michael Niedermayer authored
Fixes memleak Fixes: Ticket4899 Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 01 Feb, 2016 1 commit
-
-
Derek Buitenhuis authored
Signed-off-by:
Derek Buitenhuis <derek.buitenhuis@gmail.com>
-
- 27 Jan, 2016 1 commit
-
-
Derek Buitenhuis authored
Libav, for some reason, merged this as a public API function. This will aid in future merges. A define is left for backwards compat, just in case some person used it, since it is in a public header. Signed-off-by:
Derek Buitenhuis <derek.buitenhuis@gmail.com>
-
- 22 Jan, 2016 1 commit
-
-
Neil Birkbeck authored
Add names for recently added enums to av_frame_side_data_name. Signed-off-by:
Neil Birkbeck <neil.birkbeck@gmail.com> Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 11 Jan, 2016 1 commit
-
-
Clément Bœsch authored
Signed-off-by:
Vittorio Giovara <vittorio.giovara@gmail.com>
-
- 08 Dec, 2015 1 commit
-
-
Clément Bœsch authored
-
- 30 Sep, 2015 1 commit
-
-
Vittorio Giovara authored
These field are difficult to interpret, and are provided by a single encoder (mpegvideoenc). In general they do not belong to a structure containing raw data only, so remove them from AVFrame. Mpegvideoenc now uses a private field in Picture for its internal computations. Signed-off-by:
Vittorio Giovara <vittorio.giovara@gmail.com>
-
- 05 Sep, 2015 1 commit
-
-
Hendrik Leppkes authored
These fields are still used, removal postponed until a replacement functionality is available.
-
- 22 Aug, 2015 1 commit
-
-
Andreas Cadhalpun authored
Reviewed-by:
wm4 <nfxjfg@googlemail.com> Signed-off-by:
Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
-
- 13 Jul, 2015 1 commit
-
-
Michael Niedermayer authored
Fixes: af94b3a3d26586c08f557cafe8246251_signal_sigsegv_7ffff713351a_343_XFMode.ASF with 2097152 alloc limit Found-by: Samuel Groß, Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by:
Michael Niedermayer <michael@niedermayer.cc>
-
- 25 Mar, 2015 2 commits
-
-
Ronald S. Bultje authored
Signed-off-by:
Michael Niedermayer <michaelni@gmx.at>
-
Ronald S. Bultje authored
Preparation for following patch. Signed-off-by:
Michael Niedermayer <michaelni@gmx.at>
-
- 18 Dec, 2014 1 commit
-
-
Luca Barbato authored
And make sure the nb_side_data field is reset as well. Based on an initial patch from wm4 <nfxjfg@googlemail.com>. CC: libav-stable@libav.org
-