Signed-off-by: Martin Storsjö <martin@martin.st>

CC: libav-stable@libav.org
Bug-Id: CID 732242

CC: libav-stable@libav.org
Bug-Id: CID 718141

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Currently, only onMetaData is used, but some providers (wrongly)
put metadata into onCuePoint events, and it's still nice to be
able to use that data.

onCuePoint events also present metadata slightly differently than
onMetaData events: all metadata is found inside an object called
"parameters". In order to extract this metadata, it's easiest to
recurse through the object tree and pull out anything found in
child objects and put it in the top-level metadata.

Reference: http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/2/help.html?content=00001404.htmlSigned-off-by: Anton Khirnov <anton@khirnov.net>

And leverage the video index if the video is just disabled as wm4
did in an initial patch.

If no streams were indicated in the FLV header, do not automatically
allocate by default a video and an audio stream. Instead, in the case
that the header did not indicate the presence of any data, allocate no
stream until data actually arrives for one type.
Signed-off-by: Martin Storsjö <martin@martin.st>

Some applications really mean to send negative pts.

No point in sending the message multiple time.

Messages should start with a capital letter and possibly end with a "."
if they are statements.

The Omnia A/XE encoder writes the explicit extra data incorrectly
and wrongly disables parametric stereo. Truncating the extra data
by setting the size to 2 works around this. The AAC extra data
parser will then only parse the correct parts.

Bug-id: 599

Certain streaming servers do not preserve the order of the fields.

It is used internally.

This is needed in order for the FLV demuxer not to detect a codec change when
using the "flv_metadata" option.

The callers of this function can't report errors sanely. If this
one malloc fails, don't write the extradata byte, make sure we
try to malloc it the next time we're called instead, and make sure
we still consume the input data byte.

CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>

This header byte is only present when actually reading a VP6 frame,
not when reading the codec type field in the metadata. This
potential bug has been present since 5b54a90c.

CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>

New streams may be created at any time, e.g. on codec change.

Signed-off-by: Martin Storsjö <martin@martin.st>

We match streams by codec id now.

This avoids creating new AVStreams for them when switching between
different variants of them, since we can handle changes between
different sample rates of nellymoser within the same stream.
Signed-off-by: Martin Storsjö <martin@martin.st>

In certain conditions video or audio frames might appear way later in the
stream.

Codec change midstream gets mapped to a separate stream.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Adobe specifies onTextData as the standard message to use to deliver
text information.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

The sample_rate variable is used for checks for audio format
changes at the end of the function.

This fixes cases where the sample rate was set from the codec
id by flv_set_audio_codec (as for nellymoser 8 kHz/16 kHz),
so the value set to last_sample_rate wasn't equal to sample_rate
at this point. This caused the demuxer otherwise reports a spurious
change to 5512 Hz and back to the correct one.

Updating channels in the same way is only done for consistency.
Currently, flv_set_audio_codec doesn't update that value.
Signed-off-by: Martin Storsjö <martin@martin.st>

Also add missing trailing commas, break long codec_tag lines and
add spaces in codec_tag declarations.
Signed-off-by: Martin Storsjö <martin@martin.st>

The index validation identifies these indexes as broken.
Signed-off-by: Martin Storsjö <martin@martin.st>

By validating the index entries while reading, we don't need to
seek at startup to validate the entries. If the error in the
index entries is not pointing to (our definition of) the start
of packets, and there is an index entry pointing at some of the
first packets after the metadata, the invalid index can be discarded
almost immediately.
Signed-off-by: Martin Storsjö <martin@martin.st>

Signed-off-by: Martin Storsjö <martin@martin.st>