- 30 Oct, 2015 9 commits
-
-
Ganesh Ajjanagadde authored
ISO C restricts enumerator values to the range of int. Thus (for instance) 0x80000000 unfortunately does not work, and throws a warning with -Wpedantic on clang 3.7. This fixes it by using alternative expressions that result in identical values but do not have this issue. Tested with FATE. Reviewed-by:
Ronald S. Bultje <rsbultje@gmail.com> Reviewed-by:
Michael Niedermayer <michael@niedermayer.cc> Signed-off-by:
Ganesh Ajjanagadde <gajjanagadde@gmail.com>
-
Ganesh Ajjanagadde authored
Current code is fine, this just adds robustness. Reviewed-by:
-
Ganesh Ajjanagadde authored
av_gcd is now always defined regardless of input. This documents this change in the "documented API". Two benefits (closely related): 1. The function is robust, and there is no need to worry about INT64_MIN, etc. 2. Clients of av_gcd, like av_reduce, can now be made fully correct. Currently, av_reduce can trigger undefined behavior if e.g num is INT64_MIN due to integer overflow in the FFABS. Furthermore, this undefined behavior is completely undocumented, and could be a fuzzer's paradise. The FFABS was needed in the past as av_gcd was undefined for negative inputs. In order to make av_reduce robust, it is essential to guarantee that av_gcd works for all int64_t. Reviewed-by:
-
Nicolas George authored
Fix a segfault when no encoder is found for a default codec with a complex filter graph.
-
Steven Robertson authored
Signed-off-by:
Steven Robertson <steven@strobe.cc> Reviewed-by:
Paul B Mahol <onemda@gmail.com> Signed-off-by:
-
Michael Niedermayer authored
Signed-off-by: -
Michael Niedermayer authored
Fixes regression with iJi.ogv Signed-off-by: -
Carl Eugen Hoyos authored
QT ignores the value written in the frame header. Issue reported by forum user Koracas.
-
Carl Eugen Hoyos authored
-
- 29 Oct, 2015 31 commits
-
-
Ganesh Ajjanagadde authored
This ensures that no undefined behavior is invoked, while retaining identical return values in all cases and at no loss of performance (identical asm on clang and gcc). Essentially, this patch exchanges undefined behavior with implementation defined behavior, a strict improvement. Rationale: 1. The ideal solution is to have the return type a uint64_t. This unfortunately requires an API change. 2. The only pathological behavior happens if both arguments are INT64_MIN, to the best of my knowledge. In such a case, the implementation defined behavior is invoked in the sense that UINT64_MAX is interpreted as INT64_MIN, which any reasonable implementation will do. In any case, any usage where both arguments are INT64_MIN is a fuzzer anyway. 3. Alternatives of checking, etc require branching and lose performance for no concrete gain - no client cares about av_gcd's actual value when both args are INT64_MIN. Even if it did, on sane platforms (e.g all the ones FFmpeg cares about), it produces a correct gcd, namely INT64_MIN. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is more concise and conveys the intent better. Furthermore, it is likely more precise as well due to lack of floating point division. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Andreas Cadhalpun authored
It is an internal swscale function and thus should not be exported. Reviewed-by:
Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
-
Andreas Cadhalpun authored
It is an internal swscale symbol and thus should not be exported. Reviewed-by:
-
Andreas Cadhalpun authored
They are not in public headers and not used outside of libavformat. Reviewed-by:
Hendrik Leppkes <h.leppkes@gmail.com> Signed-off-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. Reviewed-by:
-
Ganesh Ajjanagadde authored
This is likely more precise and conveys the intent better. The expression has also been accordingly simplified. Reviewed-by:
-
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Paul B Mahol authored
Signed-off-by: -
Kyle Swanson authored
Signed-off-by:
Kyle Swanson <k@ylo.ph> Reviewed-by:
-
Kyle Swanson authored
Signed-off-by:
Nicolas George <george@nsup.org> Signed-off-by:
-
Hendrik Leppkes authored
* commit '8edaf625': libopenh264enc: Count and warn about the number of skipped frames Merged-by:
-
Hendrik Leppkes authored
* commit '9e14a992': libopenh264enc: Add an option for controlling the frame skipping Merged-by:
-
Hendrik Leppkes authored
* commit 'b8deb7c3': opus: Do not call vector_fmul_scalar on zero samples Merged-by:
-
Hendrik Leppkes authored
* commit '6dcd8229': opus: Buffer the samples from the correct offset Merged-by:
-
Hendrik Leppkes authored
* commit 'f3aff31e': avpicture: Deprecate the single fields Merged-by:
-
Hendrik Leppkes authored
* commit 'cd0e0881': avconv: support infinite loop for the loop option Merged-by:
-
Hendrik Leppkes authored
* commit 'a9a60106': avpacket: Provide an alloc and a free function for the struct Merged-by:
-
Hendrik Leppkes authored
* commit '9b56d5c1': avpacket: Deprecate av_dup_packet Merged-by:
-
Hendrik Leppkes authored
* commit 'd584533c': avformat: Rework add_to_pktbuf Merged-by:
-
Ronald S. Bultje authored
For the 10-show-existing-frame, the source file indeed has a timestamp of 3 (or 100/33) for the second visible frame, so the fix appears to work correctly. For the other, only the timebase is fixed, but again appears to be correct now.
-
Matthieu Bouron authored
-
