Regression introduced in 598f7d04.
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

warning: assigning to 'AVFrame *' (aka 'struct AVFrame *') from
         'const AVFrame *' (aka 'const struct AVFrame *') discards
         qualifiers [-Wincompatible-pointer-types-discards-qualifiers]

Initialize `diff` to 0.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

And notify why the capture is impossible.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

It now has a fixed size and is initialized only once, so there is no
point in allocating it separately.

There is no real need to handle the init case specially, everything
necessary is initialized in the reinit code as well.

It is only used to decide whether to call free_tables(), but that
function is safe to call on an uninitialized context as well.

With frame threading, it is currently only updated in the context where
the change occurs, but not in any other contexts.

It does not make sense to copy is_avc without copying this as well. This
patch should not change anything for now, but will have an effect in
later commits.

It does not logically belong in free_tables(), since it's not allocated
in alloc_tables() and its size has nothing to do with the frame size.

That function currently does two things -- reinitializing the DSP
contexts and setting low_delay based on the SPS values.

The former more appropriately belongs in h264_slice_header_init(), while
the latter only really makes sense in decode_slice_header().

The third call to ff_h264_set_parameter_from_sps(), done immediately
after parsing a new SPS, appears to serve no useful purpose, so it is
just dropped.

Also, drop now unneeded H264Context.cur_chroma_format_idc.

It uses some fields from the SPS, which is not yet set where the reinit
is called currently.

Currently, the DPB is initialized in alloc_tables() and uninitialized in
free_tables(), but those functions manage frame size-dependent
variables, so DPB management does not logically belong in there.

Since we want the init/uninit to happen exactly once per the context
lifetime, init_context()/free_context() are the proper place for this
code.

It is only set, but never used for anything.

It is not needed anymore since switching to refcounted frames.

Fixes the corner case in which the internal buffer size
is larger than input buffer provided and resizing it
before moving the left over samples would make it write
to now unallocated memory.

Bug-Id: 825
CC: libav-stable@libav.org
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

If a PAT is finished while a PMT section filter is opened but
not yet finished, the PMT section filter is closed and all
the received data is discarded.

This is usually not an issue but some multiplexers (With very
quick PAT/PMT repetition settings) consistently emit a PMT
section start, then a PAT, and then the rest of the PMT,
causing the aforementioned behavior to result in no PMT being
finished.

In the most pathologic situation the stream information are lost
and the probe fallback miscategorizes subtitles as mp3 audio.

Avoid the issue through eliminating redundant PSI/SI table
updates by checking their version field, which is required by
the standard to be incremented on every change no matter how
minor.

CC: libav-stable@libav.org
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Fixes a memory leak on init failure.

Convert exisiting free functions to av_freep() to avoid accidental
double frees, and always intialize all buffers to NULL.

This avoids allocating/freeing memory at every function call,
checking its return value, and carrying the error around.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

This takes care of memory leaks on init error.

This takes care of memory leaks on init error.

The table had a wrong table height and was missing the first line of bytes.
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Improves Coverity analysis, avoiding "double semicolon" CIDs.

CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>

This fixes the calculation of the number of needed blocks to make
sure that ALL pixels are represented by the result.
Signed-off-by: Martin Storsjö <martin@martin.st>