- 05 Aug, 2018 1 commit
-
-
Aman Gupta authored
Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
- 03 Aug, 2018 1 commit
-
-
Aman Gupta authored
This code came originally from gstreamer, where it was added in [1] as a work-around for the Tegra 3. (The alignment was changed in [2] as a response to [3], from 32-bit to 16-bit). gstreamer only used this workaround in the case where the decoder didn't return a slice-height property, but when the code was copied into avcodec the conditional got lost. This commit restores the guard and prefers the slice-height from the decoder when it is available. This fixes segfaults decoding 1920x1080 h264 and mpeg2 videos on the NVidia SHIELD after upgrading to Android Oreo. [1] https://github.com/GStreamer/gst-plugins-bad/commit/a870e6a5c30dd85240fe75c7409cc1cf1b86541d [2] https://github.com/GStreamer/gst-plugins-bad/commit/21ff3ae0b0127bd82951d278ca24f2d54133b7cd [3] https://bugzilla.gnome.org/show_bug.cgi?id=748867Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
- 18 Jun, 2018 1 commit
-
-
Aman Gupta authored
@xyz reported a regression on his Sony Xperia Z3 Tablet Compact where playback would intermittently fail to start, essentially deadlocking in the decoder. Bisecting narrowed down the issue to this commit, which was meant as an optimization but is not necessary. This reverts commit a75bb549. Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
- 04 May, 2018 2 commits
-
-
Aman Gupta authored
The output_buffer_count==0 special case is no longer required, and can cause spurious EAGAIN to surface to the user when input buffers are filled up. Since the caller now knows if the decoder is accepting new input (via current_input_buffer>=0), let the wait parameter control whether we block or not. Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
Aman Gupta authored
The new logic follows a recommendation by @rcombs to use dequeueInputBuffer with a timeout of 0 as a way to detect whether the codec wants more data. The dequeued buffer index is kept in MediaCodecDecContext until it can be used next. A similar technique is also used by the Google's official media player Exoplayer: see MediaCodecRenderer.feedInputBuffer(). Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 25 Apr, 2018 3 commits
-
-
Aman Gupta authored
Also fixes a bug where EOS buffer was sent with incorrect pts when not using surface generation. Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com> Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
Aman Gupta authored
Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com> Signed-off-by:
Jan Ekström <jeebjp@gmail.com> Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
Aman Gupta authored
As of 2a0eb868, ff_mediacodec_dec_is_flushing() only returns true in delay_flush mode. Make this more obvious by adding delay_flush to the if statement. Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com> Signed-off-by:
Aman Gupta <aman@tmm1.net>
-
- 19 Apr, 2018 1 commit
-
-
Matthieu Bouron authored
Fixes decoding on the Samsung Chromebook Pro which do not set the codec output format stride and slice-height fields.
-
- 20 Mar, 2018 1 commit
-
-
Aman Gupta authored
Allows consumers who are converting hardware buffers to OpenGL textures to render the frames at the intended display resolution. Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Derek Buitenhuis <derek.buitenhuis@gmail.com>
-
- 12 Mar, 2018 2 commits
-
-
Matthieu Bouron authored
Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
Aman Gupta authored
Some Android devices are very finicky about how quicky output buffers are returned back to the decoder, especially when they are associated with a Surface. This commit adds a new counter that keeps track of exactly how many hw output buffers are being retained by the user, along with DEBUG level logging that makes it easy to track the lifecycle of these buffers. Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 08 Mar, 2018 2 commits
-
-
Aman Gupta authored
Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
Aman Gupta authored
The default behavior of the mediacodec decoder before this commit was to delay flushes until all pending hardware frames were returned to the decoder. This was useful for certain types of applications, but was unexpected behavior for others. The new default behavior with this commit is now to execute flushes immediately to invalidate all pending frames. The old behavior can be enabled by setting delay_flush=1. With the new behavior, video players implementing seek can simply call flush on the decoder without having to worry about whether they have one or more mediacodec frames still buffered in their rendering pipeline. Previously, all these frames had to be explictly freed (or rendered) before the seek/flush would execute. The new behavior matches the behavior of all other lavc decoders, reducing the amount of special casing required when using the mediacodec decoder. Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 06 Mar, 2018 1 commit
-
-
Aman Gupta authored
Signed-off-by:
Aman Gupta <aman@tmm1.net> Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 03 Mar, 2018 3 commits
-
-
Matthieu Bouron authored
-
Matthieu Bouron authored
-
Matthieu Bouron authored
-
- 19 Feb, 2018 1 commit
-
-
Aman Gupta authored
This refactor splits up the main mediacodec decode loop into two send/receive helpers, which are then used to rewrite the receive_frame callback and take full advantage of the new decoding api. Since we can now request packets on demand with ff_decode_get_packet(), the fifo buffer is no longer necessary and has been removed. This change was motivated by behavior observed on certain Android TV devices, featuring hardware mpeg2/h264 decoders which also deinterlace content (to produce multiple frames per field). Previously, this code caused buffering issues because queueInputBuffer() was always invoked before each dequeueOutputBuffer(), even though twice as many output buffers were being generated. With this patch, the decoder will always attempt to drain new frames first before sending more data into the underlying codec. Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 15 Dec, 2017 1 commit
-
-
Aman Gupta authored
Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 26 Nov, 2017 1 commit
-
-
Mark Thompson authored
They are now unused.
-
- 03 Jul, 2017 2 commits
-
-
Aman Gupta authored
Replicates the logic used in the wrap_hw_buffer path to wrap_sw_buffer as well. Fixes decoding issues observed on AMLogic devices with OMX.amlogic.mpeg2.decoder.awesome, where the decoder would spit out a constant stream of "mPtsRecoveryCount" errors and decoded frames were returned in the incorrect order. Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
Aman Gupta authored
Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 08 Jun, 2017 1 commit
-
-
Aman Gupta authored
Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. Signed-off-by:
Matthieu Bouron <matthieu.bouron@gmail.com>
-
- 23 Mar, 2017 1 commit
-
-
James Almer authored
Reviewed-by:
wm4 <nfxjfg@googlemail.com> Signed-off-by:
James Almer <jamrial@gmail.com>
-
- 19 Oct, 2016 3 commits
-
-
Matthieu Bouron authored
Adds the following changes: * mediacodecdec.{c,h} -> mediacodecdec_common.{c,h} * mediacodecdec_h2645.c -> mediacodecdec.c
-
Matthieu Bouron authored
-
Matthieu Bouron authored
-
- 12 Oct, 2016 2 commits
-
-
Matthieu Bouron authored
-
Matthieu Bouron authored
-
- 06 Oct, 2016 1 commit
-
-
Matthieu Bouron authored
Fixes incompatible pointer type warning on 64-bit systems.
-
- 15 Sep, 2016 1 commit
-
-
Matthieu Bouron authored
-
- 08 Jul, 2016 1 commit
-
-
Matthieu Bouron authored
-
- 23 Jun, 2016 4 commits
-
-
Matthieu Bouron authored
Increase buffer dequeue timeout when the codec needs to be drained as it could happen that no input buffer is available when we receive a null packet for the first time (meaning we are unable to signal end of stream and mark the codec as draining). Fixes potential loss of last frames after sending a null packet.
-
Matthieu Bouron authored
-
Matthieu Bouron authored
-
Matthieu Bouron authored
Their only purpose is to carry the end of stream flag.
-
- 20 Jun, 2016 1 commit
-
-
Matthieu Bouron authored
And sets frames pkt_dts to AV_NOPTS_VALUE as we do not want lavc/utils to overwrite the field with incorrect values as the decoder is asynchronous.
-
- 15 Jun, 2016 1 commit
-
-
Matthieu Bouron authored
Allows to select a codec (encoder or decoder) only if it supports a specific profile. Adds ff_AMediaCodecProfile_getProfileFromAVCodecContext to convert an AVCodecContext profile to a MediaCodec profile. It only supports H264 for now. The codepath using MediaCodecList.findDecoderForFormat() (Android >= 5.0) has been dropped as this method does not allow to select a decoder compatible with a specific profile.
-
- 07 Jun, 2016 1 commit
-
-
Matthieu Bouron authored
-