1. 20 Jul, 2015 2 commits
    • Vittorio Giovara's avatar
      Deprecate avctx.coded_frame · 40cf1bba
      Vittorio Giovara authored
      The rationale is that coded_frame was only used to communicate key_frame,
      pict_type and quality to the caller, as well as a few other random fields,
      in a non predictable, let alone consistent way.
      
      There was agreement that there was no use case for coded_frame, as it is
      a full-sized AVFrame container used for just 2-3 int-sized properties,
      which shouldn't even belong into the AVCodecContext in the first place.
      
      The appropriate AVPacket flag can be used instead of key_frame, while
      quality is exported with the new AVPacketSideData quality factor.
      There is no replacement for the other fields as they were unreliable,
      mishandled or just not used at all.
      Signed-off-by: 's avatarVittorio Giovara <vittorio.giovara@gmail.com>
      40cf1bba
    • Vittorio Giovara's avatar
      Gather all coded_frame allocations and free functions to a single place · d6604b29
      Vittorio Giovara authored
      Allocating coded_frame is what most encoders do anyway, so it makes
      sense to always allocate and free it in a single place. Moreover a lot
      of encoders freed the frame with av_freep() instead of the correct API
      av_frame_free().
      
      This bring uniformity to encoder behaviour and prevents applications
      from erroneusly accessing this field when not allocated. Additionally
      this helps isolating encoders that export information with coded_frame,
      and heavily simplifies its deprecation.
      Signed-off-by: 's avatarVittorio Giovara <vittorio.giovara@gmail.com>
      d6604b29
  2. 26 Mar, 2014 1 commit