• Dale Curtis's avatar
    lavf/mp3dec: don't adjust start time; packets are not adjusted. · 460132c9
    Dale Curtis authored
    7546ac2f made it so that the start_time for mp3 files is
    adjusted for skip_samples. However, this appears incorrect because
    subsequent packet timestamps are not adjusted and skip_samples are
    applied by deleting data from a packet without changing the timestamp.
    
    E.g., we are told the start_time is ~25ms and we get a packet with a
    timestamp of 0 that has had the skip_samples discarded from it. As such
    rendering engines may incorrectly discard everything prior to the
    25ms thinking that is where playback should officially start. Since the
    samples were deleted without adjusting timestamps though, the true
    start_time is still 0.
    
    Other formats like MP4 with edit lists will adjust both the start
    time and the timestamps of subsequent packets to avoid this issue.
    Signed-off-by: 's avatarDale Curtis <dalecurtis@chromium.org>
    Signed-off-by: 's avatarAnton Khirnov <anton@khirnov.net>
    460132c9
mp3dec.c 18.4 KB