• U. Artie Eoff's avatar
    vaapi_encode_mjpeg: fix bad component id bug · f70c3974
    U. Artie Eoff authored
    The compound literals assigned to "components"
    only exist within the scope of the if/else
    block (thanks Mark Thompson for the better
    explanation).
    
    Thus, after this if/else block, "components"
    ends up pointing to an arbitrary/undefined
    array.  With some compilers and depending on
    optimization settings, these arbitrary values
    may end up being the same value (i.e. 0 with
    GNU GCC 9.x).  Unfortunately, the GNU GCC
    compiler, at least, never prints any warnings
    about this.
    
    This patch fixes this issue by assigning the
    constant arrays to local variables at function
    scope and then pointing "components" to those
    as necessary.
    
    Fixes #7915
    Signed-off-by: 's avatarU. Artie Eoff <ullysses.a.eoff@intel.com>
    f70c3974
vaapi_encode_mjpeg.c 17.7 KB