• wm4's avatar
    avformat/mp3dec: improve junk skipping heuristic · de1b1a7d
    wm4 authored
    Commit 2b3e9bbf caused problems for a
    certain API user:
    
    https://code.google.com/p/chromium/issues/detail?id=537725
    https://code.google.com/p/chromium/issues/detail?id=542032
    
    The problem seems rather arbitrary, because if there's junk, anything
    can happen. In this case, the imperfect junk skipping just caused it to
    read different junk, from what I can see.
    
    We can improve the accuracy of junk detection by a lot by checking if 2
    consecutive frames use the same configuration. While in theory it might
    be completely fine for the 1st frame to have a different format than the
    2nd frame, it's exceedingly unlikely, and I can't think of a legitimate
    use-case.
    
    This is approximately the same mpg123 does for junk skipping. The
    set of compared header bits is the same as the libavcodec mp3 parser
    uses for similar purposes.
    de1b1a7d
mp3dec.c 16.6 KB