• Andreas Rheinhardt via ffmpeg-devel's avatar
    avformat/matroskadec: Improve length check · 18a851ac
    Andreas Rheinhardt via ffmpeg-devel authored
    The earlier code had three flaws:
    
    1. The case of an unknown-sized element inside a finite-sized element
    (which is against the specifications) was not caught.
    
    2. The error message wasn't helpful: It compared the length of the child
    with the offset of the end of the parent and claimed that the first
    exceeds the latter, although that is not necessarily true.
    
    3. Unknown-sized elements that are not parsed can't be skipped. Given
    that according to the Matroska specifications only the segment and the
    clusters can be of unknown-size, this is handled by not allowing any
    other units to have infinite size whereas the earlier code would seek
    back by 1 byte upon encountering an infinite-size element that ought
    to be skipped.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@googlemail.com>
    Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    18a851ac
matroskadec.c 150 KB