• Martin Storsjö's avatar
    x86: h264: Don't keep data in the redzone across function calls on 64 bit unix · 570d4b21
    Martin Storsjö authored
    We know that the called function (ff_chroma_inter_body_mmxext)
    doesn't touch the redzone, and thus will be kept intact - thus,
    this doesn't fix any bug per se.
    
    However, valgrind's memcheck tool intentionally assumes that the
    redzone is clobbered on every function call and function return
    (see a long comment in valgrind/memcheck/mc_main.c). This avoids
    false positives in that tool, at the cost of an extra stack pointer
    adjustment.
    
    The other alternative would be a valgrind suppression for this issue,
    but that's an extra burden for everybody that wants to run libavcodec
    within valgrind.
    Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
    570d4b21
h264_deblock.asm 28.4 KB