• Richard Shaffer's avatar
    avformat/hls: clean up duplicate option fields · c116221d
    Richard Shaffer authored
    The HLSContext struct contains fields which duplicate the data stored in the
    avio_opts field. This change removes those fields in favor of avio_opts, and
    updates the code accordingly.
    The original patch caused the buffer pointed to by new_cookies in open_url to be
    leaked. The only thing that buffer is used for is to store the value until it
    can be passed to av_dict_set. To fix the leak, v2 of the patch simply calls
    av_dict_set with the AV_DICT_DONT_STRDUP_VAL flag, so that the dictionary takes
    ownership of the memory instead of copying it again.
    Reviewed-by: 's avatarSteven Liu <lq@chinaffmpeg.org>
    Signed-off-by: 's avatarRichard Shaffer <rshaffer@tunein.com>
    c116221d
hls.c 75.8 KB