• wm4's avatar
    avcodec/h264: remove redundant and bogus get_format call · be583c6f
    wm4 authored
    The AVCodecContext.get_format callback is not only used for pixel format
    negotiation with the API user, but also for hwaccel init. For the
    latter, it's required that some codec parameters, in particular the
    codec profile, are set when the callback is invoked.
    
    This patch removes a get_format invocation where this is not guaranteed.
    The codec parameters, including the profile, are really set further
    below. (The same code path that sets the profile also calls get_format
    properly too.)
    
    This just happened to work by coincidence in most cases. For example, if
    the API user just copied or reused the AVStream's AVCodecContext when
    decoding, the profile would be set properly. But in some cases it
    fails., such as with the sample WolfensteinTwitch.mp4 on the samples
    server.
    
    Remove the redundant get_format call. Apparently it serves no purpose
    anymore, although it is possible that this was different at the time it
    was added in commit ffd77f94.
    
    This fixes hwaccel usage for API users which do not set the profile
    when setting up the AVCodecContext (which is allowed).
    be583c6f
h264_slice.c 97.2 KB