• Andreas Rheinhardt's avatar
    avcodec/mpeg12dec: Sanitize start codes earlier · 093b6894
    Andreas Rheinhardt authored
    The MPEG-1/2 decoder uses avpriv_find_start_code to search for start
    codes and worked with the resulting start code before checking that it
    is really a start code of a slice. In particular, if the picture is so
    big that a slice_vertical_position_extension is present, it added the
    slice_vertical_position_extension as if it had a slice. Then a left
    shift is performed, without making sure that the value to be shifted is
    nonnegative.
    Afterwards the end result is checked, but even if a start code of a
    non-slice has been found, it might pass these checks: If
    slice_vertical_position_extension is present a start code <
    SLICE_MIN_START_CODE can lead to a macroblock-row index that appears
    valid. Furthermore, the left shift might make an invalid start code
    appear valid by discarding the highest bit.
    This has been fixed by checking directly after avpriv_find_start_code
    has returned.
    
    Fixes ticket #8162 (which is about the undefined left shifts).
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    093b6894
mpeg12dec.c 108 KB